arch/x86/kernel/acpi/boot: fix buffer overflow on negative index in mp_config_acpi_gsi()
PATCH 1/1 arch/x86/kernel/acpi/boot: fix buffer overflow on negative index in mp_config_acpi_gsi()
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by Alexander Sapozhnikov <[email protected]>
--- arch/x86/kernel/acpi/boot.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
arch/x86/kernel/acpi/boot.c +4 -2
@@ -463,8 +463,10 @@ static void mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger, mp_irq.srcbus = number; mp_irq.srcbusirq = (((devfn >>3 ) &0x1f ) <<2 ) | ((pin -1 ) &3 ); ioapic =mp_find_ioapic (gsi); - mp_irq.dstapic =mpc_ioapic_id (ioapic); - mp_irq.dstirq =mp_find_ioapic_pin (ioapic, gsi); +if (ioapic >=0 ) { + mp_irq.dstapic =mpc_ioapic_id (ioapic); + mp_irq.dstirq =mp_find_ioapic_pin (ioapic, gsi); + }mp_save_irq (&mp_irq);#endif
Signature · 1 line
2.34.1