Skip to contentSkip to conversation

sandbox: video: Fix building without SDL

PATCH In review Simon Glass 2 participants 2 messages Feb 17, 2023 – Apr 7, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sandbox: video: Fix building without SDL

This is currently broken. If SDL is not installed, SANDBOX_SDL becomes false and build errors are generated, e.g.:

test/dm/video.c:424: undefined reference to `sandbox_sdl_set_bpp'

Fix it by making the function return an error in this case.

---

 arch/sandbox/include/asm/test.h | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/sandbox/include/asm/test.h +8 -0
index 4853dc948f3..e482271fe97 100644
@@ -300,6 +300,7 @@ void sandbox_cros_ec_set_test_flags(struct udevice *dev, uint flags);
  */
 int sandbox_cros_ec_get_pwm_duty(struct udevice *dev, uint index, uint *duty);
 
+#if IS_ENABLED(CONFIG_SANDBOX_SDL)
 /**
  * sandbox_sdl_set_bpp() - Set the depth of the sandbox display
  *
@@ -315,6 +316,13 @@ int sandbox_cros_ec_get_pwm_duty(struct udevice *dev, uint index, uint *duty);
  * after the change
  */
 int sandbox_sdl_set_bpp(struct udevice *dev, enum video_log2_bpp l2bpp);
+#else
+static inline int sandbox_sdl_set_bpp(struct udevice *dev,
+				      enum video_log2_bpp l2bpp)
+{
+	return -ENOSYS;
+}
+#endif
 
 /**
  * sandbox_set_fake_efi_mgr_dev() - Control EFI bootmgr producing valid bootflow
Signature · 1 line
2.39.2.637.g21b0678d19-goog
#1 lore raw
Quoted 5 lines · On Fri, 17 Feb 2023 15:45:47 -0700 Simon Glass [email protected] wrote:

This is currently broken. If SDL is not installed, SANDBOX_SDL becomes false and build errors are generated, e.g.:

test/dm/video.c:424: undefined reference to `sandbox_sdl_set_bpp'

Quoted 7 lines

Fix it by making the function return an error in this case.

---

 arch/sandbox/include/asm/test.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Applied to u-boot-video/master, thanks!

--
Anatolij