Skip to contentSkip to conversation

packge/libabseil-cpp: bump to version 20230125.0

PATCH In review Michael Nosthoff via buildroot 1 participant 3 messages Feb 18, 2023 – Feb 20, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 packge/libabseil-cpp: bump to version 20230125.0

libabseil now depends on c++14 and gcc >= 7.3.1 [0][1]

[0] https://github.com/abseil/abseil-cpp/releases/tag/20230125.0
[1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md

---

Note:
I'm not sure if the BR2_TOOLCHAIN_GCC_AT_LEAST_7 dependency is sufficient. But I don't think we have a more version specific Flag available?

---
 package/grpc/Config.in                   | 6 +++---
 package/libabseil-cpp/Config.in          | 6 +++---
 package/libabseil-cpp/libabseil-cpp.hash | 2 +-
 package/libabseil-cpp/libabseil-cpp.mk   | 6 +++---
 4 files changed, 10 insertions(+), 10 deletions(-)
package/grpc/Config.in +3 -3
index db6425819b..06436fe888 100644
@@ -3,7 +3,7 @@ config BR2_PACKAGE_GRPC
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf, re2
 	depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # protobuf
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # libabseil-cpp
 	depends on !BR2_STATIC_LIBS # protobuf, libabseil-cpp
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
@@ -19,9 +19,9 @@ config BR2_PACKAGE_GRPC
 
 	  http://github.com/grpc/grpc
 
-comment "grpc needs a toolchain w/ C++, threads, dynamic library, gcc >= 5"
+comment "grpc needs a toolchain w/ C++, threads, dynamic library, gcc >= 7"
 	depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \
-		|| BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_5
+		|| BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_7
 	depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
package/libabseil-cpp/Config.in +3 -3
index 45f339ff26..d4139e8e04 100644
@@ -18,7 +18,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 config BR2_PACKAGE_LIBABSEIL_CPP
 	bool "libabseil-cpp"
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS # uses dlfcn.h
 	depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
@@ -31,7 +31,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP
 
 	  https://github.com/abseil/abseil-cpp
 
-comment "libabseil-cpp needs a toolchain w/ gcc >= 4.9, C++, threads, dynamic library"
+comment "libabseil-cpp needs a toolchain w/ gcc >= 7.3.1, C++14, threads, dynamic library"
 	depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
-		BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+		BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_7
package/libabseil-cpp/libabseil-cpp.hash +1 -1
index 808bdbab29..81710f50fb 100644
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  91ac87d30cc6d79f9ab974c51874a704de9c2647c40f6932597329a282217ba8  libabseil-cpp-20220623.1.tar.gz
+sha256  3ea49a7d97421b88a8c48a0de16c16048e17725c7ec0f1d3ea2683a2a75adc21  libabseil-cpp-20230125.0.tar.gz
 sha256  c79a7fea0e3cac04cd43f20e7b648e5a0ff8fa5344e644b0ee09ca1162b62747  LICENSE
package/libabseil-cpp/libabseil-cpp.mk +3 -3
index ceda106b7d..4e6ac2ee31 100644
@@ -4,19 +4,19 @@
 #
 ################################################################################
 
-LIBABSEIL_CPP_VERSION = 20220623.1
+LIBABSEIL_CPP_VERSION = 20230125.0
 LIBABSEIL_CPP_SITE = $(call github,abseil,abseil-cpp,$(LIBABSEIL_CPP_VERSION))
 LIBABSEIL_CPP_LICENSE = Apache-2.0
 LIBABSEIL_CPP_LICENSE_FILES = LICENSE
 LIBABSEIL_CPP_INSTALL_STAGING = YES
 
 LIBABSEIL_CPP_CONF_OPTS = \
-	-DCMAKE_CXX_STANDARD=11 \
+	-DCMAKE_CXX_STANDARD=14 \
 	-DABSL_ENABLE_INSTALL=ON \
 	-DABSL_USE_GOOGLETEST_HEAD=OFF
 
 HOST_LIBABSEIL_CPP_CONF_OPTS = \
-	-DCMAKE_CXX_STANDARD=11 \
+	-DCMAKE_CXX_STANDARD=14 \
 	-DABSL_ENABLE_INSTALL=ON \
 	-DABSL_USE_GOOGLETEST_HEAD=OFF
 
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Michael,

Quoted 11 lines · On Sat, 18 Feb 2023 12:48:37 +0100 Michael Nosthoff via buildroot…

libabseil now depends on c++14 and gcc >= 7.3.1 [0][1]

[0] https://github.com/abseil/abseil-cpp/releases/tag/20230125.0
[1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md

---

Note:
I'm not sure if the BR2_TOOLCHAIN_GCC_AT_LEAST_7 dependency is sufficient. But I don't think we have a more version specific Flag available?

We don't have more specific blind options than 7.x, 8.x, etc. to describe a gcc dependency.

Quoted 5 lines
 package/grpc/Config.in                   | 6 +++---
 package/libabseil-cpp/Config.in          | 6 +++---
 package/libabseil-cpp/libabseil-cpp.hash | 2 +-
 package/libabseil-cpp/libabseil-cpp.mk   | 6 +++---
 4 files changed, 10 insertions(+), 10 deletions(-)

I'm afraid this is not sufficient. Indeed, you need to look at the reverse dependencies of GRPC for example.

So, package/falcosecurity-libs needs to be adjusted, then package/sysdig as well, and also the BR2_PACKAGE_COLLECTD_GRPC option from package/collectd.

Could you have a look into this, and submit an updated version?

Thanks a lot!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Hi,

Quoted 26 lines · Thomas Petazzoni

Hello Michael,

Quoted 11 lines · On Sat, 18 Feb 2023 12:48:37 +0100 Michael Nosthoff via buildroot…

libabseil now depends on c++14 and gcc >= 7.3.1 [0][1]

[0] https://github.com/abseil/abseil-cpp/releases/tag/20230125.0
[1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md

---

Note:
I'm not sure if the BR2_TOOLCHAIN_GCC_AT_LEAST_7 dependency is sufficient. But I don't think we have a more version specific Flag available?

We don't have more specific blind options than 7.x, 8.x, etc. to describe a gcc dependency.

Quoted 5 lines
 package/grpc/Config.in                   | 6 +++---
 package/libabseil-cpp/Config.in          | 6 +++---
 package/libabseil-cpp/libabseil-cpp.hash | 2 +-
 package/libabseil-cpp/libabseil-cpp.mk   | 6 +++---
 4 files changed, 10 insertions(+), 10 deletions(-)
Quoted 7 lines

I'm afraid this is not sufficient. Indeed, you need to look at the reverse dependencies of GRPC for example.

So, package/falcosecurity-libs needs to be adjusted, then package/sysdig as well, and also the BR2_PACKAGE_COLLECTD_GRPC option from package/collectd.

good point. since grpc now also only has "officially support for gcc 7.3+" I would then first bump grpc with all it dependencies and then resubmit this patch.

https://github.com/grpc/grpc/blob/master/src/cpp/README.md

Quoted 5 lines

Could you have a look into this, and submit an updated version?

Thanks a lot!

Thomas

Regards,
Michael

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot