net/gve: add Rx/Tx queue statistics
PATCH 1/1 net/gve: add Rx/Tx queue statistics
Google Virtual NIC PMD is enriched with rx/tx queue statistics info.
Signed-off-by Levend Sayar <[email protected]>
--- drivers/net/gve/gve_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/net/gve/gve_ethdev.c +8 -0
@@ -213,6 +213,7 @@ gve_dev_start(struct rte_eth_dev *dev) } } + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; dev->data->dev_started =1 ;gve_link_update (dev,0 );
@@ -331,6 +332,9 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->opackets += txq->packets; stats->obytes += txq->bytes; stats->oerrors += txq->errors; + + stats->q_opackets[i] = txq->packets; + stats->q_obytes[i] = txq->bytes; }for (i =0 ; i < dev->data->nb_rx_queues; i++) {
@@ -342,6 +346,10 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->ibytes += rxq->bytes; stats->ierrors += rxq->errors; stats->rx_nombuf += rxq->no_mbufs; + + stats->q_ipackets[i] = rxq->packets; + stats->q_ibytes[i] = rxq->bytes; + stats->q_errors[i] = rxq->errors; }return 0 ;
Signature · 1 line
2.37.1 (Apple Git-137.1)
Ferruh Yigit
NAKQuoted 30 lines · Levend Sayar
Google Virtual NIC PMD is enriched with rx/tx queue statistics info.
Signed-off-by Levend Sayar <[email protected]>--- drivers/net/gve/gve_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/net/gve/gve_ethdev.c +4
-0@@ -213,6 +213,7 @@ gve_dev_start(struct rte_eth_dev *dev) } } + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; dev->data->dev_started =1 ;gve_link_update (dev,0 );@@ -331,6 +332,9 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->opackets += txq->packets; stats->obytes += txq->bytes; stats->oerrors += txq->errors; + + stats->q_opackets[i] = txq->packets; + stats->q_obytes[i] = txq->bytes; }for (i =0 ; i < dev->data->nb_rx_queues; i++) {
drivers/net/gve/gve_ethdev.c gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) · line 355
Quoted 10 lines
drivers/net/gve/gve_ethdev.c +4
-0@@ -342,6 +346,10 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->ibytes += rxq->bytes; stats->ierrors += rxq->errors; stats->rx_nombuf += rxq->no_mbufs; + + stats->q_ipackets[i] = rxq->packets; + stats->q_ibytes[i] = rxq->bytes; + stats->q_errors[i] = rxq->errors; }return 0 ;
nack,
as explained in other thread [1], we need to implement xstats in driver without relying on 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.