Skip to contentSkip to conversation

virtio-net: define the VIRTIO_NET_F_CTRL_RX_EXTRA feature bit

PATCH In review Alvaro Karsz 2 participants 3 messages Feb 22, 2023 – Feb 26, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 virtio-net: define the VIRTIO_NET_F_CTRL_RX_EXTRA feature bit

The VIRTIO_NET_F_CTRL_RX_EXTRA feature bit is mentioned in the spec since version 1.0, but it's not properly defined.

This patch defines the feature bit and defines the dependency on VIRTIO_NET_F_CTRL_VQ.

Since this dependency is missing in previous versions, we add it now as a "SHOULD".

---
v2:
- Rephrase commit log, no changes to patch body.

 device-types/net/description.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
device-types/net/description.tex +8 -0
index 8487ccd..cf37da5 100644
@@ -74,6 +74,8 @@ \subsection{Feature bits}\label{sec:Device Types / Network Device / Feature bits
 
 \item[VIRTIO_NET_F_CTRL_VLAN (19)] Control channel VLAN filtering.
 
+\item[VIRTIO_NET_F_CTRL_RX_EXTRA (20)]	Control channel RX extra mode support.
+
 \item[VIRTIO_NET_F_GUEST_ANNOUNCE(21)] Driver can send gratuitous
     packets.
 
@@ -259,6 +261,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
 The device SHOULD NOT offer VIRTIO_NET_F_HASH_REPORT if it
 does not offer VIRTIO_NET_F_CTRL_VQ.
 
+The device SHOULD NOT offer VIRTIO_NET_F_CTRL_RX_EXTRA if it
+does not offer VIRTIO_NET_F_CTRL_VQ.
+
 \drivernormative{\subsubsection}{Device configuration layout}{Device Types / Network Device / Device configuration layout}
 
 A driver SHOULD negotiate VIRTIO_NET_F_MAC if the device offers it.
@@ -295,6 +300,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
 A driver SHOULD NOT negotiate VIRTIO_NET_F_HASH_REPORT if it
 does not negotiate VIRTIO_NET_F_CTRL_VQ.
 
+A driver SHOULD NOT negotiate VIRTIO_NET_F_CTRL_RX_EXTRA if it
+does not negotiate VIRTIO_NET_F_CTRL_VQ.
+
 \subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device Types / Network Device / Device configuration layout / Legacy Interface: Device configuration layout}
 \label{sec:Device Types / Block Device / Feature bits / Device configuration layout / Legacy Interface: Device configuration layout}
 When using the legacy interface, transitional devices and drivers
Signature · 6 lines
2.34.1


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Reviewed-by on v2 1/1
#1 lore raw
Quoted 59 lines

From: [email protected] <[email protected]> On Behalf Of Alvaro Karsz

The VIRTIO_NET_F_CTRL_RX_EXTRA feature bit is mentioned in the spec since version 1.0, but it's not properly defined.

This patch defines the feature bit and defines the dependency on VIRTIO_NET_F_CTRL_VQ.

Since this dependency is missing in previous versions, we add it now as a "SHOULD".

---
v2:
- Rephrase commit log, no changes to patch body.

 device-types/net/description.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
device-types/net/description.tex +0 -0
index 8487ccd..cf37da5 100644
@@ -74,6 +74,8 @@ \subsection{Feature bits}\label{sec:Device Types /

Network Device / Feature bits

\item[VIRTIO_NET_F_CTRL_VLAN (19)] Control channel VLAN filtering.

+\item[VIRTIO_NET_F_CTRL_RX_EXTRA (20)] Control channel RX extra
mode support.

device-types/net/description.tex +1 -0
+
 \item[VIRTIO_NET_F_GUEST_ANNOUNCE(21)] Driver can send gratuitous
     packets.
@@ -259,6 +261,9 @@ \subsection{Device configuration

layout}\label{sec:Device Types / Network Device The device SHOULD NOT offer VIRTIO_NET_F_HASH_REPORT if it does not offer VIRTIO_NET_F_CTRL_VQ.

device-types/net/description.tex +3 -0
+The device SHOULD NOT offer VIRTIO_NET_F_CTRL_RX_EXTRA if it does not
+offer VIRTIO_NET_F_CTRL_VQ.
+
 \drivernormative{\subsubsection}{Device configuration layout}{Device Types /

Network Device / Device configuration layout}

A driver SHOULD negotiate VIRTIO_NET_F_MAC if the device offers it.

device-types/net/description.tex +0 -0
@@ -295,6 +300,9 @@ \subsection{Device configuration

layout}\label{sec:Device Types / Network Device A driver SHOULD NOT negotiate VIRTIO_NET_F_HASH_REPORT if it does not negotiate VIRTIO_NET_F_CTRL_VQ.

device-types/net/description.tex +3 -0
+A driver SHOULD NOT negotiate VIRTIO_NET_F_CTRL_RX_EXTRA if it does not
+negotiate VIRTIO_NET_F_CTRL_VQ.
+
 \subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device
Quoted 6 lines

Types / Network Device / Device configuration layout / Legacy Interface: Device configuration layout} \label{sec:Device Types / Block Device / Feature bits / Device configuration layout / Legacy Interface: Device configuration layout} When using the legacy interface, transitional devices and drivers --
2.34.1

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/