net: sunhme: Fix region request
Subsystems (3)
Sean Anderson
maintainerPATCH 1/1 net: sunhme: Fix region request
devm_request_region is for I/O regions. Use devm_request_mem_region instead. This fixes the driver failing to probe since 99df45c9e0a4 ("sunhme: fix an IS_ERR() vs NULL check in probe"), which checked the result.
Fixes 914d9b2711dd ("sunhme: switch to devres")
Signed-off-by Sean Anderson <[email protected]>
---
drivers/net/ethernet/sun/sunhme.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/sun/sunhme.c +4 -2
@@ -2894,8 +2894,10 @@ static int happy_meal_pci_probe(struct pci_dev *pdev, goto err_out_clear_quattro; } - hpreg_res =devm_request_region (&pdev->dev,pci_resource_start (pdev,0 ), -pci_resource_len (pdev,0 ),DRV_NAME ); + hpreg_res =devm_request_mem_region (&pdev->dev, +pci_resource_start (pdev,0 ), +pci_resource_len (pdev,0 ), +DRV_NAME );if (!hpreg_res) { err = -EBUSY ;dev_err (&pdev->dev,"Cannot obtain PCI resources, aborting.\n" );
Signature · 1 line
2.37.1
Quoted 10 lines · Sean Anderson
devm_request_regionis for I/O regions. Usedevm_request_mem_regioninstead. This fixes the driver failing to probe since99df45c9e0a4("sunhme: fix anIS_ERR()vs NULL check in probe"), which checked the result.Fixes 914d9b2711dd ("sunhme: switch to devres")Signed-off-by Sean Anderson <[email protected]>---
Looks OK to me.
Reviewed-by Pavan Chebbi <[email protected]>
Quoted 23 lines
drivers/net/ethernet/sun/sunhme.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/net/ethernet/sun/sunhme.c +4
-3@@ -2894,8 +2894,10 @@ static int happy_meal_pci_probe(struct pci_dev *pdev, goto err_out_clear_quattro; } - hpreg_res =devm_request_region (&pdev->dev,pci_resource_start (pdev,0 ), -pci_resource_len (pdev,0 ),DRV_NAME ); + hpreg_res =devm_request_mem_region (&pdev->dev, +pci_resource_start (pdev,0 ), +pci_resource_len (pdev,0 ), +DRV_NAME );if (!hpreg_res) { err = -EBUSY ;dev_err (&pdev->dev,"Cannot obtain PCI resources, aborting.\n" ); --2.37.1
Quoted 7 lines · On Wed, 22 Feb 2023 15:42:41 -0500 Sean Anderson wrote:
devm_request_regionis for I/O regions. Usedevm_request_mem_regioninstead. This fixes the driver failing to probe since99df45c9e0a4("sunhme: fix anIS_ERR()vs NULL check in probe"), which checked the result.Fixes 914d9b2711dd ("sunhme: switch to devres")Signed-off-by Sean Anderson <[email protected]>
Applied, thanks!