staging: rtl8192u: remove split in user-visible string
PATCH v2 1/1 staging: rtl8192u: remove split in user-visible string
According to coding style, user-visible strings in printk() function calls cannot be split across multiple lines. Issue found with checkpatch.pl.
---
Changes in v2:
- Replace printk(KERN_DEBUG...) with pr_debug()
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +2 -4
@@ -72,16 +72,14 @@ static void *ieee80211_tkip_init(int key_idx) priv->tx_tfm_michael =crypto_alloc_shash ("michael_mic" ,0 ,0 );if (IS_ERR (priv->tx_tfm_michael)) { -printk (KERN_DEBUG "ieee80211_crypt_tkip: could not allocate " -"crypto API michael_mic\n" ); +pr_debug ("ieee80211_crypt_tkip: could not allocate crypto API michael_mic\n" ); priv->tx_tfm_michael =NULL ; goto fail; } priv->rx_tfm_michael =crypto_alloc_shash ("michael_mic" ,0 ,0 );if (IS_ERR (priv->rx_tfm_michael)) { -printk (KERN_DEBUG "ieee80211_crypt_tkip: could not allocate " -"crypto API michael_mic\n" ); +pr_debug ("ieee80211_crypt_tkip: could not allocate crypto API michael_mic\n" ); priv->rx_tfm_michael =NULL ; goto fail; }
Signature · 1 line
2.39.2
Quoted 8 lines · Leonid Pershin
According to coding style, user-visible strings in
printk()function calls cannot be split across multiple lines. Issue found with checkpatch.pl.Signed-off-by Leonid Pershin <[email protected]>---
Changes in v2:
- Replaceprintk(KERN_DEBUG...)withpr_debug()
Hello Leonid,
I was not able to trace the v1 of this patch. Did that have a different subject?
Thank you,
Deepak.
Quoted 3 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
A message that is not in the archive (sent off-list or not yet received): CABa+115WFC0cJ+-L_rNHy3YPOVuVMxgVDidyCLoNE4xYhsRxZg@mail.gmail.com
Quoted 4 lines · Леонид Першин
Quoted 2 lines · Deepak R Varma
Hello Leonid,
I was not able to trace the v1 of this patch. Did that have a differentsubject?
The line above broke for me in your response. This could be the email editor issue on your side.
Quoted 6 lines
Quoted 3 lines
Thank you,
Deepak.Hello Deepak,
Sorry, I've sent v1 directly to Greg by mistake. Here it is:
No problem. It is important to record such reasons for the reviewer's awareness. Also, it is a common practice to give credit to the reviewers by mentioning their name in the "Change in vx" section.
Good luck.
Deepak.
Quoted 48 lines · Leonid Pershin
Quoted 5 lines
According to coding style, user-visible strings in
printk()function calls cannot be split across multiple lines. Issue found with checkpatch.pl.Signed-off-by Leonid Pershin <[email protected]>Review
Quoted 8 lines
---
Changes in v2:
- Replaceprintk(KERN_DEBUG...)withpr_debug()drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.cdrivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c static void *ieee80211_tkip_init(int key_idx) · line 75
Quoted 8 lines
index
9bfd24ad46b6..c378bdff453b100644drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +0
-1@@ -72,16 +72,14 @@ static void *ieee80211_tkip_init(int key_idx) priv->tx_tfm_michael =crypto_alloc_shash ("michael_mic" ,0 ,0 );if (IS_ERR (priv->tx_tfm_michael)) { - printk(KERN_DEBUG "ieee80211_crypt_tkip: could not allocate"
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c static void *ieee80211_tkip_init(int key_idx) · line 75
Quoted 2 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +1
-1- "crypto API michael_mic\n"); + pr_debug("ieee80211_crypt_tkip: could not allocate cryptoAPI michael_mic\n");
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c static void *ieee80211_tkip_init(int key_idx)
Quoted 7 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +0
-1priv->tx_tfm_michael =NULL ; goto fail; } priv->rx_tfm_michael =crypto_alloc_shash ("michael_mic" ,0 ,0 );if (IS_ERR (priv->rx_tfm_michael)) { - printk(KERN_DEBUG "ieee80211_crypt_tkip: could not allocate"
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c static void *ieee80211_tkip_init(int key_idx) · line 82
Quoted 2 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +1
-1- "crypto API michael_mic\n"); + pr_debug("ieee80211_crypt_tkip: could not allocate cryptoAPI michael_mic\n");
Quoted 6 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +0
-1priv->rx_tfm_michael =NULL ; goto fail; } --2.39.2
Sincerely,
Leonid
Greg Kroah-Hartman
maintainerQuoted 8 lines · Leonid Pershin
According to coding style, user-visible strings in
printk()function calls cannot be split across multiple lines. Issue found with checkpatch.pl.Signed-off-by Leonid Pershin <[email protected]>---
Changes in v2:
- Replaceprintk(KERN_DEBUG...)withpr_debug()
Now you are doing two different things, please only do one thing per patch.
Quoted 9 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +0
-0
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c static void *ieee80211_tkip_init(int key_idx) · line 75
Quoted 6 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +1
-2@@ -72,16 +72,14 @@ static void *ieee80211_tkip_init(int key_idx) priv->tx_tfm_michael =crypto_alloc_shash ("michael_mic" ,0 ,0 );if (IS_ERR (priv->tx_tfm_michael)) { -printk (KERN_DEBUG "ieee80211_crypt_tkip: could not allocate " -"crypto API michael_mic\n" ); +pr_debug ("ieee80211_crypt_tkip: could not allocate crypto API michael_mic\n" );
Are you sure you need the prefix now that you are using pr_debug()? And as this is a driver, why not use the networking debug macros instead?
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c static void *ieee80211_tkip_init(int key_idx) · line 82
Quoted 9 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +1
-2priv->tx_tfm_michael =NULL ; goto fail; } priv->rx_tfm_michael =crypto_alloc_shash ("michael_mic" ,0 ,0 );if (IS_ERR (priv->rx_tfm_michael)) { -printk (KERN_DEBUG "ieee80211_crypt_tkip: could not allocate " -"crypto API michael_mic\n" ); +pr_debug ("ieee80211_crypt_tkip: could not allocate crypto API michael_mic\n" );
Same here, do you still need the prefix and why not dev_dbg() or the network version?
thanks,
greg k-h