Skip to contentSkip to conversation

bcache: Remove dead references to cache_readaheads

PATCH In review Andrea Tomassetti 2 participants 2 messages Feb 25, 2023 – Feb 27, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcache: Remove dead references to cache_readaheads

The cache_readaheads stat counter is not used anymore and should be removed.

---
 Documentation/admin-guide/bcache.rst | 3 ---
 drivers/md/bcache/stats.h            | 1 -
 2 files changed, 4 deletions(-)
Documentation/admin-guide/bcache.rst +0 -3
index bb5032a99234..6fdb495ac466 100644
@@ -508,9 +508,6 @@ cache_miss_collisions
   cache miss, but raced with a write and data was already present (usually 0
   since the synchronization for cache misses was rewritten)
 
-cache_readaheads
-  Count of times readahead occurred.
-
 Sysfs - cache set
 ~~~~~~~~~~~~~~~~~
 
drivers/md/bcache/stats.h +0 -1
index bd3afc856d53..21b445f8af15 100644
@@ -18,7 +18,6 @@ struct cache_stats {
 	unsigned long cache_misses;
 	unsigned long cache_bypass_hits;
 	unsigned long cache_bypass_misses;
-	unsigned long cache_readaheads;
 	unsigned long cache_miss_collisions;
 	unsigned long sectors_bypassed;
 
Signature · 1 line
2.39.2
#1 lore raw
Quoted 8 lines

2023年2月25日 23:33,Andrea Tomassetti <[email protected]> 写道:

The cache_readaheads stat counter is not used anymore and should be removed.

Nice cache, added to my for-next.

Thanks.

Coly Li

Quoted 34 lines

---
Documentation/admin-guide/bcache.rst | 3 ---
drivers/md/bcache/stats.h | 1 -

2 files changed, 4 deletions(-)
Documentation/admin-guide/bcache.rst +0 -3
index bb5032a99234..6fdb495ac466 100644
@@ -508,9 +508,6 @@ cache_miss_collisions
  cache miss, but raced with a write and data was already present (usually 0
  since the synchronization for cache misses was rewritten)
 
-cache_readaheads
-  Count of times readahead occurred.
-

Sysfs - cache set
~~~~~~~~~~~~~~~~~

drivers/md/bcache/stats.h +0 -1
index bd3afc856d53..21b445f8af15 100644
@@ -18,7 +18,6 @@ struct cache_stats {
 unsigned long cache_misses;
 unsigned long cache_bypass_hits;
 unsigned long cache_bypass_misses;
- unsigned long cache_readaheads;
 unsigned long cache_miss_collisions;
 unsigned long sectors_bypassed;
 
Signature · 1 line
2.39.2