Skip to contentSkip to conversation

udf: Define EFSCORRUPTED error code

PATCH In review Sasha Levin 3 participants 6 messages Feb 26, 2023 – Feb 27, 2023

Subsystems (2)
lore
Share & tools
lore

Sasha Levin

author maintainer
#0 lore raw

PATCH 1/3 udf: Define EFSCORRUPTED error code

From: Jan Kara <[email protected]>

[ Upstream commit 3d2d7e61553dbcc8ba45201d8ae4f383742c8202 ]

Similarly to other filesystems define EFSCORRUPTED error code for reporting internal filesystem corruption.

---
 fs/udf/udf_sb.h | 2 ++
 1 file changed, 2 insertions(+)
fs/udf/udf_sb.h +2 -0
index d12e507e9eb2a..aa58173b468fb 100644
@@ -57,6 +57,8 @@
 #define MF_DUPLICATE_MD		0x01
 #define MF_MIRROR_FE_LOADED	0x02
 
+#define EFSCORRUPTED EUCLEAN
+
 struct udf_meta_data {
 	__u32	s_meta_file_loc;
 	__u32	s_mirror_file_loc;
Signature · 1 line
2.39.0
author maintainer
#1 lore raw

PATCH 2/3 ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy

From: Markuss Broks <[email protected]>

[ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ]

For some reason, the driver adding support for Exynos5420 MIPI phy back in 2016 wasn't used on Exynos5420, which caused a kernel panic. Add the proper compatible for it.

---
 arch/arm/boot/dts/exynos5420.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420.dtsi +1 -1
index aaff158807613..99e2e0b0b9cd4 100644
@@ -530,7 +530,7 @@ dp_phy: dp-video-phy {
 		};
 
 		mipi_phy: mipi-video-phy {
-			compatible = "samsung,s5pv210-mipi-video-phy";
+			compatible = "samsung,exynos5420-mipi-video-phy";
 			syscon = <&pmu_system_controller>;
 			#phy-cells = <1>;
 		};
Signature · 7 lines
2.39.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

Re: [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy

Hi!

Quoted 7 lines

From: Markuss Broks <[email protected]>

[ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ]

For some reason, the driver adding support for Exynos5420 MIPI phy back in 2016 wasn't used on Exynos5420, which caused a kernel panic. Add the proper compatible for it.

This is likely bad idea for 4.14, as that compatible is still in use:

drivers/phy/samsung/phy-exynos-mipi-video.c: .compatible = "samsung,s5pv210-mipi-video-phy",
arch/arm/boot/dts/exynos5420.dtsi: compatible = "samsung,s5pv210-mipi-video-phy";
arch/arm/boot/dts/exynos3250.dtsi: compatible = "samsung,s5pv210-mipi-video-phy";
arch/arm/boot/dts/exynos4.dtsi: compatible = "samsung,s5pv210-mipi-video-phy";

phy-exynos-mipi-video.c lists other compatibles, too, but with different data.

Best regards,
Pavel

Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.
#3 lore raw

Re: [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy

Quoted 11 lines · Pavel Machek

Hi!

Quoted 7 lines

From: Markuss Broks <[email protected]>

[ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ]

For some reason, the driver adding support for Exynos5420 MIPI phy back in 2016 wasn't used on Exynos5420, which caused a kernel panic. Add the proper compatible for it.

This is likely bad idea for 4.14, as that compatible is still in use:

I don't understand this. What does it mean? That compatible was used and still is used somewhere... Just because incorrect compatible is used somewhere is not really related whether it should be (or not) replaced with correct compatible.

BTW you mentioned v4.14 but AUTOSEL is for v4.19.

Quoted 8 lines

drivers/phy/samsung/phy-exynos-mipi-video.c: .compatible = "samsung,s5pv210-mipi-video-phy",
arch/arm/boot/dts/exynos5420.dtsi: compatible = "samsung,s5pv210-mipi-video-phy";
arch/arm/boot/dts/exynos3250.dtsi: compatible = "samsung,s5pv210-mipi-video-phy";
arch/arm/boot/dts/exynos4.dtsi: compatible = "samsung,s5pv210-mipi-video-phy";

phy-exynos-mipi-video.c lists other compatibles, too, but with different data.

Best regards,
Krzysztof

author maintainer
#4 lore raw

PATCH 3/3 sched/fair: sanitize vruntime of entity being placed

In reply to Sasha Levin

From: Zhang Qiao <[email protected]>

[ Upstream commit 829c1651e9c4a6f78398d3e67651cef9bb6b42cc ]

When a scheduling entity is placed onto cfs_rq, its vruntime is pulled to the base level (around cfs_rq->min_vruntime), so that the entity doesn't gain extra boost when placed backwards.

However, if the entity being placed wasn't executed for a long time, its vruntime may get too far behind (e.g. while cfs_rq was executing a low-weight hog), which can inverse the vruntime comparison due to s64 overflow. This results in the entity being placed with its original vruntime way forwards, so that it will effectively never get to the cpu.

To prevent that, ignore the vruntime of the entity being placed if it didn't execute for much longer than the characteristic sheduler time scale.

---
 kernel/sched/fair.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)
kernel/sched/fair.c +13 -2
index 84e7efda98daf..304e7fa0ae870 100644
@@ -3858,6 +3858,7 @@ static void
 place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int initial)
 {
 	u64 vruntime = cfs_rq->min_vruntime;
+	u64 sleep_time;
 
 	/*
 	 * The 'current' period is already promised to the current tasks,
@@ -3882,8 +3883,18 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int initial)
 		vruntime -= thresh;
 	}
 
-	/* ensure we never gain time by being placed backwards. */
-	se->vruntime = max_vruntime(se->vruntime, vruntime);
+	/*
+	 * Pull vruntime of the entity being placed to the base level of
+	 * cfs_rq, to prevent boosting it if placed backwards.  If the entity
+	 * slept for a long time, don't even try to compare its vruntime with
+	 * the base as it may be too far off and the comparison may get
+	 * inversed due to s64 overflow.
+	 */
+	sleep_time = rq_clock_task(rq_of(cfs_rq)) - se->exec_start;
+	if ((s64)sleep_time > 60LL * NSEC_PER_SEC)
+		se->vruntime = vruntime;
+	else
+		se->vruntime = max_vruntime(se->vruntime, vruntime);
 }
 
 static void check_enqueue_throttle(struct cfs_rq *cfs_rq);
Signature · 1 line
2.39.0
#5 lore raw
In reply to Sasha Levin

Hi!

Quoted 6 lines

From: Jan Kara <[email protected]>

[ Upstream commit 3d2d7e61553dbcc8ba45201d8ae4f383742c8202 ]

Similarly to other filesystems define EFSCORRUPTED error code for reporting internal filesystem corruption.

Does not fix a bug, AFAICT, and should not be in stable.

If we need it in future, this should go in as a dependency.

Best regards,
Pavel

Quoted 11 lines
fs/udf/udf_sb.h +2 -0
@@ -57,6 +57,8 @@
 #define MF_DUPLICATE_MD		0x01
 #define MF_MIRROR_FE_LOADED	0x02
 
+#define EFSCORRUPTED EUCLEAN
+
 struct udf_meta_data {
 	__u32	s_meta_file_loc;
 	__u32	s_mirror_file_loc;
Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.