migrate_pages: silence gcc notes for mis-casting
Subsystems (2)
PATCH 1/1 migrate_pages: silence gcc notes for mis-casting
The following GCC notes was reported for commit 64c8902ed441 ("migrate_pages: split unmap_and_move() to _unmap() and _move()").
mm/migrate.c: In function ‘__migrate_folio_extract’:
mm/migrate.c:1050:20: note: randstruct: casting between randomized
structure pointer types (ssa): ‘struct anon_vma’ and ‘struct address_space’
1050 | *anon_vmap = (void *)dst->mapping;
| ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~The casting itself is safe. Because we only use dst->mapping to store the pointer itself temporarily and dst is a newly allocated folio and not used by anyone else during that. But the notes should be silenced and some comments are deserved. So, we do that in this patch.
Fixes 64c8902ed441 ("migrate_pages: split unmap_and_move() to _unmap() and _move()")
Signed-off-by "Huang, Ying" <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Baolin Wang <[email protected]>
Cc Xin Hao <[email protected]>
Cc Zi Yan <[email protected]>
Cc Yang Shi <[email protected]>
Cc Oscar Salvador <[email protected]>
Cc Matthew Wilcox <[email protected]>
Cc Bharata B Rao <[email protected]>
Cc Alistair Popple <[email protected]>
--- mm/migrate.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
mm/migrate.c +10 -1
@@ -1047,7 +1047,16 @@ static void __migrate_folio_extract(struct folio *dst,int *page_was_mappedp, struct anon_vma **anon_vmap) { - *anon_vmap = (void *)dst->mapping; + struct anon_vma *anon_vma; + +/* +* 2 steps assignment to silence gcc notes for mis-casting. The +* casting is safe. Because we only use dst->mapping to store +* the pointer itself temporarily and dst is a newly allocated +* folio and not used by anyone else during that. +*/ + anon_vma = (void *)dst->mapping; + *anon_vmap = anon_vma; *page_was_mappedp = (unsigned long )dst->private; dst->mapping =NULL ; dst->private =NULL ;
Signature · 1 line
2.39.2