arm64: dts: qcom: msm8976: Add and provide xo clk to rpmcc
PATCH 1/2 arm64: dts: qcom: msm8976: Add and provide xo clk to rpmcc
In order for consumers of RPMCC XO clock to probe successfully their parent needs to be feed with reference clock to obtain proper rate, add fixed xo-board clock and supply it to rpmcc to make consumers happy. Frequency setting is left per board basis just like on other recent trees.
--- arch/arm64/boot/dts/qcom/msm8976.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/qcom/msm8976.dtsi +9 -0
@@ -20,6 +20,13 @@ / { chosen { }; + clocks { + xo_board: xo-board { + compatible = "fixed-clock"; + #clock-cells = <0>; + }; + }; + cpus { #address-cells = <1>; #size-cells = <0>;
@@ -351,6 +358,8 @@ rpm_requests: rpm-requests { rpmcc: clock-controller { compatible = "qcom,rpmcc-msm8976", "qcom,rpmcc"; + clocks = <&xo_board>; + clock-names = "xo"; #clock-cells = <1>; };
Signature · 1 line
2.25.1
PATCH 2/2 arm64: dts: qcom: msm8956-loire: Provide rate for xo_board clock
As xo_board is part of board not soc we define rates per device tree, assign common 19.2Mhz rate to make consumers happy.
--- arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi +4 -0
@@ -280,3 +280,7 @@ &usb_hs_phy { vdda3p3-supply = <&pm8950_l13>; status = "okay"; }; + +&xo_board { + clock-frequency = <19200000>; +};
Signature · 1 line
2.25.1
Re: [PATCH 2/2] arm64: dts: qcom: msm8956-loire: Provide rate for xo_board clock
Quoted 15 lines · Adam Skladowski
As
xo_boardis part of board not soc we define rates per device tree, assign common 19.2Mhz rate to make consumers happy.Fixes ff7f6d34ca07 ("arm64: dts: qcom: Add support for SONY Xperia X/X Compact")Signed-off-by Adam Skladowski <[email protected]>--- arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi +0
-0
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi &usb_hs_phy { · line 285
Quoted 6 lines
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi +3
-0@@ -280,3 +280,7 @@ &usb_hs_phy { vdda3p3-supply = <&pm8950_l13>; status = "okay"; }; + +&xo_board { + clock-frequency = <19200000>;
This doesn't seem to be board-specific. Please move it to msm8976.dtsi.
Quoted 4 lines
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi +1
-1+}; --2.25.1
Signature · 2 lines
With best wishes Dmitry
Dmitry Baryshkov
Reviewed-byRe: [PATCH 2/2] arm64: dts: qcom: msm8956-loire: Provide rate for xo_board clock
Quoted 12 lines · Dmitry Baryshkov
Quoted 10 lines · Adam Skladowski
As
xo_boardis part of board not soc we define rates per device tree, assign common 19.2Mhz rate to make consumers happy.Fixes ff7f6d34ca07 ("arm64: dts: qcom: Add support for SONY Xperia X/X Compact")Signed-off-by Adam Skladowski <[email protected]>--- arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
Quoted 13 lines
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi &usb_hs_phy { · line 285
Quoted 11 lines
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi +3
-0@@ -280,3 +280,7 @@ &usb_hs_phy { vdda3p3-supply = <&pm8950_l13>; status = "okay"; }; + +&xo_board { + clock-frequency = <19200000>;This doesn't seem to be board-specific. Please move it to
msm8976.dtsi.
Adam pointed out the clock frequency is now thought to be a board-specific thing.
Signature · 2 lines
With best wishes Dmitry
Quoted 16 lines · Adam Skladowski
In order for consumers of RPMCC XO clock to probe successfully their parent needs to be feed with reference clock to obtain proper rate, add fixed xo-board clock and supply it to rpmcc to make consumers happy. Frequency setting is left per board basis just like on other recent trees.
Fixes 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs")Signed-off-by Adam Skladowski <[email protected]>--- arch/arm64/boot/dts/qcom/msm8976.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm64/boot/dts/qcom/msm8976.dtsi +0
-0
arch/arm64/boot/dts/qcom/msm8976.dtsi / { · line 26
Quoted 7 lines
arch/arm64/boot/dts/qcom/msm8976.dtsi +4
-0@@ -20,6 +20,13 @@ / { chosen { }; + clocks { + xo_board: xo-board { + compatible = "fixed-clock"; + #clock-cells = <0>;
With the clock-frequency moved here:
Quoted 15 lines
arch/arm64/boot/dts/qcom/msm8976.dtsi +5
-0+ }; + }; + cpus { #address-cells = <1>; #size-cells = <0>;@@ -351,6 +358,8 @@ rpm_requests: rpm-requests { rpmcc: clock-controller { compatible = "qcom,rpmcc-msm8976", "qcom,rpmcc"; + clocks = <&xo_board>; + clock-names = "xo"; #clock-cells = <1>; };
Signature · 2 lines
With best wishes Dmitry
Quoted 8 lines · Adam Skladowski
In order for consumers of RPMCC XO clock to probe successfully their parent needs to be feed with reference clock to obtain proper rate, add fixed xo-board clock and supply it to rpmcc to make consumers happy. Frequency setting is left per board basis just like on other recent trees.
Fixes 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs")Signed-off-by Adam Skladowski <[email protected]>---
So your commit message suggests that this commit does not actually fix the problem, but lays the groundwork for it..
I'd say squashing these two into a single one would make more sense, as if somebody was bisecting something and landed on this one, there would be little hope in getting a boot if what you said holds.
Konrad
Quoted 30 lines
arch/arm64/boot/dts/qcom/msm8976.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm64/boot/dts/qcom/msm8976.dtsi +9
-0@@ -20,6 +20,13 @@ / { chosen { }; + clocks { + xo_board: xo-board { + compatible = "fixed-clock"; + #clock-cells = <0>; + }; + }; + cpus { #address-cells = <1>; #size-cells = <0>;@@ -351,6 +358,8 @@ rpm_requests: rpm-requests { rpmcc: clock-controller { compatible = "qcom,rpmcc-msm8976", "qcom,rpmcc"; + clocks = <&xo_board>; + clock-names = "xo"; #clock-cells = <1>; };
Re: (subset) [PATCH 1/2] arm64: dts: qcom: msm8976: Add and provide xo clk to rpmcc
In reply to Adam SkladowskiQuoted 6 lines · Adam Skladowski
In order for consumers of RPMCC XO clock to probe successfully their parent needs to be feed with reference clock to obtain proper rate, add fixed xo-board clock and supply it to rpmcc to make consumers happy. Frequency setting is left per board basis just like on other recent trees.
Applied, thanks!
[1/2] arm64: dts: qcom: msm8976: Add and provide xo clk to rpmcc
commit: 4a2c9b9e1215c557c17a48e3fabe9b1674c1d608
[2/2] arm64: dts: qcom: msm8956-loire: Provide rate for xo_board clock
commit: 4a2c9b9e1215c557c17a48e3fabe9b1674c1d608Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>