madvise06: Raise the bar for judging failure
PATCH 1/1 madvise06: Raise the bar for judging failure
There is an intermittent failure which we have observed many times whether on rhel or mainline kernel. But we're unable to stable reproduce it:
43 madvise06.c:201: TFAIL: less than 102400 Kb were moved to the swap cache
...
However it does not look like a kernel issue, because SwapCached change is not strictly abiding by the principle of MADV_WILLNEED advice. That means it all depends on the kernel's specific circumstances. The value of the threshold is debatable at least from my point of view, its use 1/4 is not guaranteed 100% safe.
As MADV_WILLNEED is just advice to the kernel, not a guarantee. The kernel may choose to ignore the advice, or may prioritize other memory management tasks over pre-loading the advised pages.
So this patch is aimed at improving the accuracy and clarity of the test results. Specifically, the use of two separate variables to track the results of different comparisons will make it easier to understand what the test is doing.
Additionally, the change to report a test result of "TINFO" instead of "TFAIL" when the swap cache size is less than expected would be intended to indicate that this is an acceptable outcome.
Finally, the change to the second tst_res call is intended to make the test more lenient, as it now passes if either no page faults occur or the swap cache size is larger than expected.
--- testcases/kernel/syscalls/madvise/madvise06.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
testcases/kernel/syscalls/madvise/madvise06.c +7 -7
@@ -164,7 +164,7 @@ static int get_page_fault_num(void)static void test_advice_willneed (void ) { -int loops =100 , res; +int loops =100 , res1, res2;char *target;long swapcached_start, swapcached;int page_fault_num_1, page_fault_num_2;
@@ -197,10 +197,10 @@ static void test_advice_willneed(void) }while (swapcached < swapcached_start +PASS_THRESHOLD_KB && loops >0 );meminfo_diag ("After madvise" ); - res = swapcached > swapcached_start +PASS_THRESHOLD_KB ; -tst_res (res ?TPASS :TFAIL , + res1 = swapcached > swapcached_start +PASS_THRESHOLD_KB ; +tst_res (res1 ?TPASS :TINFO ,"%s than %ld Kb were moved to the swap cache" , - res ?"more" :"less" ,PASS_THRESHOLD_KB ); + res1 ?"more" :"less" ,PASS_THRESHOLD_KB ); loops =100 ;SAFE_FILE_LINES_SCANF ("/proc/meminfo" ,"SwapCached: %ld" , &swapcached_start);
@@ -225,9 +225,9 @@ static void test_advice_willneed(void) page_fault_num_2);meminfo_diag ("After page access" ); - res = page_fault_num_2 - page_fault_num_1; -tst_res (res ==0 ?TPASS :TFAIL , -"%d pages were faulted out of 3 max" , res); + res2 = page_fault_num_2 - page_fault_num_1; +tst_res (((res2 ==0 ) || res1) ?TPASS :TFAIL , +"%d pages were faulted out of 3 max" , res2);SAFE_MUNMAP (target,CHUNK_SZ ); }
Signature · 5 lines
2.38.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hell Li,
Quoted 20 lines · Li Wang
There is an intermittent failure which we have observed many times whether on rhel or mainline kernel. But we're unable to stable reproduce it:
43 madvise06.c:201: TFAIL: less than 102400 Kb were moved to the swap cache
...However it does not look like a kernel issue, because SwapCached change is not strictly abiding by the principle of
MADV_WILLNEEDadvice. That means it all depends on the kernel's specific circumstances. The value of the threshold is debatable at least from my point of view, its use 1/4 is not guaranteed 100% safe.As
MADV_WILLNEEDis just advice to the kernel, not a guarantee. The kernel may choose to ignore the advice, or may prioritize other memory management tasks over pre-loading the advised pages.So this patch is aimed at improving the accuracy and clarity of the test results. Specifically, the use of two separate variables to track the results of different comparisons will make it easier to understand what the test is doing.
Quoted 7 lines
Additionally, the change to report a test result of "TINFO" instead of "TFAIL" when the swap cache size is less than expected would be intended to indicate that this is an acceptable outcome.
Finally, the change to the second
tst_rescall is intended to make the test more lenient, as it now passes if either no page faults occur or the swap cache size is larger than expected.
Why not skip to making them all TINFO?
It's undefined what action will result from MADV_WILLNEED. If it were better for performance *not* to read in pages, then it would be valid for the kernel to ignore it.
Yang Xu added a tag for a perf regression that it could reproduce. However looking at the kernel commit this was first found by stress-ng.
commit 66383800df9cbdbf3b0c34d5a51bf35bcdb72fd2
Author: Matthew Wilcox (Oracle) <[email protected]> Date: Sat Nov 21 22:17:22 2020 -0800
mm: fix madvise WILLNEED performance problem
The calculation of the end page index was incorrect, leading to a regression of 70% when running stress-ng.
With this fix, we instead see a performance improvement of 3%
I found a bug with this test, but it was causing an Oops. It wouldn't matter if the test printed pass or fail.
So I think we are wasting our time by constantly tweaking this test.
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Richard,
Quoted 43 lines · Richard Palethorpe
Hell Li,
Quoted 1 line · Li Wang
There is an intermittent failure which we have observed many times
whether
Quoted 3 lines
on rhel or mainline kernel. But we're unable to stable reproduce it:
43 madvise06.c:201: TFAIL: less than 102400 Kb were moved tothe swap cache
Quoted 3 lines
...However it does not look like a kernel issue, because SwapCached change
is
Quoted 1 line
not strictly abiding by the principle of
MADV_WILLNEEDadvice. Thatmeans it
Quoted 1 line
all depends on the kernel's specific circumstances. The value of the
threshold
Quoted 1 line
is debatable at least from my point of view, its use 1/4 is not
guaranteed
Quoted 3 lines
100% safe.
As
MADV_WILLNEEDis just advice to the kernel, not a guarantee. Thekernel may
Quoted 1 line
choose to ignore the advice, or may prioritize other memory management
tasks
Quoted 3 lines
over pre-loading the advised pages.
So this patch is aimed at improving the accuracy and clarity of the test
results.
Quoted 1 line
Specifically, the use of two separate variables to track the results of
different
Quoted 3 lines
comparisons will make it easier to understand what the test is doing.
Additionally, the change to report a test result of "TINFO" instead of
"TFAIL"
Quoted 1 line
when the swap cache size is less than expected would be intended to
indicate
Quoted 3 lines
that this is an acceptable outcome.
Finally, the change to the second
tst_rescall is intended to make thetest more
Quoted 1 line
lenient, as it now passes if either no page faults occur or the swap
Quoted 9 lines
cache size
Quoted 1 line
is larger than expected.
Why not skip to making them all TINFO?
It's undefined what action will result from
MADV_WILLNEED. If it were better for performance *not* to read in pages, then it would be valid for the kernel to ignore it.
Yes, but I didn't do that because madvise06 test checks free_mem/free_swap size at the beginning, it garantee the system at least with 2 * CHUNK_SZ (800MB + 800MB) memory for the test performing, unless there is something happening parallel otherwise kernel will handle MADV_WILLNEED request correctly for most scenarios.
And we indeed do not see page-faults failure out of expected anymore since commit 00e769e63515e51, so I just combined the two judgments together in this patch. I believe it's enough and also give a leeway to the kernel.
I hope there could be a lenient test for MADV_WILLNEED.
I will decisively take your suggestion once the failure appears again next time.
Quoted 26 lines
Yang Xu added a tag for a perf regression that it could reproduce. However looking at the kernel commit this was first found by stress-ng.
commit
66383800df9cbdbf3b0c34d5a51bf35bcdb72fd2Author: Matthew Wilcox (Oracle) <[email protected]> Date: Sat Nov 21 22:17:22 2020 -0800mm: fix madvise WILLNEED performance problem
The calculation of the end page index was incorrect, leading to a regression of 70% when running stress-ng.
With this fix, we instead see a performance improvement of 3%
I found a bug with this test, but it was causing an Oops. It wouldn't matter if the test printed pass or fail.
So I think we are wasting our time by constantly tweaking this test.
--
Thank you,
Richard.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v2 1/1 madvise06: stop throwing failure when MADV_WILLNEED is ignored
There is an intermittent failure which we have observed many times whether on rhel or mainline kernel. But we're unable to stable reproduce it:
43 madvise06.c:201: TFAIL: less than 102400 Kb were moved to the swap cache
...
However it does not look like a kernel issue, because SwapCached change is not strictly abiding by the principle of MADV_WILLNEED advice. That means it all depends on the kernel's specific circumstances. The value of the threshold is debatable at least from my point of view, its use 1/4 is not guaranteed 100% safe.
As MADV_WILLNEED is just advice to the kernel, not a guarantee. The kernel may choose to ignore the advice, or may prioritize other memory management tasks over pre-loading the advised pages.
This change to report a test result of "TINFO" instead of "TFAIL" when the swap cache size is less than expected would be intended to indicate that this is an acceptable outcome. Same changes apply to the page_fault counting as well.
--- testcases/kernel/syscalls/madvise/madvise06.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/syscalls/madvise/madvise06.c +2 -2
@@ -198,7 +198,7 @@ static void test_advice_willneed(void)meminfo_diag ("After madvise" ); res = swapcached > swapcached_start +PASS_THRESHOLD_KB ; -tst_res (res ?TPASS :TFAIL , +tst_res (res ?TPASS :TINFO ,"%s than %ld Kb were moved to the swap cache" , res ?"more" :"less" ,PASS_THRESHOLD_KB );
@@ -226,7 +226,7 @@ static void test_advice_willneed(void)meminfo_diag ("After page access" ); res = page_fault_num_2 - page_fault_num_1; -tst_res (res ==0 ?TPASS :TFAIL , +tst_res (res ==0 ?TPASS :TINFO ,"%d pages were faulted out of 3 max" , res);SAFE_MUNMAP (target,CHUNK_SZ );
Signature · 5 lines
2.38.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCh v2] madvise06: stop throwing failure when MADV_WILLNEED is ignored
Hi Li,
LGTM.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCh v2] madvise06: stop throwing failure when MADV_WILLNEED is ignored
Hi,
Quoted 5 lines · Petr Vorel
Hi Li,
LGTM.
Acked-by Petr Vorel <[email protected]>
Thank you for your ack, Petr.
I still want Richard gives me a final check.
@Richard, do you agree with pushing it, or other thoughts?
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Richard Palethorpe
Reviewed-byRe: [LTP] [PATCh v2] madvise06: stop throwing failure when MADV_WILLNEED is ignored
Hello,
Quoted 10 lines · Li Wang
Hi,
Quoted 5 lines · Petr Vorel
Hi Li,
LGTM.
Acked-by Petr Vorel <[email protected]>
Quoted 5 lines
Thank you for your ack, Petr.
I still want Richard gives me a final check.
@Richard, do you agree with pushing it, or other thoughts?
I think it needs at least one unconditional tst_res(TPASS, ...) otherwise the library will report TBROK if there is no pass or fail result.
Possibly just tst_res(TPASS, "Nothing bad happend probably") at the end or check for kernel taints.
With that:
Sorry for slow response.
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCh v2] madvise06: stop throwing failure when MADV_WILLNEED is ignored
Quoted 18 lines · Richard Palethorpe
Hello,
Quoted 14 lines · Li Wang
Hi,
Quoted 5 lines · Petr Vorel
Hi Li,
LGTM.
Acked-by Petr Vorel <[email protected]>Thank you for your ack, Petr.
I still want Richard gives me a final check.
Quoted 9 lines
Quoted 1 line
@Richard, do you agree with pushing it, or other thoughts?
I think it needs at least one unconditional
tst_res(TPASS, ...)otherwise the library will report TBROK if there is no pass or fail result.Possibly just
tst_res(TPASS, "Nothing bad happend probably")at the end or check for kernel taints.
Good point!!!
I added the kernel taint check and pushed. Thanks~
Quoted 11 lines
With that:
Reviewed-by Richard Palethorpe <[email protected]>Sorry for slow response.
--
Thank you,
Richard.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp