Skip to contentSkip to conversation

linux: inherit pkgconfig in kernel.bbclass

PATCH In review [email protected] 2 participants 2 messages Mar 4, 2023 – Mar 6, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux: inherit pkgconfig in kernel.bbclass

From: Ming Liu <[email protected]>

pkgconfig is being required to find dependencies for building kernel native tools, move "inherit pkgconfig" to kernel.bbclass so BSP kernel recipes can also benefit from it.

---
 meta/classes-recipe/kernel.bbclass           | 2 +-
 meta/recipes-kernel/linux/linux-yocto-dev.bb | 2 --
 meta/recipes-kernel/linux/linux-yocto.inc    | 1 -
 3 files changed, 1 insertion(+), 4 deletions(-)
meta/classes-recipe/kernel.bbclass +1 -1
index 3f9c6c00e6..92090ac14e 100644
@@ -660,7 +660,7 @@ do_savedefconfig() {
 do_savedefconfig[nostamp] = "1"
 addtask savedefconfig after do_configure
 
-inherit cml1
+inherit cml1 pkgconfig
 
 # Need LD, HOSTLDFLAGS and more for config operations
 KCONFIG_CONFIG_COMMAND:append = " ${EXTRA_OEMAKE}"
meta/recipes-kernel/linux/linux-yocto-dev.bb +0 -2
index 9ef5b80a37..8039a52324 100644
@@ -10,8 +10,6 @@
 
 inherit kernel
 require recipes-kernel/linux/linux-yocto.inc
-# for ncurses tests
-inherit pkgconfig
 
 # provide this .inc to set specific revisions
 include recipes-kernel/linux/linux-yocto-dev-revisions.inc
meta/recipes-kernel/linux/linux-yocto.inc +0 -1
index 93eef9e946..934591ff1c 100644
@@ -47,7 +47,6 @@ LINUX_VERSION_EXTENSION ??= "-yocto-${LINUX_KERNEL_TYPE}"
 # Pick up shared functions
 inherit kernel
 inherit kernel-yocto
-inherit pkgconfig
 
 B = "${WORKDIR}/linux-${PACKAGE_ARCH}-${LINUX_KERNEL_TYPE}-build"
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · Ming Liu

From: Ming Liu <[email protected]>

pkgconfig is being required to find dependencies for building kernel native tools, move "inherit pkgconfig" to kernel.bbclass so BSP kernel recipes can also benefit from it.

Reminder: copy me on linux-yocto changes!

This is fine with me. When I first introduced this, it wasn't universally needed for all kernel versions, so it landed in linux-yocto, where we knew the versions.

I'm betting that there are a lot of other kernel recipes with this same inherit, and as long as they are all good with double inherits .. nothing should break.

Bruce

Quoted 58 lines
---
 meta/classes-recipe/kernel.bbclass           | 2 +-
 meta/recipes-kernel/linux/linux-yocto-dev.bb | 2 --
 meta/recipes-kernel/linux/linux-yocto.inc    | 1 -
 3 files changed, 1 insertion(+), 4 deletions(-)
meta/classes-recipe/kernel.bbclass +1 -1
index 3f9c6c00e6..92090ac14e 100644
@@ -660,7 +660,7 @@ do_savedefconfig() {
 do_savedefconfig[nostamp] = "1"
 addtask savedefconfig after do_configure
 
-inherit cml1
+inherit cml1 pkgconfig
 
 # Need LD, HOSTLDFLAGS and more for config operations
 KCONFIG_CONFIG_COMMAND:append = " ${EXTRA_OEMAKE}"
meta/recipes-kernel/linux/linux-yocto-dev.bb +0 -2
index 9ef5b80a37..8039a52324 100644
@@ -10,8 +10,6 @@
 
 inherit kernel
 require recipes-kernel/linux/linux-yocto.inc
-# for ncurses tests
-inherit pkgconfig
 
 # provide this .inc to set specific revisions
 include recipes-kernel/linux/linux-yocto-dev-revisions.inc
meta/recipes-kernel/linux/linux-yocto.inc +0 -2
index 93eef9e946..934591ff1c 100644
@@ -47,7 +47,6 @@ LINUX_VERSION_EXTENSION ??= "-yocto-${LINUX_KERNEL_TYPE}"
 # Pick up shared functions
 inherit kernel
 inherit kernel-yocto
-inherit pkgconfig
 
 B = "${WORKDIR}/linux-${PACKAGE_ARCH}-${LINUX_KERNEL_TYPE}-build"
 
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#178027): https://lists.openembedded.org/g/openembedded-core/message/178027
Mute This Topic: https://lists.openembedded.org/mt/97386391/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II