Skip to contentSkip to conversation

RFC extend kms_psr2_sf for panel replay

PATCH In review Kunal Joshi 3 participants 5 messages Mar 6, 2023 – Jun 20, 2023 Library code

lore
Share & tools
lore
#0 lore raw

cover RFC extend kms_psr2_sf for panel replay

Extended kms_psr2_sf test to run on sink which supports panel replay. All debugfs infois assumed and driver may not expose it as currently referred.

Kunal Joshi (2):
RFC lib/igt_psr Added library functions for panel replay RFC tests/kms_psr2_sf Extended test to validate panel replay

 lib/igt_psr.c            |  62 +++++++++++++++++-
 lib/igt_psr.h            |   5 ++
 tests/i915/kms_psr2_sf.c | 137 ++++++++++++++++++++++++++++++---------
 3 files changed, 171 insertions(+), 33 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/2 RFC lib/igt_psr Added library functions for panel replay

Added helper functions for retieving panel replay
information from debugfs

---
 lib/igt_psr.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 lib/igt_psr.h |  5 +++++
 2 files changed, 66 insertions(+), 1 deletion(-)
lib/igt_psr.c +61 -1
index a2d88031..ec39b480 100644
@@ -37,6 +37,16 @@ bool psr_disabled_check(int debugfs_fd)
 	return strstr(buf, "PSR mode: disabled\n");
 }
 
+bool pr_selective_fetch_check(int debugfs_fd)
+{
+	char buf[PSR_STATUS_MAX_LEN];
+
+	igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
+				sizeof(buf));
+
+	return strstr(buf, "PR selective fetch: enabled");
+}
+
 bool psr2_selective_fetch_check(int debugfs_fd)
 {
 	char buf[PSR_STATUS_MAX_LEN];
@@ -47,6 +57,27 @@ bool psr2_selective_fetch_check(int debugfs_fd)
 	return strstr(buf, "PSR2 selective fetch: enabled");
 }
 
+static bool pr_active_check(int debugfs_fd, enum psr_mode mode)
+{
+	char buf[PSR_STATUS_MAX_LEN];
+	/*
+	 * Fix PR_STATE once confimred what state source will be in
+	 * when PR is active
+	 */
+	const char *state = "PR_STATE";
+	int ret;
+
+	ret = igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status",
+				     buf, sizeof(buf));
+	if (ret < 0) {
+		igt_info("Could not read i915_edp_psr_status: %s\n",
+			 strerror(-ret));
+		return false;
+	}
+
+	return strstr(buf, state);
+}
+
 static bool psr_active_check(int debugfs_fd, enum psr_mode mode)
 {
 	char buf[PSR_STATUS_MAX_LEN];
@@ -66,6 +97,11 @@ static bool psr_active_check(int debugfs_fd, enum psr_mode mode)
 	return strstr(buf, state);
 }
 
+bool pr_wait_entry(int debugfs_fd, enum psr_mode mode)
+{
+	return igt_wait(pr_active_check(debugfs_fd, mode), 500, 20);
+}
+
 /*
  * For PSR1, we wait until PSR is active. We wait until DEEP_SLEEP for PSR2.
  */
@@ -162,6 +198,12 @@ static bool psr_set(int device, int debugfs_fd, int mode)
 		case PSR_MODE_2_SEL_FETCH:
 			debug_val = "0x4";
 			break;
+		case PR_MODE_1:
+			debug_val = "0x5";
+			break;
+		case PR_MODE_1_SEL_FETCH:
+			debug_val = "0x6";
+			break;
 		default:
 			/* Disables PSR */
 			debug_val = "0x1";
@@ -192,6 +234,20 @@ bool psr_disable(int device, int debugfs_fd)
 	return psr_set(device, debugfs_fd, -1);
 }
 
+bool pr_sink_support(int device, int debugfs_fd, enum psr_mode mode)
+{
+	char buf[PSR_STATUS_MAX_LEN];
+	int ret;
+
+	ret = igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
+				      sizeof(buf));
+	if (ret < 1)
+		return false;
+	else
+		return strstr(buf, "Sink support: yes [0x05]") ||
+		       strstr(buf, "Sink support: yes [0x06]");
+}
+
 bool psr_sink_support(int device, int debugfs_fd, enum psr_mode mode)
 {
 	char buf[PSR_STATUS_MAX_LEN];
@@ -350,7 +406,11 @@ enum psr_mode psr_get_mode(int debugfs_fd)
 		return PSR_DISABLED;
 	}
 
-	if (strstr(buf, "PSR2 selective fetch: enabled"))
+	if (strstr(buf, "PR selective fetch: enabled"))
+		return PR_MODE_1_SEL_FETCH;
+	else if (strstr(buf, "PR: enabled"))
+		return PR_MODE_1;
+	else if (strstr(buf, "PSR2 selective fetch: enabled"))
 		return PSR_MODE_2_SEL_FETCH;
 	else if (strstr(buf, "PSR2 enabled"))
 		return PSR_MODE_2;
lib/igt_psr.h +5 -0
index 12ffc9d6..cbcef796 100644
@@ -34,17 +34,22 @@ enum psr_mode {
 	PSR_MODE_1,
 	PSR_MODE_2,
 	PSR_MODE_2_SEL_FETCH,
+	PR_MODE_1,
+	PR_MODE_1_SEL_FETCH,
 	PSR_DISABLED,
 };
 
 bool psr_disabled_check(int debugfs_fd);
+bool pr_selective_fetch_check(int debugfs_fd);
 bool psr2_selective_fetch_check(int debugfs_fd);
+bool pr_wait_entry(int debugfs_fd, enum psr_mode mode);
 bool psr_wait_entry(int debugfs_fd, enum psr_mode mode);
 bool psr_wait_update(int debugfs_fd, enum psr_mode mode);
 bool psr_long_wait_update(int debugfs_fd, enum psr_mode mode);
 bool psr_enable(int device, int debugfs_fd, enum psr_mode);
 bool psr_disable(int device, int debugfs_fd);
 bool psr_sink_support(int device, int debugfs_fd, enum psr_mode mode);
+bool pr_sink_support(int device, int debugfs_fd, enum psr_mode mode);
 bool psr2_wait_su(int debugfs_fd, uint16_t *num_su_blocks);
 void psr_print_debugfs(int debugfs_fd);
 enum psr_mode psr_get_mode(int debugfs_fd);
Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/2 RFC tests/kms_psr2_sf Extended test to validate panel replay

In reply to Kunal Joshi

Extended kms_psr2_sf test to run on sink which supports panel replay. All debugfs infois assumed and driver may not expose it as currently referred.

---
 tests/i915/kms_psr2_sf.c | 137 ++++++++++++++++++++++++++++++---------
 1 file changed, 105 insertions(+), 32 deletions(-)
tests/i915/kms_psr2_sf.c +105 -32
index 2d761d31..eae6d007 100644
@@ -63,6 +63,12 @@ enum plane_move_postion {
 	POS_RIGHT,
 };
 
+enum test_mode {
+	PSR2,
+	PR,
+	END,
+};
+
 typedef struct {
 	int drm_fd;
 	int debugfs_fd;
@@ -86,6 +92,7 @@ typedef struct {
 	cairo_t *cr;
 	uint32_t screen_changes;
 	int cur_x, cur_y;
+	int test_mode;
 	enum pipe pipe;
 	enum {
 		FEATURE_NONE  = 0,
@@ -600,10 +607,23 @@ static void damaged_plane_move(data_t *data)
 
 	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
-	igt_assert(psr_wait_entry(data->debugfs_fd, PSR_MODE_2));
+	if (data->test_mode == PSR2)
+		igt_assert(psr_wait_entry(data->debugfs_fd, PSR_MODE_2));
+	else
+		igt_assert(pr_wait_entry(data->debugfs_fd, PR_MODE_1));
+
+	/*
+	 * Add checks if SU region was transmitted via early transport
+	 * if in PR mode
+	 *
+	 * When in PR active source can go to DC6/DC6v
+	 * panel goes to PM_State 3/PM_State 1b with LCT1 register DPCD 0x202
+	 * Add a check for above
+	 */
 
 	expected_output(data);
 }
+
 static void get_target_coords(data_t *data, int *x, int *y)
 {
 	int target_x, target_y, exceed_x, exceed_y;
@@ -700,7 +720,10 @@ static void plane_move_continuous(data_t *data)
 {
 	int target_x, target_y;
 
-	igt_assert(psr_wait_entry(data->debugfs_fd, PSR_MODE_2));
+	if (data->test_mode == PSR2)
+		igt_assert(psr_wait_entry(data->debugfs_fd, PSR_MODE_2));
+	else
+		igt_assert(pr_wait_entry(data->debugfs_fd, PR_MODE_1));
 
 	get_target_coords(data, &target_x, &target_y);
 
@@ -718,6 +741,14 @@ static void plane_move_continuous(data_t *data)
 		igt_plane_set_position(data->test_plane, data->cur_x, data->cur_y);
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
 	}
+	/*
+	 * Add checks if SU region was transmitted via early transport
+	 * if in PR mode
+	 *
+	 * When in PR active source can go to DC6/DC6v
+	 * panel goes to PM_State 3/PM_State 1b with LCT1 register DPCD 0x202
+	 * Add a check for above
+	 */
 
 	expected_output(data);
 }
@@ -777,7 +808,19 @@ static void damaged_plane_update(data_t *data)
 	igt_plane_set_position(data->test_plane, 0, 0);
 	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
-	igt_assert(psr_wait_entry(data->debugfs_fd, PSR_MODE_2));
+	if (data->test_mode == PSR2)
+		igt_assert(psr_wait_entry(data->debugfs_fd, PSR_MODE_2));
+	else
+		igt_assert(pr_wait_entry(data->debugfs_fd, PR_MODE_1));
+
+	/*
+	 * Add checks if SU region was transmitted via early transport
+	 * if in PR mode
+	 *
+	 * When in PR active source can go to DC6/DC6v
+	 * panel goes to PM_State 3/PM_State 1b with LCT1 register DPCD 0x202
+	 * Add a check for above
+	 */
 
 	expected_output(data);
 }
@@ -786,7 +829,11 @@ static void run(data_t *data)
 {
 	int i;
 
-	igt_assert(psr_wait_entry(data->debugfs_fd, PSR_MODE_2));
+	if (data->test_mode == PSR2)
+		igt_assert(psr_wait_entry(data->debugfs_fd, PSR_MODE_2));
+	else
+		igt_assert(pr_wait_entry(data->debugfs_fd, PR_MODE_1));
+
 
 	data->screen_changes = 0;
 
@@ -859,14 +906,21 @@ static void cleanup(data_t *data)
 	igt_remove_fb(data->drm_fd, &data->fb_test);
 }
 
-static int check_psr2_support(data_t *data)
+static int check_psr2_or_pr_support(data_t *data, const char *mode_str)
 {
 	int status;
 
 	prepare(data);
-	status = psr_wait_entry(data->debugfs_fd, PSR_MODE_2);
-	cleanup(data);
+	/*
+	 * Add PR wait check once confirmed what state
+	 * it goes to when PR active
+	 */
+	if (strcmp(mode_str, "psr2") == 0)
+		status = psr_wait_entry(data->debugfs_fd, PSR_MODE_2);
+	if (strcmp(mode_str, "pr") == 0)
+		status = pr_wait_entry(data->debugfs_fd, PR_MODE_1);
 
+	cleanup(data);
 	return status;
 }
 
@@ -878,6 +932,8 @@ igt_main
 	int pipes[IGT_MAX_PIPES * IGT_MAX_PIPES];
 	int n_pipes = 0;
 	int coexist_features[IGT_MAX_PIPES * IGT_MAX_PIPES];
+	bool psr_support, pr_support;
+	const char *mode_str;
 
 	igt_fixture {
 		drmModeResPtr res;
@@ -886,16 +942,36 @@ igt_main
 		data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
 		kmstest_set_vt_graphics_mode();
 
-		igt_require_f(psr_sink_support(data.drm_fd,
-					       data.debugfs_fd, PSR_MODE_2),
-			      "Sink does not support PSR2\n");
+		/*
+		 * Both PSR and PR are mutually exclusive
+		 * Hence any of the one will be enabled by driver
+		 */
+		psr_support = psr_sink_support(data.drm_fd, data.debugfs_fd, PSR_MODE_2);
+		pr_support = pr_sink_support(data.drm_fd, data.debugfs_fd, PR_MODE_1);
+		igt_require_f(psr_support || pr_support,
+			      "Sink does not support PSR2/PR\n");
 
 		display_init(&data);
 
-		/* Test if PSR2 can be enabled */
-		igt_require_f(psr_enable(data.drm_fd,
-					 data.debugfs_fd, PSR_MODE_2_SEL_FETCH),
-			      "Error enabling PSR2\n");
+		if (psr_support) {
+			/* Test if PSR2 can be enabled */
+			igt_require_f(psr_enable(data.drm_fd,
+				      data.debugfs_fd, PSR_MODE_2),
+				      "Error enabling PSR2\n");
+
+			igt_require_f(psr2_selective_fetch_check(data.debugfs_fd),
+				      "PSR2 selective fetch not enabled\n");
+			data.test_mode = PSR2;
+			mode_str = "psr2";
+		} else {
+			igt_require_f(psr_enable(data.drm_fd,
+				      data.debugfs_fd, PR_MODE_1),
+				      "Error enabling PR\n");
+			igt_require_f(pr_selective_fetch_check(data.debugfs_fd),
+				      "PR selective fetch not enabled\n");
+			data.test_mode = PR;
+			mode_str = "pr";
+		}
 
 		data.damage_area_count = MAX_DAMAGE_AREAS;
 		data.op = PLANE_UPDATE;
@@ -909,12 +985,9 @@ igt_main
 		igt_info("Big framebuffer size %dx%d\n",
 			 data.big_fb_width, data.big_fb_height);
 
-		igt_require_f(psr2_selective_fetch_check(data.debugfs_fd),
-			      "PSR2 selective fetch not enabled\n");
-
 		for_each_pipe_with_valid_output(&data.display, data.pipe, data.output) {
 			coexist_features[n_pipes] = 0;
-			if (check_psr2_support(&data)) {
+			if (check_psr2_or_pr_support(&data, mode_str)) {
 				pipes[n_pipes] = data.pipe;
 				outputs[n_pipes] = data.output;
 
@@ -928,12 +1001,12 @@ igt_main
 
 	/* Verify primary plane selective fetch */
 	igt_describe("Test that selective fetch works on primary plane");
-	igt_subtest_with_dynamic_f("primary-%s-sf-dmg-area", op_str(data.op)) {
+	igt_subtest_with_dynamic_f("primary-sf-dmg-area-%s", op_str(data.op)) {
 		for (i = 0; i < n_pipes; i++) {
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -959,7 +1032,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -985,7 +1058,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -1011,7 +1084,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -1033,7 +1106,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -1055,7 +1128,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -1077,7 +1150,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -1101,7 +1174,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -1126,7 +1199,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 				data.pipe = pipes[i];
@@ -1148,7 +1221,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -1170,7 +1243,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -1194,7 +1267,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
@@ -1224,7 +1297,7 @@ igt_main
 			for (j = FEATURE_NONE; j < FEATURE_COUNT; j++) {
 				if (j != FEATURE_NONE && !(coexist_features[i] & j))
 					continue;
-				igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(pipes[i]),
+				igt_dynamic_f("%s-pipe-%s-%s%s", mode_str, kmstest_pipe_name(pipes[i]),
 					      igt_output_name(outputs[i]),
 					      coexist_feature_str(j)) {
 					data.pipe = pipes[i];
Signature · 1 line
2.25.1
#3 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for RFC extend kms_psr2_sf for panel replay

In reply to Kunal Joshi
== Series Details ==

== Series Details ==

Series: RFC extend kms_psr2_sf for panel replay
URL : https://patchwork.freedesktop.org/series/114719/
State : failure

== Summary ==

CI Bug Log - changes from IGT_7181 -> IGTPW_8562
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_8562 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_8562, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/index.html

Participating hosts (35 -> 34)
------------------------------

Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8562:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@uncore:
- bat-adln-1: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7181/bat-adln-1/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/bat-adln-1/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8562 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@gt_lrc:
- bat-rplp-1: [PASS][3] -> [INCOMPLETE][4] ([i915#4983] / [i915#7609] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7181/bat-rplp-1/igt@i915_selftest@live@gt_lrc.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/bat-rplp-1/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][5] -> [ABORT][6] ([i915#4983])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7181/bat-rpls-1/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][7] ([i915#6997] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-2: NOTRUN -> [SKIP][8] ([i915#7828])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/bat-rpls-2/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [SKIP][9] ([fdo#109271]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/fi-bsw-nick/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][10] ([i915#5354]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/bat-dg2-11/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-2: NOTRUN -> [SKIP][11] ([i915#1845])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/bat-rpls-2/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [ABORT][12] ([i915#7911] / [i915#7913]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7181/fi-bsw-nick/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/fi-bsw-nick/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- bat-rpls-2: [ABORT][14] ([i915#7694] / [i915#7913] / [i915#7981]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7181/bat-rpls-2/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/bat-rpls-2/igt@i915_selftest@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7694]: https://gitlab.freedesktop.org/drm/intel/issues/7694
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7181 -> IGTPW_8562

CI-20190529: 20190529
CI_DRM_12815: a3154f6f61dddad0467a59166ce76b13a7eaffef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8562: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/index.html
IGT_7181: f44a24fe9f1948a117daf3162db53df7820f9923 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

+igt@kms_psr2_sf@primary-sf-dmg-area-plane-update
-igt@kms_psr2_sf@primary-plane-update-sf-dmg-area

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8562/index.html

#4 lore raw
In reply to Kunal Joshi
Quoted 8 lines · Kunal Joshi

Extended kms_psr2_sf test to run on sink which supports panel replay. All debugfs infois assumed and driver may not expose it as currently referred.

Kunal Joshi (2):
  RFC lib/igt_psr Added library functions for panel replay RFC tests/kms_psr2_sf Extended test to validate panel replay

Quoted 6 lines

 lib/igt_psr.c            |  62 +++++++++++++++++- lib/igt_psr.h            |   5 ++ tests/i915/kms_psr2_sf.c | 137 ++++++++++++++++++++++++++++++------- --

 3 files changed, 171 insertions(+), 33 deletions(-)

Hello Kunal,

How I currently see this will be:

PSR mode: PR enabled
Source PSR ctl: enabled [0xXXXXXXXX] Source PSR status: DEEP_SLEEP [0xXXXXXXXX] Busy frontbuffer bits: 0x00000000 Performance counter: 0
Frame: PSR2 SU blocks:
0 0
1 0
2 0
3 0
4 0
5 0
6 0
7 0
PSR2 selective fetch: enabled

I.e. PR mode w/ and w/o selective update/fetch.

BR,

Jouni Högander