dt-bindings: power: supply: bq256xx: Add ts-ignore property

PATCH In review Hermes Zhang 2 participants 4 messages Mar 9, 2023 – Mar 10, 2023

Subsystems (2)

Device tree bindings Power supply

lore

Share & tools

lore

Hermes Zhang

author

2023-03-09 02:40 UTC #0 lore raw

PATCH 1/1 dt-bindings: power: supply: bq256xx: Add ts-ignore property

Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag in chip. Ignore TS pin will allow user to control the charging parameters instead of the default JEITA profile in chip.

Signed-off-by Hermes Zhang <[email protected]>

---
 Documentation/devicetree/bindings/power/supply/bq256xx.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Documentation/devicetree/bindings/power/supply/bq256xx.yaml +6 -0

index 82f382a7ffb3..74fd48f4bec5 100644
@@ -68,6 +68,12 @@ properties:
       Interrupt sends an active low, 256 μs pulse to host to report the charger
       device status and faults.
 
+  ts-ignore:
+    type: boolean
+    description: |
+      If this property is set, the TS_IGNORE flag will be set to 1 which means
+      will not apply JEITA profile during the charging.
+
 required:
   - compatible
   - reg

Signature · 1 line

2.30.2

Hermes Zhang

author

2023-03-10 03:49 UTC #2 lore raw

Quoted 5 lines · Krzysztof Kozlowski

Quoted 3 lines · Hermes Zhang
Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag in chip. Ignore TS pin will allow user to control the charging parameters instead of the default JEITA profile in chip.
You miss users of it.

Could you give some more info about what I missed?

Quoted 8 lines

Documentation/devicetree/bindings/power/supply/bq256xx.yaml +1 -0
@@ -68,6 +68,12 @@ properties:
        Interrupt sends an active low, 256 μs pulse to host to report the charger
        device status and faults.
 
+  ts-ignore:
Missing vendor prefix... is this generic property? ts-ignore is very cryptic. You should describe here rather desired system characteristic. Why anyone would need to use it per-board level?

OK, I will fix it. Will "ti,ignore-ts-pin" be better? Yes, it's a generic. To disable the TS pin, actually we also could do it from HW, but from software, it could be more flexble. But if HW already disable it, then you don't need to do it again from dts.

BTW, I find I may miss some information here: the ts-ignore feature is not support by all the chips list here, I will add some comment for which chip support it.

Best Regards,

Hermes

Krzysztof Kozlowski

2023-03-10 08:07 UTC #3 lore raw

Quoted 7 lines · Hermes Zhang

Quoted 5 lines · Krzysztof Kozlowski
Quoted 3 lines · Hermes Zhang
Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag in chip. Ignore TS pin will allow user to control the charging parameters instead of the default JEITA profile in chip.
You miss users of it.
Could you give some more info about what I missed?

Users. DTS and driver code.

Quoted 10 lines

Quoted 8 lines
Documentation/devicetree/bindings/power/supply/bq256xx.yaml +1 -0
@@ -68,6 +68,12 @@ properties:
        Interrupt sends an active low, 256 μs pulse to host to report the charger
        device status and faults.
 
+  ts-ignore:
Missing vendor prefix... is this generic property? ts-ignore is very cryptic. You should describe here rather desired system characteristic. Why anyone would need to use it per-board level?
OK, I will fix it. Will "ti,ignore-ts-pin" be better?

No, because does not describe system characteristic. Read again my last two sentences.

Quoted 4 lines

Yes, it's a
generic. To disable the TS pin, actually we also could do it from HW, but from software, it could be more flexble. But if HW already disable it, then you don't need to do it again from dts.

If this is configurable from HW, why this should be in DT?

Best regards,
Krzysztof