bnxt: avoid overflow in bnxt_get_nvram_directory()
PATCH 1/1 bnxt: avoid overflow in bnxt_get_nvram_directory()
The value of an arithmetic expression is subject
of possible overflow due to a failure to cast operands to a larger data type before performing arithmetic. Used macro for multiplication instead operator for avoiding overflow.
Found by Security Code and Linux Verification
Center (linuxtesting.org) with SVACE.
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +1 -1
@@ -2862,7 +2862,7 @@ static int bnxt_get_nvram_directory(struct net_device *dev, u32 len, u8 *data)if (rc)return rc; - buflen = dir_entries * entry_length; + buflen =mul_u32_u32 (dir_entries, entry_length); buf =hwrm_req_dma_slice (bp, req, buflen, &dma_handle);if (!buf) {hwrm_req_drop (bp, req);
Signature · 1 line
2.37.2
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Thu, 9 Mar 2023 20:43:47 +0300 you wrote:
The value of an arithmetic expression is subject
of possible overflow due to a failure to cast operands to a larger data type before performing arithmetic. Used macro for multiplication instead operator for avoiding overflow.Found by Security Code and Linux Verification
Center (linuxtesting.org) with SVACE.[...]
Here is the summary with links:
- [next-next] bnxt: avoid overflow in bnxt_get_nvram_directory()
https://git.kernel.org/netdev/net-next/c/7c6dddc239ab
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html