Skip to contentSkip to conversation

clk: microchip: Use of_property_read_bool() for boolean properties

PATCH Applied Rob Herring 2 participants 2 messages Mar 10, 2023 – Mar 14, 2023 Common clk

lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 clk: microchip: Use of_property_read_bool() for boolean properties

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().

Signed-off-by Rob Herring <[email protected]>
---
 drivers/clk/microchip/clk-pic32mzda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/microchip/clk-pic32mzda.c +1 -1
index b72c76f9ecd1..eabfc4931fe9 100644
@@ -184,7 +184,7 @@ static int pic32mzda_clk_probe(struct platform_device *pdev)
 	clks[UPLLCLK] = clk_register_fixed_rate(&pdev->dev, "usbphy_clk", NULL,
 						0, 24000000);
 	/* fixed rate (optional) clock */
-	if (of_find_property(np, "microchip,pic32mzda-sosc", NULL)) {
+	if (of_property_read_bool(np, "microchip,pic32mzda-sosc")) {
 		pr_info("pic32-clk: dt requests SOSC.\n");
 		clks[SOSCCLK] = pic32_sosc_clk_register(&sosc_clk, core);
 	}
Signature · 1 line
2.39.2
Applied
#1 lore raw
Quoted 8 lines · Rob Herring

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().

Signed-off-by Rob Herring <[email protected]>

Applied to at91/clk-microchip, thanks!