dmaengine: Use of_property_present() for testing DT property presence
PATCH 1/1 dmaengine: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.
--- drivers/dma/of-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/of-dma.c +1 -1
@@ -264,7 +264,7 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np, }/* Silently fail if there is not even the "dmas" property */ -if (!of_find_property (np,"dmas" ,NULL )) +if (!of_property_present (np,"dmas" ))return ERR_PTR (-ENODEV ); count =of_property_count_strings (np,"dma-names" );
Signature · 1 line
2.39.2
Quoted 6 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added
of_property_present()helper when we just want to test for presence of a property and nothing more.
Applied, thanks
Signature · 1 line
~Vinod