irqchip: Use of_property_read_bool() for boolean properties
PATCH 1/1 irqchip: Use of_property_read_bool() for boolean properties
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().
--- drivers/irqchip/irq-csky-apb-intc.c | 2 +- drivers/irqchip/irq-gic-v2m.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-csky-apb-intc.c +1 -1
@@ -68,7 +68,7 @@ static void __init ck_set_gc(struct device_node *node, void __iomem *reg_base, gc->chip_types[0 ].chip.irq_mask = irq_gc_mask_clr_bit; gc->chip_types[0 ].chip.irq_unmask = irq_gc_mask_set_bit; -if (of_find_property (node,"csky,support-pulse-signal" ,NULL )) +if (of_property_read_bool (node,"csky,support-pulse-signal" )) gc->chip_types[0 ].chip.irq_unmask = irq_ck_mask_set_bit; }
drivers/irqchip/irq-gic-v2m.c +1 -1
@@ -421,7 +421,7 @@ static int __init gicv2m_of_init(struct fwnode_handle *parent_handle,u32 spi_start =0 , nr_spis =0 ;struct resource res; -if (!of_find_property (child,"msi-controller" ,NULL )) +if (!of_property_read_bool (child,"msi-controller" ))continue ; ret =of_address_to_resource (child,0 , &res);
Signature · 1 line
2.39.2
Quoted 41 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to
of_property_read_bool().Signed-off-by Rob Herring <[email protected]>--- drivers/irqchip/irq-csky-apb-intc.c | 2 +- drivers/irqchip/irq-gic-v2m.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/irqchip/irq-csky-apb-intc.c +1
-1@@ -68,7 +68,7 @@ static void __init ck_set_gc(struct device_node *node, void __iomem *reg_base, gc->chip_types[0 ].chip.irq_mask = irq_gc_mask_clr_bit; gc->chip_types[0 ].chip.irq_unmask = irq_gc_mask_set_bit; -if (of_find_property (node,"csky,support-pulse-signal" ,NULL )) +if (of_property_read_bool (node,"csky,support-pulse-signal" )) gc->chip_types[0 ].chip.irq_unmask = irq_ck_mask_set_bit; }drivers/irqchip/irq-gic-v2m.c +1
-2@@ -421,7 +421,7 @@ static int __init gicv2m_of_init(struct fwnode_handle *parent_handle,u32 spi_start =0 , nr_spis =0 ;struct resource res; -if (!of_find_property (child,"msi-controller" ,NULL )) +if (!of_property_read_bool (child,"msi-controller" ))continue ; ret =of_address_to_resource (child,0 , &res); --2.39.2
Signature · 2 lines
Best Regards Guo Ren
The following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 9dfc77917e3b82dc7f93d62cebf1ebb885e9cc6a Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/9dfc77917e3b82dc7f93d62cebf1ebb885e9cc6a Author: Rob Herring <[email protected]> AuthorDate: Fri, 10 Mar 2023 08:47:10 -06:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Sat, 08 Apr 2023 11:07:49 +01:00
irqchip: Use of_property_read_bool() for boolean properties
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().
--- drivers/irqchip/irq-csky-apb-intc.c | 2 +- drivers/irqchip/irq-gic-v2m.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-csky-apb-intc.c +1 -1
@@ -68,7 +68,7 @@ static void __init ck_set_gc(struct device_node *node, void __iomem *reg_base, gc->chip_types[0 ].chip.irq_mask = irq_gc_mask_clr_bit; gc->chip_types[0 ].chip.irq_unmask = irq_gc_mask_set_bit; -if (of_find_property (node,"csky,support-pulse-signal" ,NULL )) +if (of_property_read_bool (node,"csky,support-pulse-signal" )) gc->chip_types[0 ].chip.irq_unmask = irq_ck_mask_set_bit; }
drivers/irqchip/irq-gic-v2m.c +1 -1
@@ -421,7 +421,7 @@ static int __init gicv2m_of_init(struct fwnode_handle *parent_handle,u32 spi_start =0 , nr_spis =0 ;struct resource res; -if (!of_find_property (child,"msi-controller" ,NULL )) +if (!of_property_read_bool (child,"msi-controller" ))continue ; ret =of_address_to_resource (child,0 , &res);