Skip to contentSkip to conversation

memory: atmel-ebi: Use of_property_present() for testing DT property presence

PATCH Applied Rob Herring 2 participants 2 messages Mar 10, 2023 – Mar 13, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memory: atmel-ebi: Use of_property_present() for testing DT property presence

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.

---
 drivers/memory/atmel-ebi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/memory/atmel-ebi.c +1 -1
index e749dcb3ddea..635966d705cb 100644
@@ -598,7 +598,7 @@ static int atmel_ebi_probe(struct platform_device *pdev)
 	reg_cells += val;
 
 	for_each_available_child_of_node(np, child) {
-		if (!of_find_property(child, "reg", NULL))
+		if (!of_property_present(child, "reg"))
 			continue;
 
 		ret = atmel_ebi_dev_setup(ebi, child, reg_cells);
Signature · 1 line
2.39.2
#1 lore raw
Quoted 8 lines · Rob Herring

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.

[...]

Applied, thanks!

[1/1] memory: atmel-ebi: Use of_property_present() for testing DT property presence

      https://git.kernel.org/krzk/linux-mem-ctrl/c/538c7b5b5d8b5364454494e5fe4125b0b47195f1

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>