PM / devfreq: exynos: Use of_property_present() for testing DT property presence
PATCH 1/1 PM / devfreq: exynos: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.
--- drivers/devfreq/exynos-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/devfreq/exynos-bus.c +1 -1
@@ -432,7 +432,7 @@ static int exynos_bus_probe(struct platform_device *pdev) goto err;/* Create child platform device for the interconnect provider */ -if (of_get_property (dev->of_node,"#interconnect-cells" ,NULL )) { +if (of_property_present (dev->of_node,"#interconnect-cells" )) { bus->icc_pdev =platform_device_register_data ( dev,"exynos-generic-icc" ,PLATFORM_DEVID_AUTO ,NULL ,0 );
Signature · 7 lines
2.39.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Chanwoo Choi
AppliedQuoted 17 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added
of_property_present()helper when we just want to test for presence of a property and nothing more.Signed-off-by Rob Herring <[email protected]>--- drivers/devfreq/exynos-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/devfreq/exynos-bus.c +0
-0
drivers/devfreq/exynos-bus.c static int exynos_bus_probe(struct platform_device *pdev) · line 438
Quoted 8 lines
drivers/devfreq/exynos-bus.c +1
-1@@ -432,7 +432,7 @@ static int exynos_bus_probe(struct platform_device *pdev) goto err;/* Create child platform device for the interconnect provider */ -if (of_get_property (dev->of_node,"#interconnect-cells" ,NULL )) { +if (of_property_present (dev->of_node,"#interconnect-cells" )) { bus->icc_pdev =platform_device_register_data ( dev,"exynos-generic-icc" ,PLATFORM_DEVID_AUTO ,NULL ,0 );
Applied it. Thanks.
Signature · 3 lines
Best Regards, Samsung Electronics Chanwoo Choi