Skip to contentSkip to conversation

crypto: simplify one-level sysctl registration for crypto_sysctl_table

PATCH In review Luis Chamberlain 2 participants 2 messages Mar 10, 2023 – Mar 17, 2023

Subsystems (2)
VFS Crypto API
lore
Share & tools
lore

Luis Chamberlain

author
#0 lore raw

PATCH 1/1 crypto: simplify one-level sysctl registration for crypto_sysctl_table

There is no need to declare an extra tables to just create directory, this can be easily be done with a prefix path with register_sysctl().

Simplify this registration.

Signed-off-by Luis Chamberlain <[email protected]>

---

If not clear, see this new doc:

https://lore.kernel.org/all/[email protected]/T/#u

But the skinny is we can deprecate long term APIs from sysctl that uses recursion.

 crypto/fips.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
crypto/fips.c +1 -10
index b05d3c7b3ca5..92fd506abb21 100644
@@ -66,20 +66,11 @@ static struct ctl_table crypto_sysctl_table[] = {
 	{}
 };
 
-static struct ctl_table crypto_dir_table[] = {
-	{
-		.procname       = "crypto",
-		.mode           = 0555,
-		.child          = crypto_sysctl_table
-	},
-	{}
-};
-
 static struct ctl_table_header *crypto_sysctls;
 
 static void crypto_proc_fips_init(void)
 {
-	crypto_sysctls = register_sysctl_table(crypto_dir_table);
+	crypto_sysctls = register_sysctl("crypto", crypto_sysctl_table);
 }
 
 static void crypto_proc_fips_exit(void)
Signature · 1 line
2.39.1
maintainer
#1 lore raw
Quoted 10 lines · Luis Chamberlain

There is no need to declare an extra tables to just create directory, this can be easily be done with a prefix path with register_sysctl().

Simplify this registration.

Signed-off-by Luis Chamberlain <[email protected]>

---

If not clear, see this new doc:

Quoted 7 lines

https://lore.kernel.org/all/[email protected]/T/#u

But the skinny is we can deprecate long term APIs from sysctl that uses recursion.

 crypto/fips.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt