Skip to contentSkip to conversation

uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2

PATCH Superseded Yaroslav Furman 3 participants 9 messages Mar 11, 2023 – Mar 27, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2

Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them.

---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/usb/storage/unusual_uas.h +7 -0
index c7b763d6d102..e4ff28ba93e5 100644
@@ -97,6 +97,13 @@ UNUSUAL_DEV(0x152d, 0x0539, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_NO_REPORT_OPCODES),
 
+/* Reported by: Yaroslav Furman <[email protected]> */
+UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999,
+		"JMicron",
+		"JMS583Gen 2",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_REPORT_OPCODES),
+
 /* Reported-by: Claudio Bizzarri <[email protected]> */
 UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x9999,
 		"JMicron",
Signature · 1 line
2.39.2
maintainer
#1 lore raw
Quoted 14 lines · Yaroslav Furman

Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them.

---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/usb/storage/unusual_uas.h +0 -0
index c7b763d6d102..e4ff28ba93e5 100644

drivers/usb/storage/unusual_uas.h UNUSUAL_DEV(0x152d, 0x0539, 0x0000, 0x9999, · line 106

Quoted 10 lines
drivers/usb/storage/unusual_uas.h +7 -0
@@ -97,6 +97,13 @@ UNUSUAL_DEV(0x152d, 0x0539, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_NO_REPORT_OPCODES),
 
+/* Reported by: Yaroslav Furman <[email protected]> */
+UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999,
+		"JMicron",
+		"JMS583Gen 2",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_REPORT_OPCODES),
+

The new entry should be inserted in the correct location, according to the ordering by vendor ID and product ID. (Hint: 0x583 > 0x567.)

drivers/usb/storage/unusual_uas.h UNUSUAL_DEV(0x152d, 0x0539, 0x0000, 0x9999, · line 109

Quoted 3 lines
drivers/usb/storage/unusual_uas.h +0 -0
 /* Reported-by: Claudio Bizzarri <[email protected]> */
 UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x9999,
 		"JMicron",

Alan Stern

#2 lore raw

PATCH v2 1/1 uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2

Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them.

---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/usb/storage/unusual_uas.h +7 -0
index c7b763d6d102..1f8c9b16a0fb 100644
@@ -111,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_BROKEN_FUA),
 
+/* Reported by: Yaroslav Furman <[email protected]> */
+UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999,
+		"JMicron",
+		"JMS583Gen 2",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_REPORT_OPCODES),
+
 /* Reported-by: Thinh Nguyen <[email protected]> */
 UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999,
 		"PNY",
Signature · 1 line
2.39.2
#3 lore raw
Quoted 29 lines · Yaroslav Furman

Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them.

---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/usb/storage/unusual_uas.h +7 -0
index c7b763d6d102..1f8c9b16a0fb 100644
@@ -111,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_BROKEN_FUA),
 
+/* Reported by: Yaroslav Furman <[email protected]> */
+UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999,
+		"JMicron",
+		"JMS583Gen 2",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_REPORT_OPCODES),
+
 /* Reported-by: Thinh Nguyen <[email protected]> */
 UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999,
 		"PNY",
Signature · 1 line
2.39.2

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

#4 lore raw

PATCH v3 1/1 uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2

Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them.

---

V3: Moved the code in the appropriate place, after the 0x0578 device, as pointed out by Alan Stern

---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/usb/storage/unusual_uas.h +7 -0
index c7b763d6d102..1f8c9b16a0fb 100644
@@ -111,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_BROKEN_FUA),
 
+/* Reported by: Yaroslav Furman <[email protected]> */
+UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999,
+		"JMicron",
+		"JMS583Gen 2",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_REPORT_OPCODES),
+
 /* Reported-by: Thinh Nguyen <[email protected]> */
 UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999,
 		"PNY",
Signature · 1 line
2.39.2
#6 lore raw

PATCH v3 1/1 uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2

From: Yaroslav Furman <[email protected]>

Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them.

---

V3: Moved the code in the appropriate place, after the 0x0578 device, as pointed out by Alan Stern

---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/usb/storage/unusual_uas.h +7 -0
index c7b763d6d102..1f8c9b16a0fb 100644
@@ -111,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_BROKEN_FUA),
 
+/* Reported by: Yaroslav Furman <[email protected]> */
+UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999,
+		"JMicron",
+		"JMS583Gen 2",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_REPORT_OPCODES),
+
 /* Reported-by: Thinh Nguyen <[email protected]> */
 UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999,
 		"PNY",
Signature · 1 line
2.39.2
#7 lore raw
Quoted 7 lines · Yaroslav Furman

From: Yaroslav Furman <[email protected]>

Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them.

Quoted 7 lines

---

V3: Moved the code in the appropriate place, after the 0x0578 device, as pointed out by Alan Stern

---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)

I'm confused, this is already in 6.3-rc4, right?

thanks,

greg k-h