Skip to contentSkip to conversation

ACPI: APEI: EINJ: Add CXL error types

PATCH Applied Tony Luck 4 participants 4 messages Mar 14, 2023 – Mar 20, 2023

Subsystems (2)
lore
Share & tools
lore

Tony Luck

author reviewer
#0 lore raw

PATCH 1/1 ACPI: APEI: EINJ: Add CXL error types

ACPI 6.5 added six new error types for CXL. See chapter 18 table 18.30.

Add strings for the new types so that Linux will list them in the /sys/kernel/debug/apei/einj/available_error_types file.

It seems no other changes are needed. Linux already accepts the CXL codes (on a BIOS that advertises them).

---
 drivers/acpi/apei/einj.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/acpi/apei/einj.c +6 -0
index b4373e575660..39bee5a067cc 100644
@@ -584,6 +584,12 @@ static const char * const einj_error_type_string[] = {
 	"0x00000200\tPlatform Correctable\n",
 	"0x00000400\tPlatform Uncorrectable non-fatal\n",
 	"0x00000800\tPlatform Uncorrectable fatal\n",
+	"0x00001000\tCXL.cache Protocol Correctable\n",
+	"0x00002000\tCXL.cache Protocol Uncorrectable non-fatal\n",
+	"0x00004000\tCXL.cache Protocol Uncorrectable fatal\n",
+	"0x00008000\tCXL.mem Protocol Correctable\n",
+	"0x00010000\tCXL.mem Protocol Uncorrectable non-fatal\n",
+	"0x00020000\tCXL.mem Protocol Uncorrectable fatal\n",
 };
 
 static int available_error_type_show(struct seq_file *m, void *v)
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Tony Luck

ACPI 6.5 added six new error types for CXL. See chapter 18 table 18.30.

Add strings for the new types so that Linux will list them in the /sys/kernel/debug/apei/einj/available_error_types file.

It seems no other changes are needed. Linux already accepts the CXL codes (on a BIOS that advertises them).

Quoted 24 lines

---
drivers/acpi/apei/einj.c | 6 ++++++

1 file changed, 6 insertions(+)
drivers/acpi/apei/einj.c +6 -1
index b4373e575660..39bee5a067cc 100644
@@ -584,6 +584,12 @@ static const char * const einj_error_type_string[] = {
 	"0x00000200\tPlatform Correctable\n",
 	"0x00000400\tPlatform Uncorrectable non-fatal\n",
 	"0x00000800\tPlatform Uncorrectable fatal\n",
+	"0x00001000\tCXL.cache Protocol Correctable\n",
+	"0x00002000\tCXL.cache Protocol Uncorrectable non-fatal\n",
+	"0x00004000\tCXL.cache Protocol Uncorrectable fatal\n",
+	"0x00008000\tCXL.mem Protocol Correctable\n",
+	"0x00010000\tCXL.mem Protocol Uncorrectable non-fatal\n",
+	"0x00020000\tCXL.mem Protocol Uncorrectable fatal\n",
 };
 
 static int available_error_type_show(struct seq_file *m, void *v)
--

2.39.2

Reviewed-by on v1 1/1
#2 lore raw
In reply to Tony Luck
Quoted 10 lines · Tony Luck

ACPI 6.5 added six new error types for CXL. See chapter 18 table 18.30.

Add strings for the new types so that Linux will list them in the /sys/kernel/debug/apei/einj/available_error_types file.

It seems no other changes are needed. Linux already accepts the CXL codes (on a BIOS that advertises them).

Quoted 21 lines
---
  drivers/acpi/apei/einj.c | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/acpi/apei/einj.c +6 -0
index b4373e575660..39bee5a067cc 100644
@@ -584,6 +584,12 @@ static const char * const einj_error_type_string[] = {
  	"0x00000200\tPlatform Correctable\n",
  	"0x00000400\tPlatform Uncorrectable non-fatal\n",
  	"0x00000800\tPlatform Uncorrectable fatal\n",
+	"0x00001000\tCXL.cache Protocol Correctable\n",
+	"0x00002000\tCXL.cache Protocol Uncorrectable non-fatal\n",
+	"0x00004000\tCXL.cache Protocol Uncorrectable fatal\n",
+	"0x00008000\tCXL.mem Protocol Correctable\n",
+	"0x00010000\tCXL.mem Protocol Uncorrectable non-fatal\n",
+	"0x00020000\tCXL.mem Protocol Uncorrectable fatal\n",
  };
 
  static int available_error_type_show(struct seq_file *m, void *v)
maintainer Applied
#3 lore raw
In reply to Tony Luck
Quoted 23 lines · Tony Luck

ACPI 6.5 added six new error types for CXL. See chapter 18 table 18.30.

Add strings for the new types so that Linux will list them in the /sys/kernel/debug/apei/einj/available_error_types file.

It seems no other changes are needed. Linux already accepts the CXL codes (on a BIOS that advertises them).

---
 drivers/acpi/apei/einj.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/acpi/apei/einj.c +0 -0
index b4373e575660..39bee5a067cc 100644
@@ -584,6 +584,12 @@ static const char * const einj_error_type_string[] = {
        "0x00000200\tPlatform Correctable\n",
        "0x00000400\tPlatform Uncorrectable non-fatal\n",
        "0x00000800\tPlatform Uncorrectable fatal\n",

drivers/acpi/apei/einj.c static const char * const einj_error_type_string[] = {

Quoted 10 lines
drivers/acpi/apei/einj.c +6 -1
+       "0x00001000\tCXL.cache Protocol Correctable\n",
+       "0x00002000\tCXL.cache Protocol Uncorrectable non-fatal\n",
+       "0x00004000\tCXL.cache Protocol Uncorrectable fatal\n",
+       "0x00008000\tCXL.mem Protocol Correctable\n",
+       "0x00010000\tCXL.mem Protocol Uncorrectable non-fatal\n",
+       "0x00020000\tCXL.mem Protocol Uncorrectable fatal\n",
 };
 
 static int available_error_type_show(struct seq_file *m, void *v)
--

Applied as 6.4 material, thanks!