ARM: mxs: Use of_property_present() for testing DT property presence
Subsystems (3)
PATCH 1/1 ARM: mxs: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.
--- arch/arm/mach-mxs/mach-mxs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-mxs/mach-mxs.c +1 -1
@@ -174,7 +174,7 @@ static void __init update_fec_mac_prop(enum mac_oui oui) from = np; -if (of_get_property (np,"local-mac-address" ,NULL )) +if (of_property_present (np,"local-mac-address" ))continue ; newmac =kzalloc (sizeof (*newmac) +6 ,GFP_KERNEL );
Signature · 1 line
2.39.2
Shawn Guo
AppliedQuoted 8 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added
of_property_present()helper when we just want to test for presence of a property and nothing more.Signed-off-by Rob Herring <[email protected]>
Applied, thanks!