Skip to contentSkip to conversation

tools/resolve_btfids: Add libsubcmd to .gitignore

PATCH In review Greg Thelen 4 participants 4 messages Mar 15, 2023 – Mar 16, 2023 BPF

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/resolve_btfids: Add libsubcmd to .gitignore

After building the kernel I see:

  $ git status -s
  ?? tools/bpf/resolve_btfids/libbpf/

Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers") started copying header files into tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are not covered by higher level wildcard gitignores.

gitignore the entire libsubcmd directory. It's created as part of build and removed by clean.

Fixes af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
---
 tools/bpf/resolve_btfids/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/bpf/resolve_btfids/.gitignore +1 -0
index 16913fffc985..52d5e9721d92 100644
@@ -1,3 +1,4 @@
 /fixdep
 /resolve_btfids
 /libbpf/
+/libsubcmd/
Signature · 1 line
2.40.0.rc1.284.g88254d51c5-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 30 lines · Greg Thelen

After building the kernel I see:

  $ git status -s
  ?? tools/bpf/resolve_btfids/libbpf/

Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers") started copying header files into tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are not covered by higher level wildcard gitignores.

gitignore the entire libsubcmd directory. It's created as part of build and removed by clean.

Fixes af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
---
 tools/bpf/resolve_btfids/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/bpf/resolve_btfids/.gitignore +1 -0
index 16913fffc985..52d5e9721d92 100644
@@ -1,3 +1,4 @@
 /fixdep
 /resolve_btfids
 /libbpf/
+/libsubcmd/
Signature · 1 line
2.40.0.rc1.284.g88254d51c5-goog

Thanks.

Acked-by on v1 1/1
#2 lore raw
In reply to Greg Thelen
Quoted 10 lines · Greg Thelen

After building the kernel I see:

  $ git status -s
  ?? tools/bpf/resolve_btfids/libbpf/

Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers") started copying header files into tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are not covered by higher level wildcard gitignores.

Quoted 5 lines

gitignore the entire libsubcmd directory. It's created as part of build and removed by clean.

Fixes af03299d8536 ("tools/resolve_btfids: Install subcmd headers")

Thanks!
Ian

Quoted 16 lines
---
 tools/bpf/resolve_btfids/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/bpf/resolve_btfids/.gitignore +1 -1
index 16913fffc985..52d5e9721d92 100644
@@ -1,3 +1,4 @@
 /fixdep
 /resolve_btfids
 /libbpf/
+/libsubcmd/
--

2.40.0.rc1.284.g88254d51c5-goog

maintainer
#3 lore raw
In reply to Greg Thelen
Quoted 9 lines · Greg Thelen

After building the kernel I see:

   $ git status -s
   ?? tools/bpf/resolve_btfids/libbpf/

Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers") started copying header files into tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are not covered by higher level wildcard gitignores.

Quoted 5 lines

gitignore the entire libsubcmd directory. It's created as part of build and removed by clean.

Fixes af03299d8536 ("tools/resolve_btfids: Install subcmd headers")

Already fixed in bpf-next by:

commit fd4cb29f2a3d54ec7b4e012300321601af10bd68

Author: Rong Tao <[email protected]>
Date:   Sat Mar 4 23:17:04 2023 +0800

tools/resolve_btfids: Add /libsubcmd to .gitignore

Thanks,
Daniel