Skip to contentSkip to conversation

Staging: qlge: Fix indentation in conditional statement

PATCH In review Sumitra Sharma 4 participants 5 messages Mar 14, 2023 – Mar 18, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Staging: qlge: Fix indentation in conditional statement

Add tabs/spaces in conditional statements in to fix the indentation.

---
v2: Fix indentation in conditional statement, noted by Dan Carpenter
<[email protected]>
v3: Apply changes to fresh git tree

 drivers/staging/qlge/qlge_dbg.c | 35 +++++++++++++++------------------
 1 file changed, 16 insertions(+), 19 deletions(-)
drivers/staging/qlge/qlge_dbg.c +16 -19
index 66d28358342f..c7e865f515cf 100644
@@ -351,26 +351,23 @@ static int qlge_get_xgmac_regs(struct qlge_adapter *qdev, u32 *buf,
 		/* We're reading 400 xgmac registers, but we filter out
 		 * several locations that are non-responsive to reads.
 		 */
-		if ((i == 0x00000114) ||
-		    (i == 0x00000118) ||
-			(i == 0x0000013c) ||
-			(i == 0x00000140) ||
-			(i > 0x00000150 && i < 0x000001fc) ||
-			(i > 0x00000278 && i < 0x000002a0) ||
-			(i > 0x000002c0 && i < 0x000002cf) ||
-			(i > 0x000002dc && i < 0x000002f0) ||
-			(i > 0x000003c8 && i < 0x00000400) ||
-			(i > 0x00000400 && i < 0x00000410) ||
-			(i > 0x00000410 && i < 0x00000420) ||
-			(i > 0x00000420 && i < 0x00000430) ||
-			(i > 0x00000430 && i < 0x00000440) ||
-			(i > 0x00000440 && i < 0x00000450) ||
-			(i > 0x00000450 && i < 0x00000500) ||
-			(i > 0x0000054c && i < 0x00000568) ||
-			(i > 0x000005c8 && i < 0x00000600)) {
+		if ((i == 0x00000114) || (i == 0x00000118) ||
+		    (i == 0x0000013c) || (i == 0x00000140) ||
+		    (i > 0x00000150 && i < 0x000001fc) ||
+		    (i > 0x00000278 && i < 0x000002a0) ||
+		    (i > 0x000002c0 && i < 0x000002cf) ||
+		    (i > 0x000002dc && i < 0x000002f0) ||
+		    (i > 0x000003c8 && i < 0x00000400) ||
+		    (i > 0x00000400 && i < 0x00000410) ||
+		    (i > 0x00000410 && i < 0x00000420) ||
+		    (i > 0x00000420 && i < 0x00000430) ||
+		    (i > 0x00000430 && i < 0x00000440) ||
+		    (i > 0x00000440 && i < 0x00000450) ||
+		    (i > 0x00000450 && i < 0x00000500) ||
+		    (i > 0x0000054c && i < 0x00000568) ||
+		    (i > 0x000005c8 && i < 0x00000600)) {
 			if (other_function)
-				status =
-				qlge_read_other_func_xgmac_reg(qdev, i, buf);
+				status = qlge_read_other_func_xgmac_reg(qdev, i, buf);
 			else
 				status = qlge_read_xgmac_reg(qdev, i, buf);
 
Signature · 1 line
2.25.1
#2 lore raw
Quoted 12 lines · Dan Carpenter
Quoted 10 lines · Sumitra Sharma

Add tabs/spaces in conditional statements in to fix the indentation.

---
v2: Fix indentation in conditional statement, noted by Dan Carpenter
<[email protected]>
v3: Apply changes to fresh git tree

Quoted 4 lines

Thanks!

Hi dan,

Will this be considered as my first accepted patch? :)

Regards,

Sumitra

Quoted 3 lines

regards,
dan carpenter

#3 lore raw
Quoted 13 lines · Sumitra Sharma
Quoted 12 lines · Dan Carpenter
Quoted 10 lines · Sumitra Sharma

Add tabs/spaces in conditional statements in to fix the indentation.

---
v2: Fix indentation in conditional statement, noted by Dan Carpenter
<[email protected]>
v3: Apply changes to fresh git tree

Quoted 8 lines
Quoted 4 lines

Thanks!

Hi dan,

Will this be considered as my first accepted patch? :)

I think it is accepted only when Greg takes it into his tree and you can have a link for it.

julia

Quoted 9 lines

Regards,

Sumitra

Quoted 3 lines

regards,
dan carpenter