backlight: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/aat2870_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-----Original Message-----
From: Uwe Kleine-König <[email protected]>
Sent: Mittwoch, 8. März 2023 08:40
To: Hennerich, Michael <[email protected]>; Lee Jones <[email protected]>; Daniel Thompson <[email protected]>; Jingoo Han <[email protected]>; Helge Deller <[email protected]>
Cc: [email protected]; [email protected]; [email protected]
Subject: [PATCH 02/13] backlight: adp5520_bl: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/adp5520_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

drivers/video/backlight/adp5520_bl.c +1 -1

index 686988c3df3a..8e0e9cfe5fe9 100644
@@ -337,7 +337,7 @@ static int adp5520_bl_probe(struct platform_device
 *pdev)
 	return 0;
 }
 
-static int adp5520_bl_remove(struct platform_device *pdev)
+static void adp5520_bl_remove(struct platform_device *pdev)
 {
 	struct backlight_device *bl = platform_get_drvdata(pdev);

struct adp5520_bl *data = bl_get_data(bl); @@ -347,8 +347,6 @@
static int adp5520_bl_remove(struct platform_device *pdev)

drivers/video/backlight/adp5520_bl.c +1 -4

 	if (data->pdata->en_ambl_sens)
 		sysfs_remove_group(&bl->dev.kobj,
 				&adp5520_bl_attr_group);
-
-	return 0;
 }
 
 #ifdef CONFIG_PM_SLEEP

@@ -377,7 +375,7 @@ static struct platform_driver adp5520_bl_driver = {
 		.pm	= &adp5520_bl_pm_ops,
 	},
 	.probe		= adp5520_bl_probe,
-	.remove		= adp5520_bl_remove,
+	.remove_new	= adp5520_bl_remove,
 };
 
 module_platform_driver(adp5520_bl_driver);
--

2.39.1

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/adp5520_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/cr_bllcd.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored >and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/da9052_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/hp680_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/led_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/lm3533_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/lp8788_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/mt6370-backlight.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/pwm_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/qcom-wled.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/rt4831-backlight.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.

Trivially convert this driver from always returning zero in the remove callback to the void returning variant.

Signed-off-by Uwe Kleine-König <[email protected]>

---
 drivers/video/backlight/sky81452-backlight.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Uwe Kleine-König (13):
backlight: aat2870_bl: Convert to platform remove callback returning
void
backlight: adp5520_bl: Convert to platform remove callback returning
void
backlight: cr_bllcd: Convert to platform remove callback returning
void
backlight: da9052_bl: Convert to platform remove callback returning
void
backlight: hp680_bl: Convert to platform remove callback returning
void
backlight: led_bl: Convert to platform remove callback returning void
backlight: lm3533_bl: Convert to platform remove callback returning
void
backlight: lp8788_bl: Convert to platform remove callback returning
void
backlight: mt6370-backlight: Convert to platform remove callback

returning void
backlight: pwm_bl: Convert to platform remove callback returning void
backlight: qcom-wled: Convert to platform remove callback returning
void
backlight: rt4831-backlight: Convert to platform remove callback
returning void
backlight: sky81452-backlight: Convert to platform remove callback
returning void