io_uring: rsrc: Optimize return value variable 'ret'
PATCH 1/1 io_uring: rsrc: Optimize return value variable 'ret'
The function returns here and returns ret directly. It may look better.
Signed-off-by Li zeming <[email protected]>
--- io_uring/rsrc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
io_uring/rsrc.c +2 -2
@@ -415,11 +415,11 @@ __cold static int io_rsrc_data_alloc(struct io_ring_ctx *ctx, data =kzalloc (sizeof (*data),GFP_KERNEL );if (!data) -return -ENOMEM ; +return ret; data->tags = (u64 **)io_alloc_page_table (nr *sizeof (data->tags[0 ][0 ]));if (!data->tags) {kfree (data); -return -ENOMEM ; +return ret; } data->nr = nr;
Signature · 1 line
2.18.2
Jens Axboe
maintainerQuoted 1 line · Li zeming
The function returns here and returns ret directly. It may look better.
I think it'd be better to just initialize 'ret' to 0 instead.
Signature · 1 line
Jens Axboe