dt-bindings: PCI: Fix unit address of example root port
PATCH 1/1 dt-bindings: PCI: Fix unit address of example root port
Fix the unit address of the example root port which is identical to the device number (i.e. 1).
--- Documentation/devicetree/bindings/pci/pci.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/pci.txt +1 -1
@@ -76,7 +76,7 @@ Example: pcie@10000000 { compatible = "pci-host-ecam-generic"; ... - pcie@0008 { + pcie@1 { /* Root port 00:01.0 is external-facing */ reg = <0x00000800 0 0 0 0>; external-facing;
Signature · 1 line
2.39.2
Quoted 8 lines · Johan Hovold
Fix the unit address of the example root port which is identical to the device number (i.e. 1).
Signed-off-by Johan Hovold <[email protected]>--- Documentation/devicetree/bindings/pci/pci.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines · Johan Hovold
Fix the unit address of the example root port which is identical to the device number (i.e. 1).
Signed-off-by Johan Hovold <[email protected]>---
This one hasn't showed up in linux-next yet. Could you pick it up for 6.4, Lorenzo?
Quoted 8 lines
Documentation/devicetree/bindings/pci/pci.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/pci/pci.txt +0
-0
Documentation/devicetree/bindings/pci/pci.txt Example: · line 82
Quoted 8 lines
Documentation/devicetree/bindings/pci/pci.txt +1
-1@@ -76,7 +76,7 @@ Example: pcie@10000000 { compatible = "pci-host-ecam-generic"; - pcie@0008 { + pcie@1 { /* Root port 00:01.0 is external-facing */ reg = <0x00000800 0 0 0 0>; external-facing;
Johan
Rob Herring
maintainerQuoted 10 lines · Johan Hovold
Quoted 5 lines · Johan Hovold
Fix the unit address of the example root port which is identical to the device number (i.e. 1).
Signed-off-by Johan Hovold <[email protected]>---
This one hasn't showed up in linux-next yet. Could you pick it up for 6.4, Lorenzo?
On 2nd thought, I think it's time to just remove this file. The schema is just missing some descriptions and 1 property (external-facing). I've added all that here[1].
I didn't add the example to the schema because the example here is incomplete and won't validate.
Rob
[1] https://github.com/robherring/dt-schema/commit/8445eb010e61496681e2504faf400e9fbc5b1acf
Quoted 9 lines · Rob Herring
Quoted 8 lines · Johan Hovold
Quoted 5 lines · Johan Hovold
Fix the unit address of the example root port which is identical to the device number (i.e. 1).
Signed-off-by Johan Hovold <[email protected]>---
Quoted 6 lines
Quoted 2 lines
This one hasn't showed up in linux-next yet. Could you pick it up for 6.4, Lorenzo?
On 2nd thought, I think it's time to just remove this file. The schema is just missing some descriptions and 1 property (external-facing). I've added all that here[1].
Sounds good to me. Will you send a patch?
Quoted 2 lines
I didn't add the example to the schema because the example here is incomplete and won't validate.
Fair enough. Having a decent example in the tree would be helpful, but hopefully we can get the in-tree DT sources up to par at some point so that they can serve that purpose.
Johan