Skip to contentSkip to conversation

ALSA: portman2x4: remove unused portman_read_command,data functions

PATCH In review Tom Rix 2 participants 2 messages Mar 18, 2023 – Mar 19, 2023 Sound

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 ALSA: portman2x4: remove unused portman_read_command,data functions

clang with W=1 reports sound/drivers/portman2x4.c:185:18: error: unused function
'portman_read_command' [-Werror,-Wunused-function]
static inline u8 portman_read_command(struct portman *pm)

                 ^
sound/drivers/portman2x4.c:195:18: error: unused function
  'portman_read_data' [-Werror,-Wunused-function]
static inline u8 portman_read_data(struct portman *pm)
                 ^

These static functions are not used, so remove them.

---
 sound/drivers/portman2x4.c | 10 ----------
 1 file changed, 10 deletions(-)
sound/drivers/portman2x4.c +0 -10
index 52a656735365..4cdf56a0eb65 100644
@@ -182,21 +182,11 @@ static inline void portman_write_command(struct portman *pm, u8 value)
 	parport_write_control(pm->pardev->port, value);
 }
 
-static inline u8 portman_read_command(struct portman *pm)
-{
-	return parport_read_control(pm->pardev->port);
-}
-
 static inline u8 portman_read_status(struct portman *pm)
 {
 	return parport_read_status(pm->pardev->port);
 }
 
-static inline u8 portman_read_data(struct portman *pm)
-{
-	return parport_read_data(pm->pardev->port);
-}
-
 static inline void portman_write_data(struct portman *pm, u8 value)
 {
 	parport_write_data(pm->pardev->port, value);
Signature · 1 line
2.27.0
#1 lore raw
Quoted 5 lines · Tom Rix

clang with W=1 reports sound/drivers/portman2x4.c:185:18: error: unused function
'portman_read_command' [-Werror,-Wunused-function]
static inline u8 portman_read_command(struct portman *pm)

Quoted 8 lines
                 ^
sound/drivers/portman2x4.c:195:18: error: unused function
  'portman_read_data' [-Werror,-Wunused-function]
static inline u8 portman_read_data(struct portman *pm)
                 ^

These static functions are not used, so remove them.

Applied now, thanks.

Takashi