Skip to contentSkip to conversation

comedi: remove unused dma_chain_flag_bits function

PATCH In review Tom Rix 2 participants 2 messages Mar 21, 2023 Comedi drivers

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 comedi: remove unused dma_chain_flag_bits function

clang with W=1 reports drivers/comedi/drivers/cb_pcidas64.c:377:28: error: unused function
'dma_chain_flag_bits' [-Werror,-Wunused-function]
static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)

                           ^

This function is not used, so remove it.

---
 drivers/comedi/drivers/cb_pcidas64.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/comedi/drivers/cb_pcidas64.c +0 -5
index ca6038a25f26..59390b23fa81 100644
@@ -374,11 +374,6 @@ static inline u16 pipe_full_bits(u16 hw_status_bits)
 	return (hw_status_bits >> 10) & 0x3;
 };
 
-static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)
-{
-	return (prepost_bits >> 6) & 0x3;
-}
-
 static inline unsigned int adc_upper_read_ptr_code(u16 prepost_bits)
 {
 	return (prepost_bits >> 12) & 0x3;
Signature · 1 line
2.27.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Tom Rix

clang with W=1 reports drivers/comedi/drivers/cb_pcidas64.c:377:28: error: unused function
'dma_chain_flag_bits' [-Werror,-Wunused-function]
static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)

                            ^

This function is not used, so remove it.

---
  drivers/comedi/drivers/cb_pcidas64.c | 5 -----
  1 file changed, 5 deletions(-)
drivers/comedi/drivers/cb_pcidas64.c +0 -0
index ca6038a25f26..59390b23fa81 100644
@@ -374,11 +374,6 @@ static inline u16 pipe_full_bits(u16 hw_status_bits)
  	return (hw_status_bits >> 10) & 0x3;

drivers/comedi/drivers/cb_pcidas64.c static inline u16 pipe_full_bits(u16 hw_status_bits) · line 379

Quoted 10 lines
drivers/comedi/drivers/cb_pcidas64.c +0 -5
  };
 
-static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)
-{
-	return (prepost_bits >> 6) & 0x3;
-}
-
  static inline unsigned int adc_upper_read_ptr_code(u16 prepost_bits)
  {
  	return (prepost_bits >> 12) & 0x3;

Looks OK, thanks!

Signature · 4 lines
-=( Ian Abbott <[email protected]> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-