Tegra234 Memory interconnect support
Subsystems (6)
v3 cover Tegra234 Memory interconnect support
Hi Krzysztof.
Thank you for the ACK on the Memory patches [2-5 & 8]. Rebased the patch series on latest next and added two more patches for 'memory' in v3. Please review and ACK if fine.
[Patch v3 10/11] memory: tegra: handle no BWMGR MRQ support in BPMP [Patch v3 11/11] memory: tegra186-emc: fix interconnect registration
Hi All,
Requesting for ACK on below remaining patches and please consider for merging in "6.4".
- Thierry:
"Memory Interconnect base support" patches are dependent on the bpmp patch. [Patch v3 1/9] firmware: tegra: add function to get BPMP data
- Rafael & Viresh: For the CPUFREQ MC Client patches.
[Patch v3 06/11] arm64: tegra: Add cpu OPP tables and interconnects property [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth
- Lorenzo, Bjorn & Krzysztof Wilczyński: For the PCIE MC client patch. [Patch v3 09/11] PCI: tegra194: add interconnect support in Tegra234
Thank you,
Sumit Gupta
============
This patch series adds memory interconnect support for Tegra234 SoC. It is used to dynamically scale DRAM Frequency as per the bandwidth requests from different Memory Controller (MC) clients.
MC Clients use ICC Framework's icc_set_bw() api to dynamically request for the DRAM bandwidth (BW). As per path, the request will be routed from MC to the EMC driver. MC driver passes the request info like the Client ID, type, and frequency request info to the BPMP-FW which will set the final DRAM freq considering all exisiting requests.
MC and EMC are the ICC providers. Nodes in path for a request will be:
Client[1-n] -> MC -> EMC -> EMEM/DRAM
The patch series also adds interconnect support in below client drivers:
1) CPUFREQ driver for scaling bandwidth with CPU frequency. For that, added per cluster OPP table which will be used in the CPUFREQ driver by requesting the minimum BW respective to the given CPU frequency in the OPP table of given cluster.
2) PCIE driver to request BW required for different modes.
---
v2[2] -> v3:
- in 'patch 7', set 'icc_dram_bw_scaling' to false if set_opp call failed to avoid flooding of uart with 'Failed to set bw' messages.
- added 'patch 10' to handle if the bpmp-fw is old and not support bwmgr mrq.
- added 'patch 11' to fix interconnect registration in tegra186-emc. ref patch link in linux next:
[https://lore.kernel.org/all/[email protected]/]
v1[1] -> v2:
- moved BW setting to tegra234_mc_icc_set() from EMC driver.
- moved sw clients to the 'tegra_mc_clients' table.
- point 'node->data' to the entry within 'tegra_mc_clients'.
- removed 'struct tegra_icc_node' and get client info using 'node->data'.
- changed error handling in and around tegra_emc_interconnect_init().
- moved 'tegra-icc.h' from 'include/soc/tegra' to 'include/linux'.
- added interconnect support to PCIE driver in 'Patch 9'.
- merged 'Patch 9 & 10' from [1] to get num_channels and use.
- merged 'Patch 2 & 3' from [1] to add ISO and NISO clients.
- added 'Acked-by' of Krzysztof from 'Patch 05/10' of [1].
- Removed 'Patch 7' from [1] as that is merged now.
Sumit Gupta (11):
firmware: tegra: add function to get BPMP data
memory: tegra: add interconnect support for DRAM scaling in Tegra234
memory: tegra: add mc clients for Tegra234
memory: tegra: add software mc clients in Tegra234
dt-bindings: tegra: add icc ids for dummy MC clients
arm64: tegra: Add cpu OPP tables and interconnects property
cpufreq: tegra194: add OPP support and set bandwidth
memory: tegra: make cpu cluster bw request a multiple of mc channels
PCI: tegra194: add interconnect support in Tegra234
memory: tegra: handle no BWMGR MRQ support in BPMP
memory: tegra186-emc: fix interconnect registration race
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 276 ++++++++++ drivers/cpufreq/tegra194-cpufreq.c | 156 +++++- drivers/firmware/tegra/bpmp.c | 38 ++ drivers/memory/tegra/mc.c | 24 + drivers/memory/tegra/mc.h | 1 + drivers/memory/tegra/tegra186-emc.c | 118 ++++ drivers/memory/tegra/tegra234.c | 599 ++++++++++++++++++++- drivers/pci/controller/dwc/pcie-tegra194.c | 40 +- include/dt-bindings/memory/tegra234-mc.h | 5 + include/linux/tegra-icc.h | 65 +++ include/soc/tegra/bpmp.h | 5 + include/soc/tegra/mc.h | 8 +- 12 files changed, 1312 insertions(+), 23 deletions(-) create mode 100644 include/linux/tegra-icc.h
[1] https://lore.kernel.org/lkml/[email protected]/T/
[2] https://lore.kernel.org/linux-tegra/[email protected]/
Signature · 1 line
2.17.1
PATCH v3 1/11 firmware: tegra: add function to get BPMP data
Add new function 'of_tegra_bpmp_get()' which can be used by other drivers like MC to get BPMP data without adding any property in respective drivers DT node.
--- drivers/firmware/tegra/bpmp.c | 38 +++++++++++++++++++++++++++++++++++ include/soc/tegra/bpmp.h | 5 +++++ 2 files changed, 43 insertions(+)
drivers/firmware/tegra/bpmp.c +38 -0
@@ -39,6 +39,44 @@ channel_to_ops(struct tegra_bpmp_channel *channel)return bpmp->soc->ops; } +struct tegra_bpmp *of_tegra_bpmp_get (void ) +{ +struct platform_device *pdev; +struct device_node *bpmp_dev; +struct tegra_bpmp *bpmp; + +/* Check for bpmp device status in DT */ + bpmp_dev =of_find_compatible_node (NULL ,NULL ,"nvidia,tegra186-bpmp" ); +if (!bpmp_dev) { + bpmp =ERR_PTR (-ENODEV ); + goto err_out; + } +if (!of_device_is_available (bpmp_dev)) { + bpmp =ERR_PTR (-ENODEV ); + goto err_put; + } + + pdev =of_find_device_by_node (bpmp_dev); +if (!pdev) { + bpmp =ERR_PTR (-ENODEV ); + goto err_put; + } + + bpmp =platform_get_drvdata (pdev); +if (!bpmp) { + bpmp =ERR_PTR (-EPROBE_DEFER ); +put_device (&pdev->dev); + goto err_put; + } + +return bpmp; +err_put: +of_node_put (bpmp_dev); +err_out: +return bpmp; +} +EXPORT_SYMBOL_GPL (of_tegra_bpmp_get); +struct tegra_bpmp *tegra_bpmp_get (struct device *dev) {struct platform_device *pdev;
include/soc/tegra/bpmp.h +5 -0
@@ -120,6 +120,7 @@ struct tegra_bpmp_message { };#if IS_ENABLED (CONFIG_TEGRA_BPMP ) +struct tegra_bpmp *of_tegra_bpmp_get (void );struct tegra_bpmp *tegra_bpmp_get (struct device *dev);void tegra_bpmp_put (struct tegra_bpmp *bpmp); int tegra_bpmp_transfer_atomic(struct tegra_bpmp *bpmp,
@@ -135,6 +136,10 @@ void tegra_bpmp_free_mrq(struct tegra_bpmp *bpmp, unsigned int mrq, void *data);bool tegra_bpmp_mrq_is_supported (struct tegra_bpmp *bpmp,unsigned int mrq);#else +static inline struct tegra_bpmp *of_tegra_bpmp_get (void ) +{ +return ERR_PTR (-EOPNOTSUPP ); +}static inline struct tegra_bpmp *tegra_bpmp_get (struct device *dev) {return ERR_PTR (-ENOTSUPP );
Signature · 1 line
2.17.1
Re: [Patch v3 01/11] firmware: tegra: add function to get BPMP data
Quoted 9 lines · Sumit Gupta
Add new function '
of_tegra_bpmp_get()' which can be used by other drivers like MC to get BPMP data without adding any property in respective drivers DT node.Signed-off-by Sumit Gupta <[email protected]>--- drivers/firmware/tegra/bpmp.c | 38 +++++++++++++++++++++++++++++++++++ include/soc/tegra/bpmp.h | 5 +++++ 2 files changed, 43 insertions(+)
Sorry for not noticing this earlier, but can we not resolve the BPMP using the existing tegra_bpmp_get()? That requires the presence of the nvidia,bpmp property, but since we're adding new functionality here that's not a problem.
Thierry
Re: [Patch v3 01/11] firmware: tegra: add function to get BPMP data
Quoted 11 lines · Thierry Reding
Quoted 9 lines · Sumit Gupta
Add new function '
of_tegra_bpmp_get()' which can be used by other drivers like MC to get BPMP data without adding any property in respective drivers DT node.Signed-off-by Sumit Gupta <[email protected]>--- drivers/firmware/tegra/bpmp.c | 38 +++++++++++++++++++++++++++++++++++ include/soc/tegra/bpmp.h | 5 +++++ 2 files changed, 43 insertions(+)
Quoted 6 lines
Sorry for not noticing this earlier, but can we not resolve the BPMP using the existing
tegra_bpmp_get()? That requires the presence of the nvidia,bpmp property, but since we're adding new functionality here that's not a problem.Thierry
Ok, will add "nvidia,bpmp" property within mc node and cache the result to use later instead of doing the lookup every time. Also, will drop this patch in v4.
Thank you for suggesting.
Thank,
Sumit
PATCH v3 2/11 memory: tegra: add interconnect support for DRAM scaling in Tegra234
In reply to Sumit GuptaAdd Interconnect framework support to dynamically set the DRAM bandwidth from different clients. Both the MC and EMC drivers are added as ICC providers. The path for any request is:
MC-Client[1-n] -> MC -> EMC -> EMEM/DRAM
MC client's request for bandwidth will go to the MC driver which passes the client request info like BPMP Client ID, Client type and the Bandwidth to the BPMP-FW. The final DRAM freq to achieve the requested bandwidth is set by the BPMP-FW based on the passed parameters.
--- drivers/memory/tegra/mc.c | 5 + drivers/memory/tegra/tegra186-emc.c | 117 +++++++++++++++++++++++ drivers/memory/tegra/tegra234.c | 139 +++++++++++++++++++++++++++- include/linux/tegra-icc.h | 65 +++++++++++++ include/soc/tegra/mc.h | 5 + 5 files changed, 330 insertions(+), 1 deletion(-) create mode 100644 include/linux/tegra-icc.h
drivers/memory/tegra/mc.c +5 -0
@@ -15,6 +15,7 @@#include <linux/platform_device.h> #include <linux/slab.h> #include <linux/sort.h> +#include <linux/tegra-icc.h> #include <soc/tegra/fuse.h>
@@ -792,6 +793,8 @@ static int tegra_mc_interconnect_setup(struct tegra_mc *mc) mc->provider.data = &mc->provider; mc->provider.set = mc->soc->icc_ops->set; mc->provider.aggregate = mc->soc->icc_ops->aggregate; + mc->provider.get_bw = mc->soc->icc_ops->get_bw; + mc->provider.xlate = mc->soc->icc_ops->xlate; mc->provider.xlate_extended = mc->soc->icc_ops->xlate_extended;icc_provider_init (&mc->provider);
@@ -824,6 +827,8 @@ static int tegra_mc_interconnect_setup(struct tegra_mc *mc) err =icc_link_create (node,TEGRA_ICC_MC );if (err) goto remove_nodes; + + node->data = (char *)&(mc->soc->clients[i]); } err =icc_provider_register (&mc->provider);
drivers/memory/tegra/tegra186-emc.c +117 -0
163 lines not on this page · raw message
drivers/memory/tegra/tegra234.c +138 -1
234 lines not on this page · raw message
include/linux/tegra-icc.h new file +65 -0
65 lines not on this page · raw message
include/soc/tegra/mc.h +5 -0
@@ -13,6 +13,7 @@#include <linux/irq.h> #include <linux/reset-controller.h> #include <linux/types.h> +#include <linux/tegra-icc.h> struct clk ;struct device ;
@@ -26,6 +27,8 @@ struct tegra_mc_timing {struct tegra_mc_client {unsigned int id; +unsigned int bpmp_id; +enum tegra_icc_client_type type;const char *name;/* * For Tegra210 and earlier, this is the SWGROUP ID used for IOVA translations in the
@@ -166,8 +169,10 @@ struct tegra_mc_icc_ops {int (*set)(struct icc_node *src,struct icc_node *dst);int (*aggregate)(struct icc_node *node,u32 tag,u32 avg_bw,u32 peak_bw,u32 *agg_avg,u32 *agg_peak); +struct icc_node * (*xlate)(struct of_phandle_args *spec,void *data);struct icc_node_data *(*xlate_extended)(struct of_phandle_args *spec,void *data); +int (*get_bw)(struct icc_node *node,u32 *avg,u32 *peak); };struct tegra_mc_ops {
Signature · 1 line
2.17.1
Re: [Patch v3 02/11] memory: tegra: add interconnect support for DRAM scaling in Tegra234
On Mon, Mar 20, 2023 at 11:54:32PM +0530, Sumit Gupta wrote:
[...]
Quoted 1 line
drivers/memory/tegra/tegra234.c +0
-0
[...]
Quoted 14 lines
drivers/memory/tegra/tegra234.c +14
-0+static int tegra234_mc_icc_set (struct icc_node *src,struct icc_node *dst) +{ +struct tegra_mc *mc =icc_provider_to_tegra_mc (dst->provider); +struct mrq_bwmgr_int_request bwmgr_req = {0 }; +struct mrq_bwmgr_int_response bwmgr_resp = {0 }; +const struct tegra_mc_client *pclient = src->data; +struct tegra_bpmp_message msg; +struct tegra_bpmp *bpmp; +int ret; + +/* +* Same Src and Dst node will happen during boot from icc_node_add(). +* This can be used to pre-initialize and set bandwidth for all clients +* before their drivers are loaded. We are skipping this case as for us,
drivers/memory/tegra/tegra234.c static const struct tegra_mc_client tegra234_mc_clients[] = { · line 400
Quoted 10 lines
drivers/memory/tegra/tegra234.c +10
-0+* the pre-initialization already happened in Bootloader(MB2) and BPMP-FW. +*/ +if (src->id == dst->id) +return 0 ; + + bpmp =of_tegra_bpmp_get (); +if (IS_ERR (bpmp)) { + ret =PTR_ERR (bpmp); +return ret; + }
Irrespective of Whether we end up doing the BPMP lookup via tegra_bpmp_get() or of_tegra_bpmp_get(), I think we should resolve at probe time and cache the result, since this function can get called multiple times and the lookup is a rather heavy operation.
Thierry
PATCH v3 3/11 memory: tegra: add mc clients for Tegra234
In reply to Sumit GuptaAdd few Isochronous (ISO) and Non-ISO MC clients. ISO clients have guaranteed bandwidth requirement. PCIE clients added to the mc_clients table represent each controller in Tegra234.
--- drivers/memory/tegra/tegra234.c | 420 ++++++++++++++++++++++++++++++++ 1 file changed, 420 insertions(+)
drivers/memory/tegra/tegra234.c +420 -0
@@ -15,6 +15,30 @@static const struct tegra_mc_client tegra234_mc_clients[] = { { + .id =TEGRA234_MEMORY_CLIENT_HDAR , + .name ="hdar" , + .bpmp_id =TEGRA_ICC_BPMP_HDA , + .type =TEGRA_ICC_ISO_AUDIO , + .sid =TEGRA234_SID_HDA , + .regs = { + .sid = { + .override =0xa8 , + .security =0xac , + }, + }, + }, { + .id =TEGRA234_MEMORY_CLIENT_HDAW , + .name ="hdaw" , + .bpmp_id =TEGRA_ICC_BPMP_HDA , + .type =TEGRA_ICC_ISO_AUDIO , + .sid =TEGRA234_SID_HDA , + .regs = { + .sid = { + .override =0x1a8 , + .security =0x1ac , + }, + }, + }, { .id =TEGRA234_MEMORY_CLIENT_MGBEARD , .name ="mgbeard" , .bpmp_id =TEGRA_ICC_BPMP_EQOS ,
@@ -134,6 +158,90 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { .security = 0x33c, }, }, + }, { + .id = TEGRA234_MEMORY_CLIENT_VI2W, + .name = "vi2w", + .bpmp_id = TEGRA_ICC_BPMP_VI2, + .type = TEGRA_ICC_ISO_VI, + .sid = TEGRA234_SID_ISO_VI2, + .regs = { + .sid = { + .override = 0x380, + .security = 0x384, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_VI2FALR, + .name = "vi2falr", + .bpmp_id = TEGRA_ICC_BPMP_VI2FAL, + .type = TEGRA_ICC_ISO_VIFAL, + .sid = TEGRA234_SID_ISO_VI2FALC, + .regs = { + .sid = { + .override = 0x388, + .security = 0x38c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_VI2FALW, + .name = "vi2falw", + .bpmp_id = TEGRA_ICC_BPMP_VI2FAL, + .type = TEGRA_ICC_ISO_VIFAL, + .sid = TEGRA234_SID_ISO_VI2FALC, + .regs = { + .sid = { + .override = 0x3e0, + .security = 0x3e4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_APER, + .name = "aper", + .bpmp_id = TEGRA_ICC_BPMP_APE, + .type = TEGRA_ICC_ISO_AUDIO, + .sid = TEGRA234_SID_APE, + .regs = { + .sid = { + .override = 0x3d0, + .security = 0x3d4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_APEW, + .name = "apew", + .bpmp_id = TEGRA_ICC_BPMP_APE, + .type = TEGRA_ICC_ISO_AUDIO, + .sid = TEGRA234_SID_APE, + .regs = { + .sid = { + .override = 0x3d8, + .security = 0x3dc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_NVDISPLAYR, + .name = "nvdisplayr", + .bpmp_id = TEGRA_ICC_BPMP_DISPLAY, + .type = TEGRA_ICC_ISO_DISPLAY, + .sid = TEGRA234_SID_ISO_NVDISPLAY, + .regs = { + .sid = { + .override = 0x490, + .security = 0x494, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_NVDISPLAYR1, + .name = "nvdisplayr1", + .bpmp_id = TEGRA_ICC_BPMP_DISPLAY, + .type = TEGRA_ICC_ISO_DISPLAY, + .sid = TEGRA234_SID_ISO_NVDISPLAY, + .regs = { + .sid = { + .override = 0x508, + .security = 0x50c, + }, + }, }, { .id = TEGRA234_MEMORY_CLIENT_BPMPR, .name = "bpmpr",
@@ -358,6 +466,318 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { .security = 0x37c, }, }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE0R, + .name = "pcie0r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_0, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE0, + .regs = { + .sid = { + .override = 0x6c0, + .security = 0x6c4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE0W, + .name = "pcie0w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_0, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE0, + .regs = { + .sid = { + .override = 0x6c8, + .security = 0x6cc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE1R, + .name = "pcie1r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_1, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE1, + .regs = { + .sid = { + .override = 0x6d0, + .security = 0x6d4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE1W, + .name = "pcie1w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_1, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE1, + .regs = { + .sid = { + .override = 0x6d8, + .security = 0x6dc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE2AR, + .name = "pcie2ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_2, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE2, + .regs = { + .sid = { + .override = 0x6e0, + .security = 0x6e4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE2AW, + .name = "pcie2aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_2, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE2, + .regs = { + .sid = { + .override = 0x6e8, + .security = 0x6ec, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE3R, + .name = "pcie3r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_3, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE3, + .regs = { + .sid = { + .override = 0x6f0, + .security = 0x6f4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE3W, + .name = "pcie3w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_3, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE3, + .regs = { + .sid = { + .override = 0x6f8, + .security = 0x6fc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE4R, + .name = "pcie4r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_4, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE4, + .regs = { + .sid = { + .override = 0x700, + .security = 0x704, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE4W, + .name = "pcie4w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_4, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE4, + .regs = { + .sid = { + .override = 0x708, + .security = 0x70c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE5R, + .name = "pcie5r", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_5, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE5, + .regs = { + .sid = { + .override = 0x710, + .security = 0x714, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE5W, + .name = "pcie5w", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_5, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE5, + .regs = { + .sid = { + .override = 0x718, + .security = 0x71c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE5R1, + .name = "pcie5r1", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_5, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE5, + .regs = { + .sid = { + .override = 0x778, + .security = 0x77c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE6AR, + .name = "pcie6ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_6, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE6, + .regs = { + .sid = { + .override = 0x140, + .security = 0x144, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE6AW, + .name = "pcie6aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_6, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE6, + .regs = { + .sid = { + .override = 0x148, + .security = 0x14c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE6AR1, + .name = "pcie6ar1", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_6, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE6, + .regs = { + .sid = { + .override = 0x1e8, + .security = 0x1ec, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE7AR, + .name = "pcie7ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_7, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE7, + .regs = { + .sid = { + .override = 0x150, + .security = 0x154, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE7AW, + .name = "pcie7aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_7, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE7, + .regs = { + .sid = { + .override = 0x180, + .security = 0x184, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE7AR1, + .name = "pcie7ar1", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_7, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE7, + .regs = { + .sid = { + .override = 0x248, + .security = 0x24c, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE8AR, + .name = "pcie8ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_8, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE8, + .regs = { + .sid = { + .override = 0x190, + .security = 0x194, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE8AW, + .name = "pcie8aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_8, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE8, + .regs = { + .sid = { + .override = 0x1d8, + .security = 0x1dc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE9AR, + .name = "pcie9ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_9, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE9, + .regs = { + .sid = { + .override = 0x1e0, + .security = 0x1e4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE9AW, + .name = "pcie9aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_9, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE9, + .regs = { + .sid = { + .override = 0x1f0, + .security = 0x1f4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE10AR, + .name = "pcie10ar", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_10, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE10, + .regs = { + .sid = { + .override = 0x1f8, + .security = 0x1fc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE10AW, + .name = "pcie10aw", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_10, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE10, + .regs = { + .sid = { + .override = 0x200, + .security = 0x204, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_PCIE10AR1, + .name = "pcie10ar1", + .bpmp_id = TEGRA_ICC_BPMP_PCIE_10, + .type = TEGRA_ICC_NISO, + .sid = TEGRA234_SID_PCIE10, + .regs = { + .sid = { + .override = 0x240, + .security = 0x244, + }, + }, }, };
Signature · 1 line
2.17.1
PATCH v3 4/11 memory: tegra: add software mc clients in Tegra234
In reply to Sumit GuptaAdd dummy Memory Controller clients to represent CPU clusters. They will be used by the CPUFREQ driver to scale DRAM FREQ with the CPU FREQ.
--- drivers/memory/tegra/tegra234.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/memory/tegra/tegra234.c +15 -0
@@ -778,6 +778,21 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { .security = 0x244, }, }, + }, { + .id = TEGRA_ICC_MC_CPU_CLUSTER0, + .name = "sw_cluster0", + .bpmp_id = TEGRA_ICC_BPMP_CPU_CLUSTER0, + .type = TEGRA_ICC_NISO, + }, { + .id = TEGRA_ICC_MC_CPU_CLUSTER1, + .name = "sw_cluster1", + .bpmp_id = TEGRA_ICC_BPMP_CPU_CLUSTER1, + .type = TEGRA_ICC_NISO, + }, { + .id = TEGRA_ICC_MC_CPU_CLUSTER2, + .name = "sw_cluster2", + .bpmp_id = TEGRA_ICC_BPMP_CPU_CLUSTER2, + .type = TEGRA_ICC_NISO, }, };
Signature · 1 line
2.17.1
PATCH v3 5/11 dt-bindings: tegra: add icc ids for dummy MC clients
In reply to Sumit GuptaAdd ICC id's for dummy software clients representing CCPLEX clusters.
--- include/dt-bindings/memory/tegra234-mc.h | 5 +++++ 1 file changed, 5 insertions(+)
include/dt-bindings/memory/tegra234-mc.h +5 -0
@@ -536,4 +536,9 @@#define TEGRA234_MEMORY_CLIENT_NVJPG1SRD 0x123#define TEGRA234_MEMORY_CLIENT_NVJPG1SWR 0x124 +/* ICC ID's for dummy MC clients used to represent CPU Clusters */ +#define TEGRA_ICC_MC_CPU_CLUSTER0 1003 +#define TEGRA_ICC_MC_CPU_CLUSTER1 1004 +#define TEGRA_ICC_MC_CPU_CLUSTER2 1005 +#endif
Signature · 1 line
2.17.1
PATCH v3 6/11 arm64: tegra: Add cpu OPP tables and interconnects property
In reply to Sumit GuptaAdd OPP table and interconnects property to scale DDR frequency with CPU frequency for better performance. Each operating point entry of the OPP table has CPU freq to per MC channel bandwidth mapping. One table is added for each cluster even though the table data is same because the bandwidth request is per cluster. This is done because OPP framework creates a single icc path and hence single bandwidth request if the table is marked as 'opp-shared' and shared among all clusters. For us, the OPP table data is same but the MC Client ID argument to interconnects property is different for each cluster. So, having per cluster table makes different icc path for each cluster and helps to make per cluster BW requests.
--- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 276 +++++++++++++++++++++++ 1 file changed, 276 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234.dtsi +276 -0
@@ -3013,6 +3013,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl0_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER0 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3029,6 +3032,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl0_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER0 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3045,6 +3051,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl0_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER0 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3061,6 +3070,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl0_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER0 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3077,6 +3089,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl1_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER1 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3093,6 +3108,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl1_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER1 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3109,6 +3127,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl1_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER1 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3125,6 +3146,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl1_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER1 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3141,6 +3165,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl2_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER2 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3157,6 +3184,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl2_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER2 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3173,6 +3203,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl2_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER2 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3189,6 +3222,9 @@ enable-method = "psci"; + operating-points-v2 = <&cl2_opp_tbl>; + interconnects = <&mc TEGRA_ICC_MC_CPU_CLUSTER2 &emc>; + i-cache-size = <65536>; i-cache-line-size = <64>; i-cache-sets = <256>;
@@ -3445,4 +3481,244 @@ interrupt-parent = <&gic>; always-on; }; + + cl0_opp_tbl: opp-table-cluster0 { + compatible = "operating-points-v2"; + opp-shared; + + cl0_ch1_opp1: opp-115200000 { + opp-hz = /bits/ 64 <115200000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp2: opp-268800000 { + opp-hz = /bits/ 64 <268800000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp3: opp-422400000 { + opp-hz = /bits/ 64 <422400000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp4: opp-576000000 { + opp-hz = /bits/ 64 <576000000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp5: opp-729600000 { + opp-hz = /bits/ 64 <729600000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp6: opp-883200000 { + opp-hz = /bits/ 64 <883200000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp7: opp-1036800000 { + opp-hz = /bits/ 64 <1036800000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp8: opp-1190400000 { + opp-hz = /bits/ 64 <1190400000>; + opp-peak-kBps = <816000>; + }; + + cl0_ch1_opp9: opp-1344000000 { + opp-hz = /bits/ 64 <1344000000>; + opp-peak-kBps = <1632000>; + }; + + cl0_ch1_opp10: opp-1497600000 { + opp-hz = /bits/ 64 <1497600000>; + opp-peak-kBps = <1632000>; + }; + + cl0_ch1_opp11: opp-1651200000 { + opp-hz = /bits/ 64 <1651200000>; + opp-peak-kBps = <2660000>; + }; + + cl0_ch1_opp12: opp-1804800000 { + opp-hz = /bits/ 64 <1804800000>; + opp-peak-kBps = <2660000>; + }; + + cl0_ch1_opp13: opp-1958400000 { + opp-hz = /bits/ 64 <1958400000>; + opp-peak-kBps = <3200000>; + }; + + cl0_ch1_opp14: opp-2112000000 { + opp-hz = /bits/ 64 <2112000000>; + opp-peak-kBps = <6400000>; + }; + + cl0_ch1_opp15: opp-2201600000 { + opp-hz = /bits/ 64 <2201600000>; + opp-peak-kBps = <6400000>; + }; + }; + + cl1_opp_tbl: opp-table-cluster1 { + compatible = "operating-points-v2"; + opp-shared; + + cl1_ch1_opp1: opp-115200000 { + opp-hz = /bits/ 64 <115200000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp2: opp-268800000 { + opp-hz = /bits/ 64 <268800000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp3: opp-422400000 { + opp-hz = /bits/ 64 <422400000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp4: opp-576000000 { + opp-hz = /bits/ 64 <576000000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp5: opp-729600000 { + opp-hz = /bits/ 64 <729600000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp6: opp-883200000 { + opp-hz = /bits/ 64 <883200000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp7: opp-1036800000 { + opp-hz = /bits/ 64 <1036800000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp8: opp-1190400000 { + opp-hz = /bits/ 64 <1190400000>; + opp-peak-kBps = <816000>; + }; + + cl1_ch1_opp9: opp-1344000000 { + opp-hz = /bits/ 64 <1344000000>; + opp-peak-kBps = <1632000>; + }; + + cl1_ch1_opp10: opp-1497600000 { + opp-hz = /bits/ 64 <1497600000>; + opp-peak-kBps = <1632000>; + }; + + cl1_ch1_opp11: opp-1651200000 { + opp-hz = /bits/ 64 <1651200000>; + opp-peak-kBps = <2660000>; + }; + + cl1_ch1_opp12: opp-1804800000 { + opp-hz = /bits/ 64 <1804800000>; + opp-peak-kBps = <2660000>; + }; + + cl1_ch1_opp13: opp-1958400000 { + opp-hz = /bits/ 64 <1958400000>; + opp-peak-kBps = <3200000>; + }; + + cl1_ch1_opp14: opp-2112000000 { + opp-hz = /bits/ 64 <2112000000>; + opp-peak-kBps = <6400000>; + }; + + cl1_ch1_opp15: opp-2201600000 { + opp-hz = /bits/ 64 <2201600000>; + opp-peak-kBps = <6400000>; + }; + }; + + cl2_opp_tbl: opp-table-cluster2 { + compatible = "operating-points-v2"; + opp-shared; + + cl2_ch1_opp1: opp-115200000 { + opp-hz = /bits/ 64 <115200000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp2: opp-268800000 { + opp-hz = /bits/ 64 <268800000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp3: opp-422400000 { + opp-hz = /bits/ 64 <422400000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp4: opp-576000000 { + opp-hz = /bits/ 64 <576000000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp5: opp-729600000 { + opp-hz = /bits/ 64 <729600000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp6: opp-883200000 { + opp-hz = /bits/ 64 <883200000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp7: opp-1036800000 { + opp-hz = /bits/ 64 <1036800000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp8: opp-1190400000 { + opp-hz = /bits/ 64 <1190400000>; + opp-peak-kBps = <816000>; + }; + + cl2_ch1_opp9: opp-1344000000 { + opp-hz = /bits/ 64 <1344000000>; + opp-peak-kBps = <1632000>; + }; + + cl2_ch1_opp10: opp-1497600000 { + opp-hz = /bits/ 64 <1497600000>; + opp-peak-kBps = <1632000>; + }; + + cl2_ch1_opp11: opp-1651200000 { + opp-hz = /bits/ 64 <1651200000>; + opp-peak-kBps = <2660000>; + }; + + cl2_ch1_opp12: opp-1804800000 { + opp-hz = /bits/ 64 <1804800000>; + opp-peak-kBps = <2660000>; + }; + + cl2_ch1_opp13: opp-1958400000 { + opp-hz = /bits/ 64 <1958400000>; + opp-peak-kBps = <3200000>; + }; + + cl2_ch1_opp14: opp-2112000000 { + opp-hz = /bits/ 64 <2112000000>; + opp-peak-kBps = <6400000>; + }; + + cl2_ch1_opp15: opp-2201600000 { + opp-hz = /bits/ 64 <2201600000>; + opp-peak-kBps = <6400000>; + }; + }; };
Signature · 1 line
2.17.1
PATCH v3 7/11 cpufreq: tegra194: add OPP support and set bandwidth
In reply to Sumit GuptaAdd support to use OPP table from DT in Tegra194 cpufreq driver. Tegra SoC's receive the frequency lookup table (LUT) from BPMP-FW. Cross check the OPP's present in DT against the LUT from BPMP-FW and enable only those DT OPP's which are present in LUT also.
The OPP table in DT has CPU Frequency to bandwidth mapping where the bandwidth value is per MC channel. DRAM bandwidth depends on the number of MC channels which can vary as per the boot configuration. This per channel bandwidth from OPP table will be later converted by MC driver to final bandwidth value by multiplying with number of channels before sending the request to BPMP-FW.
If OPP table is not present in DT, then use the LUT from BPMP-FW directy as the CPU frequency table and not do the DRAM frequency scaling which is same as the current behavior.
Now, as the CPU Frequency table is being controlling through OPP table in DT. Keeping fewer entries in the table will create less frequency steps and can help to scale fast to high frequencies when required.
--- drivers/cpufreq/tegra194-cpufreq.c | 156 ++++++++++++++++++++++++++--- 1 file changed, 143 insertions(+), 13 deletions(-)
drivers/cpufreq/tegra194-cpufreq.c +143 -13
@@ -12,6 +12,7 @@#include <linux/of_platform.h> #include <linux/platform_device.h> #include <linux/slab.h> +#include <linux/units.h> #include <asm/smp_plat.h>
@@ -65,12 +66,36 @@ struct tegra_cpufreq_soc {struct tegra194_cpufreq_data {void __iomem *regs; -struct cpufreq_frequency_table **tables; +struct cpufreq_frequency_table **bpmp_luts;const struct tegra_cpufreq_soc *soc; +bool icc_dram_bw_scaling; };static struct workqueue_struct *read_counters_wq; +static int tegra_cpufreq_set_bw (struct cpufreq_policy *policy,unsigned long freq_khz) +{ +struct tegra194_cpufreq_data *data =cpufreq_get_driver_data (); +struct dev_pm_opp *opp; +struct device *dev; +int ret; + + dev =get_cpu_device (policy->cpu); +if (!dev) +return -ENODEV ; + + opp =dev_pm_opp_find_freq_exact (dev, freq_khz *KHZ , true); +if (IS_ERR (opp)) +return PTR_ERR (opp); + + ret =dev_pm_opp_set_opp (dev, opp); +if (ret) + data->icc_dram_bw_scaling = false; + +dev_pm_opp_put (opp); +return ret; +} +static void tegra_get_cpu_mpidr (void *mpidr) { *((u64 *)mpidr) =read_cpuid_mpidr () &MPIDR_HWID_BITMASK ;
@@ -354,7 +379,7 @@ static unsigned int tegra194_get_speed(u32 cpu)* to the last written ndiv value from freq_table. This is * done to return consistent value. */ -cpufreq_for_each_valid_entry (pos, data->tables[clusterid]) { +cpufreq_for_each_valid_entry (pos, data->bpmp_luts[clusterid]) {if (pos->driver_data != ndiv)continue ;
@@ -369,16 +394,93 @@ static unsigned int tegra194_get_speed(u32 cpu)return rate; } +int tegra_cpufreq_init_cpufreq_table (struct cpufreq_policy *policy, +struct cpufreq_frequency_table *bpmp_lut, +struct cpufreq_frequency_table **opp_table) +{ +struct tegra194_cpufreq_data *data =cpufreq_get_driver_data (); +struct cpufreq_frequency_table *freq_table =NULL ; +struct cpufreq_frequency_table *pos; +struct device *cpu_dev; +struct dev_pm_opp *opp; +unsigned long rate; +int ret, max_opps; +int j =0 ; + + cpu_dev =get_cpu_device (policy->cpu); +if (!cpu_dev) { +pr_err ("%s: failed to get cpu%d device\n" , __func__, policy->cpu); +return -ENODEV ; + } + +/* Initialize OPP table mentioned in operating-points-v2 property in DT */ + ret =dev_pm_opp_of_add_table_indexed (cpu_dev,0 ); +if (!ret) { + max_opps =dev_pm_opp_get_opp_count (cpu_dev); +if (max_opps <=0 ) { +dev_err (cpu_dev,"Failed to add OPPs\n" ); +return max_opps; + } + +/* Disable all opps and cross-validate against LUT later */ +for (rate =0 ; ; rate++) { + opp =dev_pm_opp_find_freq_ceil (cpu_dev, &rate); +if (IS_ERR (opp)) +break ; + +dev_pm_opp_put (opp); +dev_pm_opp_disable (cpu_dev, rate); + } + }else { +dev_err (cpu_dev,"Invalid or empty opp table in device tree\n" ); + data->icc_dram_bw_scaling = false; +return ret; + } + + freq_table =kcalloc ((max_opps +1 ),sizeof (*freq_table),GFP_KERNEL ); +if (!freq_table) +return -ENOMEM ; + +/* +* Cross check the frequencies from BPMP-FW LUT against the OPP's present in DT. +* Enable only those DT OPP's which are present in LUT also. +*/ +cpufreq_for_each_valid_entry (pos, bpmp_lut) { + opp =dev_pm_opp_find_freq_exact (cpu_dev, pos->frequency *KHZ , false); +if (IS_ERR (opp)) +continue ; + + ret =dev_pm_opp_enable (cpu_dev, pos->frequency *KHZ ); +if (ret <0 ) +return ret; + + freq_table[j].driver_data = pos->driver_data; + freq_table[j].frequency = pos->frequency; + j++; + } + + freq_table[j].driver_data = pos->driver_data; + freq_table[j].frequency =CPUFREQ_TABLE_END ; + + *opp_table = &freq_table[0 ]; + +dev_pm_opp_set_sharing_cpus (cpu_dev, policy->cpus); + +return ret; +} +static int tegra194_cpufreq_init (struct cpufreq_policy *policy) {struct tegra194_cpufreq_data *data =cpufreq_get_driver_data ();int maxcpus_per_cluster = data->soc->maxcpus_per_cluster; +struct cpufreq_frequency_table *freq_table; +struct cpufreq_frequency_table *bpmp_lut;u32 start_cpu, cpu;u32 clusterid; +int ret; data->soc->ops->get_cpu_cluster_id (policy->cpu,NULL , &clusterid); - -if (clusterid >= data->soc->num_clusters || !data->tables[clusterid]) +if (clusterid >= data->soc->num_clusters || !data->bpmp_luts[clusterid])return -EINVAL ; start_cpu =rounddown (policy->cpu, maxcpus_per_cluster);
@@ -387,9 +489,22 @@ static int tegra194_cpufreq_init(struct cpufreq_policy *policy)if (cpu_possible (cpu))cpumask_set_cpu (cpu, policy->cpus); } - policy->freq_table = data->tables[clusterid]; policy->cpuinfo.transition_latency =TEGRA_CPUFREQ_TRANSITION_LATENCY ; + bpmp_lut = data->bpmp_luts[clusterid]; + +if (data->icc_dram_bw_scaling) { + ret =tegra_cpufreq_init_cpufreq_table (policy, bpmp_lut, &freq_table); +if (!ret) { + policy->freq_table = freq_table; +return 0 ; + } + } + + data->icc_dram_bw_scaling = false; + policy->freq_table = bpmp_lut; +pr_info ("OPP tables missing from DT, EMC frequency scaling disabled\n" ); +return 0 ; }
@@ -406,6 +521,9 @@ static int tegra194_cpufreq_set_target(struct cpufreq_policy *policy,*/ data->soc->ops->set_cpu_ndiv (policy, (u64 )tbl->driver_data); +if (data->icc_dram_bw_scaling) +tegra_cpufreq_set_bw (policy, tbl->frequency); +return 0 ; }
@@ -439,8 +557,8 @@ static void tegra194_cpufreq_free_resources(void) }static struct cpufreq_frequency_table * -init_freq_table (struct platform_device *pdev,struct tegra_bpmp *bpmp, -unsigned int cluster_id) +tegra_cpufreq_bpmp_read_lut (struct platform_device *pdev,struct tegra_bpmp *bpmp, +unsigned int cluster_id) {struct cpufreq_frequency_table *freq_table;struct mrq_cpu_ndiv_limits_response resp;
@@ -515,6 +633,7 @@ static int tegra194_cpufreq_probe(struct platform_device *pdev)const struct tegra_cpufreq_soc *soc;struct tegra194_cpufreq_data *data;struct tegra_bpmp *bpmp; +struct device *cpu_dev;int err, i; data =devm_kzalloc (&pdev->dev,sizeof (*data),GFP_KERNEL );
@@ -530,9 +649,9 @@ static int tegra194_cpufreq_probe(struct platform_device *pdev)return -EINVAL ; } - data->tables =devm_kcalloc (&pdev->dev, data->soc->num_clusters, -sizeof (*data->tables),GFP_KERNEL ); -if (!data->tables) + data->bpmp_luts =devm_kcalloc (&pdev->dev, data->soc->num_clusters, +sizeof (*data->bpmp_luts),GFP_KERNEL ); +if (!data->bpmp_luts)return -ENOMEM ;if (soc->actmon_cntr_base) {
@@ -556,15 +675,26 @@ static int tegra194_cpufreq_probe(struct platform_device *pdev) }for (i =0 ; i < data->soc->num_clusters; i++) { - data->tables[i] =init_freq_table (pdev, bpmp, i); -if (IS_ERR (data->tables[i])) { - err =PTR_ERR (data->tables[i]); + data->bpmp_luts[i] =tegra_cpufreq_bpmp_read_lut (pdev, bpmp, i); +if (IS_ERR (data->bpmp_luts[i])) { + err =PTR_ERR (data->bpmp_luts[i]); goto err_free_res; } } tegra194_cpufreq_driver.driver_data = data; +/* Check for optional OPPv2 and interconnect paths on CPU0 to enable ICC scaling */ + cpu_dev =get_cpu_device (0 ); +if (!cpu_dev) +return -EPROBE_DEFER ; + +if (dev_pm_opp_of_get_opp_desc_node (cpu_dev)) { + err =dev_pm_opp_of_find_icc_paths (cpu_dev,NULL ); +if (!err) + data->icc_dram_bw_scaling = true; + } + err =cpufreq_register_driver (&tegra194_cpufreq_driver);if (!err) goto put_bpmp;
Signature · 1 line
2.17.1
kernel test robot
build botRe: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth
Thank you for the patch! Perhaps something to improve:
Hi Sumit,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk-mem-ctrl/for-next pci/next pci/for-linus] [cannot apply to tegra/for-next rafael-pm/linux-next linus/master v6.3-rc3 next-20230321] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230320182441.11904-8-sumitg%40nvidia.com patch subject: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230321/[email protected]/config) compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/fa31f117302fc7c15b5d9deeefb8c650554f503d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112 git checkout fa31f117302fc7c15b5d9deeefb8c650554f503d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/cpufreq/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> drivers/cpufreq/tegra194-cpufreq.c:397:5: warning: no previous prototype for 'tegra_cpufreq_init_cpufreq_table' [-Wmissing-prototypes]
397 | int tegra_cpufreq_init_cpufreq_table(struct cpufreq_policy *policy,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/tegra_cpufreq_init_cpufreq_table +397 drivers/cpufreq/tegra194-cpufreq.c
396
> 397 int tegra_cpufreq_init_cpufreq_table(struct cpufreq_policy *policy,
398 struct cpufreq_frequency_table *bpmp_lut,
399 struct cpufreq_frequency_table **opp_table)
400 {
401 struct tegra194_cpufreq_data *data = cpufreq_get_driver_data();
402 struct cpufreq_frequency_table *freq_table = NULL;
403 struct cpufreq_frequency_table *pos;
404 struct device *cpu_dev;
405 struct dev_pm_opp *opp;
406 unsigned long rate;
407 int ret, max_opps;
408 int j = 0;
409
410 cpu_dev = get_cpu_device(policy->cpu);
411 if (!cpu_dev) {
412 pr_err("%s: failed to get cpu%d device\n", __func__, policy->cpu);
413 return -ENODEV;
414 }
415
416 /* Initialize OPP table mentioned in operating-points-v2 property in DT */
417 ret = dev_pm_opp_of_add_table_indexed(cpu_dev, 0);
418 if (!ret) {
419 max_opps = dev_pm_opp_get_opp_count(cpu_dev);
420 if (max_opps <= 0) {
421 dev_err(cpu_dev, "Failed to add OPPs\n");
422 return max_opps;
423 }
424
425 /* Disable all opps and cross-validate against LUT later */
426 for (rate = 0; ; rate++) {
427 opp = dev_pm_opp_find_freq_ceil(cpu_dev, &rate);
428 if (IS_ERR(opp))
429 break;
430
431 dev_pm_opp_put(opp);
432 dev_pm_opp_disable(cpu_dev, rate);
433 }
434 } else {
435 dev_err(cpu_dev, "Invalid or empty opp table in device tree\n");
436 data->icc_dram_bw_scaling = false;
437 return ret;
438 }
439
440 freq_table = kcalloc((max_opps + 1), sizeof(*freq_table), GFP_KERNEL);
441 if (!freq_table)
442 return -ENOMEM;
443
444 /*
445 * Cross check the frequencies from BPMP-FW LUT against the OPP's present in DT.
446 * Enable only those DT OPP's which are present in LUT also.
447 */
448 cpufreq_for_each_valid_entry(pos, bpmp_lut) {
449 opp = dev_pm_opp_find_freq_exact(cpu_dev, pos->frequency * KHZ, false);
450 if (IS_ERR(opp))
451 continue;
452
453 ret = dev_pm_opp_enable(cpu_dev, pos->frequency * KHZ);
454 if (ret < 0)
455 return ret;
456
457 freq_table[j].driver_data = pos->driver_data;
458 freq_table[j].frequency = pos->frequency;
459 j++;
460 }
461
462 freq_table[j].driver_data = pos->driver_data;
463 freq_table[j].frequency = CPUFREQ_TABLE_END;
464
465 *opp_table = &freq_table[0];
466
467 dev_pm_opp_set_sharing_cpus(cpu_dev, policy->cpus);
468
469 return ret;
470 }
471
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
Re: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth
Quoted 36 lines · kernel test robot
External email: Use caution opening links or attachments
Hi Sumit,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk-mem-ctrl/for-next pci/next pci/for-linus] [cannot apply to tegra/for-next rafael-pm/linux-next linus/master v6.3-rc3 next-20230321] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230320182441.11904-8-sumitg%40nvidia.com patch subject: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230321/[email protected]/config) compiler: aarch64-linux-gcc (GCC) 12.1.0reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/fa31f117302fc7c15b5d9deeefb8c650554f503d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112 git checkoutfa31f117302fc7c15b5d9deeefb8c650554f503d
# save the config file
mkdirbuild_dir&& cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bashdrivers/cpufreq/If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Quoted 6 lines
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
drivers/cpufreq/tegra194-cpufreq.c:397:5: warning: no previous prototype for 'tegra_cpufreq_init_cpufreq_table' [-Wmissing-prototypes]397 | int tegra_cpufreq_init_cpufreq_table(struct
cpufreq_policy*policy,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thank you for the report.
Adding static to the function prototype fixes the warning.
Can we please squash the below change (or) please let me know if i need to re-send the patch.
+++ b/drivers/cpufreq/tegra194-cpufreq.c
@@ -394,7 +394,7 @@ static unsigned int tegra194_get_speed(u32 cpu)
return rate;
}
-int tegra_cpufreq_init_cpufreq_table(struct cpufreq_policy *policy, +static int tegra_cpufreq_init_cpufreq_table(
struct cpufreq_policy *policy, struct cpufreq_frequency_table *bpmp_lut, struct cpufreq_frequency_table **opp_table)
Thank you,
Sumit Gupta
Re: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth
Quoted 46 lines · Sumit Gupta
Quoted 36 lines · kernel test robot
External email: Use caution opening links or attachments
Hi Sumit,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk-mem-ctrl/for-next pci/next pci/for-linus] [cannot apply to tegra/for-next rafael-pm/linux-next linus/master v6.3-rc3 next-20230321] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230320182441.11904-8-sumitg%40nvidia.com patch subject: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230321/[email protected]/config) compiler: aarch64-linux-gcc (GCC) 12.1.0reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/fa31f117302fc7c15b5d9deeefb8c650554f503d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112 git checkoutfa31f117302fc7c15b5d9deeefb8c650554f503d
# save the config file
mkdirbuild_dir&& cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bashdrivers/cpufreq/If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/Quoted 6 lines
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
drivers/cpufreq/tegra194-cpufreq.c:397:5: warning: no previous prototype for 'tegra_cpufreq_init_cpufreq_table' [-Wmissing-prototypes]397 | int tegra_cpufreq_init_cpufreq_table(struct
cpufreq_policy*policy,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 5 lines
Thank you for the report.
Adding static to the function prototype fixes the warning. Can we please squash the below change (or) please let me know if i need to re-send the patch.
You must send new version which does not have warnings. The best if you also build test your code before sending (it's kind of obvious except that it is not).
Best regards,
Krzysztof
Re: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth
Quoted 56 lines · Krzysztof Kozlowski
External email: Use caution opening links or attachments
Quoted 46 lines · Sumit Gupta
Quoted 36 lines · kernel test robot
External email: Use caution opening links or attachments
Hi Sumit,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk-mem-ctrl/for-next pci/next pci/for-linus] [cannot apply to tegra/for-next rafael-pm/linux-next linus/master v6.3-rc3 next-20230321] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230320182441.11904-8-sumitg%40nvidia.com patch subject: [Patch v3 07/11] cpufreq: tegra194: add OPP support and set bandwidth config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230321/[email protected]/config) compiler: aarch64-linux-gcc (GCC) 12.1.0reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/fa31f117302fc7c15b5d9deeefb8c650554f503d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sumit-Gupta/firmware-tegra-add-function-to-get-BPMP-data/20230321-024112 git checkoutfa31f117302fc7c15b5d9deeefb8c650554f503d
# save the config file
mkdirbuild_dir&& cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bashdrivers/cpufreq/If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/Quoted 6 lines
All warnings (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
drivers/cpufreq/tegra194-cpufreq.c:397:5: warning: no previous prototype for 'tegra_cpufreq_init_cpufreq_table' [-Wmissing-prototypes]397 | int tegra_cpufreq_init_cpufreq_table(struct
cpufreq_policy*policy,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Quoted 5 lines
Thank you for the report.
Adding static to the function prototype fixes the warning. Can we please squash the below change (or) please let me know if i need to re-send the patch.
Quoted 7 lines
You must send new version which does not have warnings. The best if you also build test your code before sending (it's kind of obvious except that it is not).
Best regards,
Krzysztof
Sorry, missed checking with "W=1". Will take care in v4.
Thanks,
Sumit
PATCH v3 8/11 memory: tegra: make cpu cluster bw request a multiple of mc channels
In reply to Sumit GuptaMake CPU cluster's bandwidth (BW) request a multiple of MC channels. CPU OPP tables have BW info per MC channel. But, the actual BW depends on the number of MC channels which can change as per the boot config. Get the number of MC channels which are actually enabled in current boot configuration and multiply the BW request from a CPU cluster with the number of enabled MC channels. This is not required to be done for other MC clients.
--- drivers/memory/tegra/mc.c | 19 +++++++++++++++++++ drivers/memory/tegra/mc.h | 1 + drivers/memory/tegra/tegra234.c | 21 ++++++++++++++++++++- include/soc/tegra/mc.h | 1 + 4 files changed, 41 insertions(+), 1 deletion(-)
drivers/memory/tegra/mc.c +19 -0
@@ -843,6 +843,23 @@ static int tegra_mc_interconnect_setup(struct tegra_mc *mc)return err; } +static void tegra_mc_num_channel_enabled (struct tegra_mc *mc) +{ +unsigned int i; +u32 value; + + value =mc_ch_readl (mc,0 ,MC_EMEM_ADR_CFG_CHANNEL_ENABLE ); +if (value <=0 ) { + mc->num_channels = mc->soc->num_channels; +return ; + } + +for (i =0 ; i <32 ; i++) { +if (value &BIT (i)) + mc->num_channels++; + } +} +static int tegra_mc_probe (struct platform_device *pdev) {struct tegra_mc *mc;
@@ -881,6 +898,8 @@ static int tegra_mc_probe(struct platform_device *pdev)return err; } +tegra_mc_num_channel_enabled (mc); +if (mc->soc->ops && mc->soc->ops->handle_irq) { mc->irq =platform_get_irq (pdev,0 );if (mc->irq <0 )
drivers/memory/tegra/mc.h +1 -0
@@ -53,6 +53,7 @@#define MC_ERR_ROUTE_SANITY_ADR 0x9c4#define MC_ERR_GENERALIZED_CARVEOUT_STATUS 0xc00#define MC_ERR_GENERALIZED_CARVEOUT_ADR 0xc04 +#define MC_EMEM_ADR_CFG_CHANNEL_ENABLE 0xdf8#define MC_GLOBAL_INTSTATUS 0xf24#define MC_ERR_ADR_HI 0x11fc
drivers/memory/tegra/tegra234.c +20 -1
@@ -868,6 +868,25 @@ static int tegra234_mc_icc_set(struct icc_node *src, struct icc_node *dst)return ret; } +static int tegra234_mc_icc_aggregate (struct icc_node *node,u32 tag,u32 avg_bw, +u32 peak_bw,u32 *agg_avg,u32 *agg_peak) +{ +struct icc_provider *p = node->provider; +struct tegra_mc *mc =icc_provider_to_tegra_mc (p); + +if (node->id ==TEGRA_ICC_MC_CPU_CLUSTER0 || + node->id ==TEGRA_ICC_MC_CPU_CLUSTER1 || + node->id ==TEGRA_ICC_MC_CPU_CLUSTER2 ) { +if (mc) + peak_bw = peak_bw * mc->num_channels; + } + + *agg_avg += avg_bw; + *agg_peak =max (*agg_peak, peak_bw); + +return 0 ; +} +static struct icc_node *tegra234_mc_of_icc_xlate (struct of_phandle_args *spec,void *data) {
@@ -899,7 +918,7 @@ static int tegra234_mc_icc_get_init_bw(struct icc_node *node, u32 *avg, u32 *peastatic const struct tegra_mc_icc_ops tegra234_mc_icc_ops = { .xlate = tegra234_mc_of_icc_xlate, - .aggregate = icc_std_aggregate, + .aggregate = tegra234_mc_icc_aggregate, .get_bw = tegra234_mc_icc_get_init_bw, .set = tegra234_mc_icc_set, };
include/soc/tegra/mc.h +1 -0
@@ -233,6 +233,7 @@ struct tegra_mc {struct tegra_mc_timing *timings;unsigned int num_timings; +unsigned int num_channels;struct reset_controller_dev reset;
Signature · 1 line
2.17.1
PATCH v3 9/11 PCI: tegra194: add interconnect support in Tegra234
In reply to Sumit GuptaAdd support to request DRAM bandwidth with Memory Interconnect in Tegra234 SoC. The DRAM BW required for different modes depends on speed (Gen-1/2/3/4) and width/lanes (x1/x2/x4/x8).
--- drivers/pci/controller/dwc/pcie-tegra194.c | 40 +++++++++++++++++----- 1 file changed, 32 insertions(+), 8 deletions(-)
drivers/pci/controller/dwc/pcie-tegra194.c +32 -8
@@ -15,6 +15,7 @@#include <linux/gpio.h> #include <linux/gpio/consumer.h> #include <linux/interrupt.h> +#include <linux/interconnect.h> #include <linux/iopoll.h> #include <linux/kernel.h> #include <linux/module.h>
@@ -287,6 +288,7 @@ struct tegra_pcie_dw {unsigned int pex_rst_irq;int ep_state;long link_status; +struct icc_path *icc_path; };static inline struct tegra_pcie_dw *to_tegra_pcie (struct dw_pcie *pci)
@@ -309,6 +311,24 @@ struct tegra_pcie_soc {enum dw_pcie_device_mode mode; }; +static void tegra_pcie_icc_set (struct tegra_pcie_dw *pcie) +{ +struct dw_pcie *pci = &pcie->pci; +u32 val, speed, width; + + val =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ); + + speed =FIELD_GET (PCI_EXP_LNKSTA_CLS , val); + width =FIELD_GET (PCI_EXP_LNKSTA_NLW , val); + + val = width * (PCIE_SPEED2MBS_ENC (pcie_link_speed[speed]) /BITS_PER_BYTE ); + +if (icc_set_bw (pcie->icc_path,MBps_to_icc (val),0 )) +dev_err (pcie->dev,"can't set bw[%u]\n" , val); + +clk_set_rate (pcie->core_clk, pcie_gen_freq[speed -1 ]); +} +static void apply_bad_link_workaround (struct dw_pcie_rp *pp) {struct dw_pcie *pci =to_dw_pcie_from_pp (pp);
@@ -452,14 +472,12 @@ static irqreturn_t tegra_pcie_ep_irq_thread(int irq, void *arg)struct tegra_pcie_dw *pcie = arg;struct dw_pcie_ep *ep = &pcie->pci.ep;struct dw_pcie *pci = &pcie->pci; -u32 val, speed; +u32 val;if (test_and_clear_bit (0 , &pcie->link_status))dw_pcie_ep_linkup (ep); - speed =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ) & -PCI_EXP_LNKSTA_CLS ; -clk_set_rate (pcie->core_clk, pcie_gen_freq[speed -1 ]); +tegra_pcie_icc_set (pcie);if (pcie->of_data->has_ltr_req_fix)return IRQ_HANDLED ;
@@ -945,9 +963,9 @@ static int tegra_pcie_dw_host_init(struct dw_pcie_rp *pp)static int tegra_pcie_dw_start_link (struct dw_pcie *pci) { -u32 val, offset, speed, tmp;struct tegra_pcie_dw *pcie =to_tegra_pcie (pci);struct dw_pcie_rp *pp = &pci->pp; +u32 val, offset, tmp;bool retry = true;if (pcie->of_data->mode ==DW_PCIE_EP_TYPE ) {
@@ -1018,9 +1036,7 @@ static int tegra_pcie_dw_start_link(struct dw_pcie *pci) goto retry_link; } - speed =dw_pcie_readw_dbi (pci, pcie->pcie_cap_base +PCI_EXP_LNKSTA ) & -PCI_EXP_LNKSTA_CLS ; -clk_set_rate (pcie->core_clk, pcie_gen_freq[speed -1 ]); +tegra_pcie_icc_set (pcie);tegra_pcie_enable_interrupts (pp);
@@ -2224,6 +2240,14 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)platform_set_drvdata (pdev, pcie); + pcie->icc_path =devm_of_icc_get (&pdev->dev,"write" ); + ret =PTR_ERR_OR_ZERO (pcie->icc_path); +if (ret) { +tegra_bpmp_put (pcie->bpmp); +dev_err_probe (&pdev->dev, ret,"failed to get write interconnect\n" ); +return ret; + } +switch (pcie->of_data->mode) {case DW_PCIE_RC_TYPE : ret = devm_request_irq(dev, pp->irq, tegra_pcie_rp_irq_handler,
Signature · 1 line
2.17.1
PATCH v3 10/11 memory: tegra: handle no BWMGR MRQ support in BPMP
In reply to Sumit GuptaIf BPMP-FW doesn't support 'MRQ_BWMGR_INT', then the MC Client driver probe fails with 'EPROBE_DEFER' which it receives on calling the func 'devm_of_icc_get()'. Fix this by initializing the ICC even if the MRQ is missing and return 'EINVAL' from 'icc_set_bw()' instead of passing the request to BPMP-FW later when the BW request is made by client.
--- drivers/memory/tegra/tegra186-emc.c | 13 +++++++------ drivers/memory/tegra/tegra234.c | 6 ++++++ include/soc/tegra/mc.h | 2 +- 3 files changed, 14 insertions(+), 7 deletions(-)
drivers/memory/tegra/tegra186-emc.c +7 -6
@@ -343,13 +343,14 @@ static int tegra186_emc_probe(struct platform_device *pdev) mc =dev_get_drvdata (emc->dev->parent);if (mc && mc->soc->icc_ops) { -if (tegra_bpmp_mrq_is_supported (emc->bpmp,MRQ_BWMGR_INT )) { - err =tegra_emc_interconnect_init (emc); -if (err) - goto put_bpmp; - }else { + err =tegra_emc_interconnect_init (emc); +if (err) + goto put_bpmp; + +if (tegra_bpmp_mrq_is_supported (emc->bpmp,MRQ_BWMGR_INT )) + mc->bwmgr_mrq_supported = true; +else dev_info (&pdev->dev,"MRQ_BWMGR_INT not present\n" ); - } }return 0 ;
drivers/memory/tegra/tegra234.c +6 -0
@@ -828,6 +828,9 @@ static int tegra234_mc_icc_set(struct icc_node *src, struct icc_node *dst)if (src->id == dst->id)return 0 ; +if (!mc->bwmgr_mrq_supported) +return -EINVAL ; + bpmp =of_tegra_bpmp_get ();if (IS_ERR (bpmp)) { ret =PTR_ERR (bpmp);
@@ -874,6 +877,9 @@ static int tegra234_mc_icc_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,struct icc_provider *p = node->provider;struct tegra_mc *mc =icc_provider_to_tegra_mc (p); +if (!mc->bwmgr_mrq_supported) +return -EINVAL ; +if (node->id ==TEGRA_ICC_MC_CPU_CLUSTER0 || node->id ==TEGRA_ICC_MC_CPU_CLUSTER1 || node->id ==TEGRA_ICC_MC_CPU_CLUSTER2 ) {
include/soc/tegra/mc.h +1 -1
@@ -234,7 +234,7 @@ struct tegra_mc {struct tegra_mc_timing *timings;unsigned int num_timings;unsigned int num_channels; - +bool bwmgr_mrq_supported;struct reset_controller_dev reset;struct icc_provider provider;
Signature · 1 line
2.17.1
Re: [Patch v3 10/11] memory: tegra: handle no BWMGR MRQ support in BPMP
Quoted 7 lines · Sumit Gupta
If BPMP-FW doesn't support '
MRQ_BWMGR_INT', then the MC Client driver probe fails with 'EPROBE_DEFER' which it receives on calling the func 'devm_of_icc_get()'. Fix this by initializing the ICC even if the MRQ is missing and return 'EINVAL' from 'icc_set_bw()' instead of passing the request to BPMP-FW later when the BW request is made by client.Fixes ("memory: tegra: add interconnect support for DRAM scaling in Tegra234")
That's not correct tag.
Anyway, send fixes separately.
Best regards,
Krzysztof
Re: [Patch v3 10/11] memory: tegra: handle no BWMGR MRQ support in BPMP
Quoted 7 lines · Krzysztof Kozlowski
Quoted 6 lines · Sumit Gupta
If BPMP-FW doesn't support '
MRQ_BWMGR_INT', then the MC Client driver probe fails with 'EPROBE_DEFER' which it receives on calling the func 'devm_of_icc_get()'. Fix this by initializing the ICC even if the MRQ is missing and return 'EINVAL' from 'icc_set_bw()' instead of passing the request to BPMP-FW later when the BW request is made by client.
Quoted 5 lines
Quoted 1 line
Fixes ("memory: tegra: add interconnect support for DRAM scaling in Tegra234")That's not correct tag.
Anyway, send fixes separately.
I think this was a bit confusing. This fixes an issue that was introduced in a patch earlier in this series, so it's probably better to squash it into that patch rather than have a separate fix patch in the same series.
Thierry
Re: [Patch v3 10/11] memory: tegra: handle no BWMGR MRQ support in BPMP
Quoted 10 lines · Thierry Reding
Quoted 9 lines · Krzysztof Kozlowski
Quoted 7 lines · Sumit Gupta
If BPMP-FW doesn't support '
MRQ_BWMGR_INT', then the MC Client driver probe fails with 'EPROBE_DEFER' which it receives on calling the func 'devm_of_icc_get()'. Fix this by initializing the ICC even if the MRQ is missing and return 'EINVAL' from 'icc_set_bw()' instead of passing the request to BPMP-FW later when the BW request is made by client.Fixes ("memory: tegra: add interconnect support for DRAM scaling in Tegra234")
Quoted 9 lines
Quoted 3 lines
That's not correct tag.
Anyway, send fixes separately.
I think this was a bit confusing. This fixes an issue that was introduced in a patch earlier in this series, so it's probably better to squash it into that patch rather than have a separate fix patch in the same series.
Yeah, it is quite confusing to send buggy code and immediately fix it... Introducing known bugs is actually non-bisectable and harming.
Best regards,
Krzysztof
Re: [Patch v3 10/11] memory: tegra: handle no BWMGR MRQ support in BPMP
Quoted 15 lines · Krzysztof Kozlowski
Quoted 14 lines · Thierry Reding
Quoted 12 lines · Krzysztof Kozlowski
Quoted 7 lines · Sumit Gupta
If BPMP-FW doesn't support '
MRQ_BWMGR_INT', then the MC Client driver probe fails with 'EPROBE_DEFER' which it receives on calling the func 'devm_of_icc_get()'. Fix this by initializing the ICC even if the MRQ is missing and return 'EINVAL' from 'icc_set_bw()' instead of passing the request to BPMP-FW later when the BW request is made by client.Fixes ("memory: tegra: add interconnect support for DRAM scaling in Tegra234")That's not correct tag.
Anyway, send fixes separately.
Quoted 8 lines
Quoted 5 lines
I think this was a bit confusing. This fixes an issue that was introduced in a patch earlier in this series, so it's probably better to squash it into that patch rather than have a separate fix patch in the same series.
Yeah, it is quite confusing to send buggy code and immediately fix it... Introducing known bugs is actually non-bisectable and harming.
I don't think this was done purposefully but rather as a way of more clearly showing what was changed. This is also an issue that can only happen on certain boards, so it's easy to miss.
But yeah, this is bad for bisectibility.
Sumit, please merge this into the patch that you reference in the Fixes:
tag along with the fix in patch 11.
Thierry
Re: [Patch v3 10/11] memory: tegra: handle no BWMGR MRQ support in BPMP
Quoted 29 lines · Thierry Reding
Quoted 15 lines · Krzysztof Kozlowski
Quoted 14 lines · Thierry Reding
Quoted 12 lines · Krzysztof Kozlowski
Quoted 7 lines · Sumit Gupta
If BPMP-FW doesn't support '
MRQ_BWMGR_INT', then the MC Client driver probe fails with 'EPROBE_DEFER' which it receives on calling the func 'devm_of_icc_get()'. Fix this by initializing the ICC even if the MRQ is missing and return 'EINVAL' from 'icc_set_bw()' instead of passing the request to BPMP-FW later when the BW request is made by client.Fixes ("memory: tegra: add interconnect support for DRAM scaling in Tegra234")That's not correct tag.
Anyway, send fixes separately.
Quoted 8 lines
Quoted 5 lines
I think this was a bit confusing. This fixes an issue that was introduced in a patch earlier in this series, so it's probably better to squash it into that patch rather than have a separate fix patch in the same series.
Yeah, it is quite confusing to send buggy code and immediately fix it... Introducing known bugs is actually non-bisectable and harming.
I don't think this was done purposefully but rather as a way of more clearly showing what was changed. This is also an issue that can only happen on certain boards, so it's easy to miss.
Quoted 6 lines
But yeah, this is bad for bisectibility.
Sumit, please merge this into the patch that you reference in the Fixes:
tag along with the fix in patch 11.Thierry
Sure, I will merge this change in parent patch and send v4.
Thanks,
Sumit
PATCH v3 11/11 memory: tegra186-emc: fix interconnect registration race
In reply to Sumit GuptaThe current interconnect provider registration interface is inherently racy as nodes are not added until the after adding the provider. This can specifically cause racing DT lookups to fail.
Switch to using the new API where the provider is not registered until after it has been fully initialised.
--- drivers/memory/tegra/tegra186-emc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/memory/tegra/tegra186-emc.c +6 -6
@@ -207,15 +207,13 @@ static int tegra_emc_interconnect_init(struct tegra186_emc *emc) emc->provider.xlate = tegra_emc_of_icc_xlate; emc->provider.get_bw = tegra_emc_icc_get_init_bw; - err =icc_provider_add (&emc->provider); -if (err) - goto err_msg; +icc_provider_init (&emc->provider);/* create External Memory Controller node */ node =icc_node_create (TEGRA_ICC_EMC );if (IS_ERR (node)) { err =PTR_ERR (node); - goto del_provider; + goto err_msg; } node->name ="External Memory Controller" ;
@@ -236,11 +234,13 @@ static int tegra_emc_interconnect_init(struct tegra186_emc *emc) node->name ="External Memory (DRAM)" ;icc_node_add (node, &emc->provider); + err =icc_provider_register (&emc->provider); +if (err) + goto remove_nodes; +return 0 ; remove_nodes:icc_nodes_remove (&emc->provider); -del_provider: -icc_provider_del (&emc->provider); err_msg:dev_err (emc->dev,"failed to initialize ICC: %d\n" , err);
Signature · 1 line
2.17.1
Re: [Patch v3 11/11] memory: tegra186-emc: fix interconnect registration race
Quoted 8 lines · Sumit Gupta
The current interconnect provider registration interface is inherently racy as nodes are not added until the after adding the provider. This can specifically cause racing DT lookups to fail.
Switch to using the new API where the provider is not registered until after it has been fully initialised.
Fixes ("memory: tegra: add interconnect support for DRAM scaling in Tegra234")
Same problem and also send it separately.
Best regards,
Krzysztof