Skip to contentSkip to conversation

drm/vmwgfx: remove unused vmw_overlay function

PATCH In review Tom Rix 3 participants 3 messages Mar 21, 2023 – Apr 11, 2023

Subsystems (3)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 drm/vmwgfx: remove unused vmw_overlay function

clang with W=1 reports drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:56:35: error:
unused function 'vmw_overlay' [-Werror,-Wunused-function]
static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev)

                                  ^

This function is not used, so remove it.

---
 drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c +0 -6
index 8d171d71cb8a..7e112319a23c 100644
@@ -53,12 +53,6 @@ struct vmw_overlay {
 	struct vmw_stream stream[VMW_MAX_NUM_STREAMS];
 };
 
-static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev)
-{
-	struct vmw_private *dev_priv = vmw_priv(dev);
-	return dev_priv ? dev_priv->overlay_priv : NULL;
-}
-
 struct vmw_escape_header {
 	uint32_t cmd;
 	SVGAFifoCmdEscape body;
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Tom Rix

clang with W=1 reports drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:56:35: error:
unused function 'vmw_overlay' [-Werror,-Wunused-function]
static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev)

                                  ^

This function is not used, so remove it.

Thanks for the patch!

Quoted 24 lines
---
 drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c +0 -7
index 8d171d71cb8a..7e112319a23c 100644
@@ -53,12 +53,6 @@ struct vmw_overlay {
        struct vmw_stream stream[VMW_MAX_NUM_STREAMS];
 };
 
-static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev)
-{
-       struct vmw_private *dev_priv = vmw_priv(dev);
-       return dev_priv ? dev_priv->overlay_priv : NULL;
-}
-
 struct vmw_escape_header {
        uint32_t cmd;
        SVGAFifoCmdEscape body;
--

2.27.0

Signature · 2 lines
Thanks,
~Nick Desaulniers
#2 lore raw
In reply to Tom Rix
Quoted 8 lines · Tom Rix

clang with W=1 reports drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:56:35: error:
  unused function 'vmw_overlay' [-Werror,-Wunused-function] static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev) ^
This function is not used, so remove it.

Thank you for the patch. I went ahead and pushed it to the drm-misc-next branch in drm-misc tree.

z