Skip to contentSkip to conversation

loongarch: drop ranges for definition of ARCH_FORCE_MAX_ORDER

PATCH Applied Mike Rapoport 3 participants 3 messages Mar 22, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 loongarch: drop ranges for definition of ARCH_FORCE_MAX_ORDER

From: "Mike Rapoport (IBM)" <[email protected]>

LoongArch defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER up to 63, which implies maximal contiguous allocation size of 2^63 pages.

Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a simple integer with sensible defaults.

Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER will be able to do so but they won't be mislead by the bogus ranges.

---

This applies to akpm/mm-unstable tree

 arch/loongarch/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
arch/loongarch/Kconfig +0 -3
index 272a3a12c98d..e1e3a3828962 100644
@@ -420,11 +420,8 @@ config NODES_SHIFT
 
 config ARCH_FORCE_MAX_ORDER
 	int "Maximum zone order"
-	range 13 63 if PAGE_SIZE_64KB
 	default "13" if PAGE_SIZE_64KB
-	range 11 63 if PAGE_SIZE_16KB
 	default "11" if PAGE_SIZE_16KB
-	range 10 63
 	default "10"
 	help
 	  The kernel memory allocator divides physically contiguous memory
Signature · 1 line
2.35.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Mike Rapoport

From: "Mike Rapoport (IBM)" <[email protected]>

LoongArch defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER up to 63, which implies maximal contiguous allocation size of 2^63 pages.

Quoted 7 lines

Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a simple integer with sensible defaults.

Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER will be able to do so but they won't be mislead by the bogus ranges.

Signature · 1 line
  Kiryl Shutsemau / Kirill A. Shutemov
Reviewed-by on v1 1/1
#2 lore raw
In reply to Mike Rapoport
Quoted 26 lines · Mike Rapoport

From: "Mike Rapoport (IBM)" <[email protected]>

LoongArch defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER up to 63, which implies maximal contiguous allocation size of 2^63 pages.

Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a simple integer with sensible defaults.

Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER will be able to do so but they won't be mislead by the bogus ranges.

---

This applies to akpm/mm-unstable tree

  arch/loongarch/Kconfig | 3 ---
  1 file changed, 3 deletions(-)
arch/loongarch/Kconfig +0 -0
index 272a3a12c98d..e1e3a3828962 100644
@@ -420,11 +420,8 @@ config NODES_SHIFT
 

arch/loongarch/Kconfig config NODES_SHIFT · line 427

Quoted 10 lines
arch/loongarch/Kconfig +0 -3
  config ARCH_FORCE_MAX_ORDER
  	int "Maximum zone order"
-	range 13 63 if PAGE_SIZE_64KB
  	default "13" if PAGE_SIZE_64KB
-	range 11 63 if PAGE_SIZE_16KB
  	default "11" if PAGE_SIZE_16KB
-	range 10 63
  	default "10"
  	help
  	  The kernel memory allocator divides physically contiguous memory
Signature · 3 lines
Thanks,

David / dhildenb