RDMA/usnic: Remove redundant pci_clear_master
Subsystems (2)
PATCH 1/1 RDMA/usnic: Remove redundant pci_clear_master
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device, like this:./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by Cai Huoqing <[email protected]>
--- drivers/infiniband/hw/usnic/usnic_ib_main.c | 2 -- 1 file changed, 2 deletions(-)
drivers/infiniband/hw/usnic/usnic_ib_main.c +0 -2
@@ -602,7 +602,6 @@ static int usnic_ib_pci_probe(struct pci_dev *pdev,usnic_vnic_free (vf->vnic); out_release_regions:pci_set_drvdata (pdev,NULL ); -pci_clear_master (pdev);pci_release_regions (pdev); out_disable_device:pci_disable_device (pdev);
@@ -623,7 +622,6 @@ static void usnic_ib_pci_remove(struct pci_dev *pdev)kref_put (&pf->vf_cnt, usnic_ib_undiscover_pf);usnic_vnic_free (vf->vnic);pci_set_drvdata (pdev,NULL ); -pci_clear_master (pdev);pci_release_regions (pdev);pci_disable_device (pdev);kfree (vf);
Signature · 1 line
2.34.1
Leon Romanovsky
AppliedQuoted 9 lines · Cai Huoqing
Remove
pci_clear_masterto simplify the code,
the bus-mastering is also cleared indo_pci_disable_device, like this:./drivers/pci/pci.c:2197
static voiddo_pci_disable_device(struct pci_dev *dev){ u16 pci_command;[...]
Applied, thanks!
[1/1] RDMA/usnic: Remove redundant pci_clear_master
https://git.kernel.org/rdma/rdma/c/fc36ce35e94585
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>