Skip to contentSkip to conversation

Sparse checks does not include other headers in include

LTP Petr Vorel 2 participants 3 messages Mar 24, 2023 – Mar 28, 2023

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

Hi Richie,

cd lib && make check-tst_device

...
tst_device.c:78:5: warning: Symbol 'tst_find_free_loopdev' has no prototype or library ('tst_') prefix. Should it be static? tst_find_free_loopdev() is in include/tst_device.h. Could sparse-ltp.c take into
consideration all files in include/ (if is trivial to do that)?

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi!

Quoted 6 lines

cd lib && make check-tst_device

...
tst_device.c:78:5: warning: Symbol 'tst_find_free_loopdev' has no prototype or library ('tst_') prefix. Should it be static? tst_find_free_loopdev() is in include/tst_device.h. Could sparse-ltp.c take into
consideration all files in include/ (if is trivial to do that)?

This is actually a geniune error, the tst_device.c does not include tst_device.h. I will send a patchset to fix the issues.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#2 lore raw

Hi Cyril,

Quoted 2 lines

This is actually a geniune error, the tst_device.c does not include tst_device.h. I will send a patchset to fix the issues.

Ah, I should pay attention to the warnings :). I guess you can merge the fix directly (simple enough).

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp