Correct gpio-ir-recv wakeup capability
Subsystems (3)
cover Correct gpio-ir-recv wakeup capability
This small patch series fixes the gpio-ir-recv binding and driver to first indicate that it can be a wake-up source for the system, and second actually make that happen.
Florian Fainelli (2):
dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property
media: rc: gpio-ir-recv: Fix support for wake-up
Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml | 3 +++ drivers/media/rc/gpio-ir-recv.c | 2 ++ 2 files changed, 5 insertions(+)
Signature · 1 line
2.34.1
PATCH 1/2 dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property
The GPIO IR receiver can be used as a wake-up source for the system, document that.
--- Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml +3 -0
@@ -23,6 +23,9 @@ properties: description: autosuspend delay time in milliseconds $ref: /schemas/types.yaml#/definitions/uint32 + wakeup-source: + description: IR receiver can wake-up the system. + required: - compatible - gpios
Signature · 1 line
2.34.1
Rob Herring
maintainerRe: [PATCH 1/2] dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property
Quoted 8 lines · Florian Fainelli
The GPIO IR receiver can be used as a wake-up source for the system, document that.
Signed-off-by Florian Fainelli <[email protected]>--- Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml | 3 +++ 1 file changed, 3 insertions(+)
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:./Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml:27:6: [warning] wrong indentation: expected 4 but found 5 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
PATCH 2/2 media: rc: gpio-ir-recv: Fix support for wake-up
In reply to Florian FainelliThe driver was intended from the start to be a wake-up source for the system, however due to the absence of a suitable call to device_set_wakeup_capable(), the device_may_wakeup() call used to decide whether to enable the GPIO interrupt as a wake-up source would never happen. Lookup the DT standard "wakeup-source" property and call device_init_wakeup() to ensure the device is flagged as being wakeup capable.
--- drivers/media/rc/gpio-ir-recv.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/media/rc/gpio-ir-recv.c +2 -0
@@ -103,6 +103,8 @@ static int gpio_ir_recv_probe(struct platform_device *pdev) rcdev->map_name =RC_MAP_EMPTY ; gpio_dev->rcdev = rcdev; +if (of_property_read_bool (np,"wakeup-source" )) +device_init_wakeup (dev, true); rc =devm_rc_register_device (dev, rcdev);if (rc <0 ) {
Signature · 1 line
2.34.1