Skip to contentSkip to conversation

ksmbd: remove unused is_char_allowed function

PATCH In review Tom Rix 3 participants 3 messages Mar 24, 2023 – Mar 25, 2023

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 ksmbd: remove unused is_char_allowed function

clang with W=1 reports
fs/ksmbd/unicode.c:122:19: error: unused function
'is_char_allowed' [-Werror,-Wunused-function]
static inline int is_char_allowed(char *ch)

                  ^

This function is not used so remove it.

---
 fs/ksmbd/unicode.c | 18 ------------------
 1 file changed, 18 deletions(-)
fs/ksmbd/unicode.c +0 -18
index a0db699ddafd..9ae676906ed3 100644
@@ -113,24 +113,6 @@ cifs_mapchar(char *target, const __u16 src_char, const struct nls_table *cp,
 	goto out;
 }
 
-/*
- * is_char_allowed() - check for valid character
- * @ch:		input character to be checked
- *
- * Return:	1 if char is allowed, otherwise 0
- */
-static inline int is_char_allowed(char *ch)
-{
-	/* check for control chars, wildcards etc. */
-	if (!(*ch & 0x80) &&
-	    (*ch <= 0x1f ||
-	     *ch == '?' || *ch == '"' || *ch == '<' ||
-	     *ch == '>' || *ch == '|'))
-		return 0;
-
-	return 1;
-}
-
 /*
  * smb_from_utf16() - convert utf16le string to local charset
  * @to:		destination buffer
Signature · 1 line
2.27.0