drm/amd/display: remove unused matching_stream_ptrs variable
Subsystems (3)
PATCH 1/1 drm/amd/display: remove unused matching_stream_ptrs variable
clang with W=1 reports drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:625:6: error:
variable 'matching_stream_ptrs' set but not used [-Werror,-Wunused-but-set-variable]
int matching_stream_ptrs = 0;
^This variable is not used so remove it.
--- drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c +1 -4
@@ -622,7 +622,6 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)int i, j;uint8_t valid_count =0 ;uint8_t dig_stream_count =0 ; -int matching_stream_ptrs =0 ;int eng_ids_per_ep_id[MAX_PIPES ] = {0 };int ep_ids_per_eng_id[MAX_PIPES ] = {0 };int valid_bitmap =0 ;
@@ -645,9 +644,7 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)struct link_enc_assignment assignment = state->res_ctx.link_enc_cfg_ctx.link_enc_assignments[i];if (assignment.valid) { -if (assignment.stream == state->streams[i]) - matching_stream_ptrs++; -else +if (assignment.stream != state->streams[i]) valid_stream_ptrs = false; } }
Signature · 1 line
2.27.0
Jimmy, can you review?
The change LGTM; but I'm not sure if there was something else intended here.
Quoted 39 lines · Tom Rix
clang with W=1 reports
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:625:6: error:
variable 'matching_stream_ptrs' set but not used [-Werror,-Wunused-but-set-variable]int matching_stream_ptrs = 0; ^This variable is not used so remove it.
Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c +1
-5@@ -622,7 +622,6 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)int i, j;uint8_t valid_count =0 ;uint8_t dig_stream_count =0 ; -int matching_stream_ptrs =0 ;int eng_ids_per_ep_id[MAX_PIPES ] = {0 };int ep_ids_per_eng_id[MAX_PIPES ] = {0 };int valid_bitmap =0 ;@@ -645,9 +644,7 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)struct link_enc_assignment assignment = state->res_ctx.link_enc_cfg_ctx.link_enc_assignments[i];if (assignment.valid) { -if (assignment.stream == state->streams[i]) - matching_stream_ptrs++; -else +if (assignment.stream != state->streams[i]) valid_stream_ptrs = false; } } --2.27.0
Signature · 2 lines
Thanks, ~Nick Desaulniers
Nick Desaulniers
Reviewed-byQuoted 4 lines · Nick Desaulniers
Jimmy, can you review?
The change LGTM; but I'm not sure if there was something else intended here.
Nevermind, Jimmy's email address bounced.
Quoted 46 lines · Tom Rix
Quoted 37 lines
clang with W=1 reports
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:625:6: error:
variable 'matching_stream_ptrs' set but not used [-Werror,-Wunused-but-set-variable]int matching_stream_ptrs = 0; ^This variable is not used so remove it.
Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c +1
-5@@ -622,7 +622,6 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)int i, j;uint8_t valid_count =0 ;uint8_t dig_stream_count =0 ; -int matching_stream_ptrs =0 ;int eng_ids_per_ep_id[MAX_PIPES ] = {0 };int ep_ids_per_eng_id[MAX_PIPES ] = {0 };int valid_bitmap =0 ;@@ -645,9 +644,7 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)struct link_enc_assignment assignment = state->res_ctx.link_enc_cfg_ctx.link_enc_assignments[i];if (assignment.valid) { -if (assignment.stream == state->streams[i]) - matching_stream_ptrs++; -else +if (assignment.stream != state->streams[i]) valid_stream_ptrs = false; } } --Quoted 2 lines
2.27.0
--
Thanks,
~Nick Desaulniers
Signature · 2 lines
Thanks, ~Nick Desaulniers
Hamza Mahfooz
AppliedQuoted 8 lines · Tom Rix
clang with W=1 reports
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:625:6: error:variable 'matching_stream_ptrs' set but not used [-Werror,-Wunused-but-set-variable] int matching_stream_ptrs = 0; ^This variable is not used so remove it.
Signed-off-by Tom Rix <[email protected]>
Applied, thanks!
Quoted 27 lines
--- drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c +1
-4@@ -622,7 +622,6 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)int i, j;uint8_t valid_count =0 ;uint8_t dig_stream_count =0 ; -int matching_stream_ptrs =0 ;int eng_ids_per_ep_id[MAX_PIPES ] = {0 };int ep_ids_per_eng_id[MAX_PIPES ] = {0 };int valid_bitmap =0 ;@@ -645,9 +644,7 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)struct link_enc_assignment assignment = state->res_ctx.link_enc_cfg_ctx.link_enc_assignments[i];if (assignment.valid) { -if (assignment.stream == state->streams[i]) - matching_stream_ptrs++; -else +if (assignment.stream != state->streams[i]) valid_stream_ptrs = false; } }
Signature · 1 line
Hamza