RDMA/bnxt_re: remove unused num_srqne_processed and num_cqne_processed variables
Subsystems (2)
PATCH 1/1 RDMA/bnxt_re: remove unused num_srqne_processed and num_cqne_processed variables
clang with W=1 reports drivers/infiniband/hw/bnxt_re/qplib_fp.c:303:6: error: variable
'num_srqne_processed' set but not used [-Werror,-Wunused-but-set-variable]
int num_srqne_processed = 0;
^
drivers/infiniband/hw/bnxt_re/qplib_fp.c:304:6: error: variable
'num_cqne_processed' set but not used [-Werror,-Wunused-but-set-variable]
int num_cqne_processed = 0;
^These variables are not used so remove them.
--- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)
drivers/infiniband/hw/bnxt_re/qplib_fp.c +4 -10
@@ -300,8 +300,6 @@ static void bnxt_qplib_service_nq(struct tasklet_struct *t) {struct bnxt_qplib_nq *nq =from_tasklet (nq, t, nq_tasklet);struct bnxt_qplib_hwq *hwq = &nq->hwq; -int num_srqne_processed =0 ; -int num_cqne_processed =0 ;struct bnxt_qplib_cq *cq;int budget = nq->budget;u32 sw_cons, raw_cons;
@@ -340,9 +338,7 @@ static void bnxt_qplib_service_nq(struct tasklet_struct *t) DBC_DBC_TYPE_CQ_ARMENA);spin_lock_bh (&cq->compl_lock);atomic_set (&cq->arm_state,0 ); -if (!nq->cqn_handler (nq, (cq))) - num_cqne_processed++; -else +if (nq->cqn_handler (nq, (cq)))dev_warn (&nq->pdev->dev,"cqn - type 0x%x not handled\n" , type); cq->cnq_events++;
@@ -361,11 +357,9 @@ static void bnxt_qplib_service_nq(struct tasklet_struct *t) srq = (struct bnxt_qplib_srq *)q_handle;bnxt_qplib_armen_db (&srq->dbinfo,DBC_DBC_TYPE_SRQ_ARMENA ); -if (!nq->srqn_handler (nq, - (struct bnxt_qplib_srq *)q_handle, - nqsrqe->event)) - num_srqne_processed++; -else +if (nq->srqn_handler (nq, + (struct bnxt_qplib_srq *)q_handle, + nqsrqe->event))dev_warn (&nq->pdev->dev,"SRQ event 0x%x not handled\n" , nqsrqe->event);
Signature · 1 line
2.27.0
Quoted 10 lines · Tom Rix
clang with W=1 reports
drivers/infiniband/hw/bnxt_re/qplib_fp.c:303:6: error: variable
'num_srqne_processed' set but not used [-Werror,-Wunused-but-set-variable]int num_srqne_processed = 0; ^ drivers/infiniband/hw/bnxt_re/qplib_fp.c:304:6: error: variable 'num_cqne_processed' set but not used [-Werror,-Wunused-but-set-variable] int num_cqne_processed = 0; ^
Quoted 3 lines
These variables are not used so remove them.
Signed-off-by Tom Rix <[email protected]>
Leon Romanovsky
AppliedQuoted 9 lines · Tom Rix
clang with W=1 reports
drivers/infiniband/hw/bnxt_re/qplib_fp.c:303:6: error: variable
'num_srqne_processed' set but not used [-Werror,-Wunused-but-set-variable]int num_srqne_processed = 0; ^ drivers/infiniband/hw/bnxt_re/qplib_fp.c:304:6: error: variable 'num_cqne_processed' set but not used [-Werror,-Wunused-but-set-variable] int num_cqne_processed = 0; ^
Quoted 3 lines
These variables are not used so remove them.
[...]
Applied, thanks!
[1/1] RDMA/bnxt_re: remove unused num_srqne_processed and num_cqne_processed variables
https://git.kernel.org/rdma/rdma/c/1b69f1e3d7449d
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>