scsi: scsi_transport_fc: remove unused desc_cnt variable
PATCH 1/1 scsi: scsi_transport_fc: remove unused desc_cnt variable
clang with W=1 reports drivers/scsi/scsi_transport_fc.c:908:6: error: variable
'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]
u32 desc_cnt = 0, bytes_remain;
^This variable is not used so remove it.
--- drivers/scsi/scsi_transport_fc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/scsi_transport_fc.c +1 -2
@@ -905,7 +905,7 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf, {struct fc_els_fpin *fpin = (struct fc_els_fpin *)fpin_buf;struct fc_tlv_desc *tlv; -u32 desc_cnt =0 , bytes_remain; +u32 bytes_remain;u32 dtag;enum fc_host_event_code event_code = event_acknowledge ?FCH_EVT_LINK_FPIN_ACK :FCH_EVT_LINK_FPIN ;
@@ -932,7 +932,6 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf,fc_fpin_congn_stats_update (shost, tlv); } - desc_cnt++; bytes_remain -=FC_TLV_DESC_SZ_FROM_LENGTH (tlv); tlv =fc_tlv_next_desc (tlv); }
Signature · 1 line
2.27.0
Quoted 40 lines · Tom Rix
clang with W=1 reports
drivers/scsi/scsi_transport_fc.c:908:6: error: variable
'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]u32 desc_cnt = 0, bytes_remain; ^This variable is not used so remove it.
Signed-off-by Tom Rix <[email protected]>---
drivers/scsi/scsi_transport_fc.c| 3 +--1 file changed, 1 insertion(+), 2 deletions(-)drivers/scsi/scsi_transport_fc.c +1
-1@@ -905,7 +905,7 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf, {struct fc_els_fpin *fpin = (struct fc_els_fpin *)fpin_buf;struct fc_tlv_desc *tlv; -u32 desc_cnt =0 , bytes_remain; +u32 bytes_remain;u32 dtag;enum
fc_host_event_codeevent_code=event_acknowledge?FCH_EVT_LINK_FPIN_ACK:FCH_EVT_LINK_FPIN;drivers/scsi/scsi_transport_fc.c +0
-1@@ -932,7 +932,6 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf,fc_fpin_congn_stats_update (shost, tlv); } - desc_cnt++; bytes_remain -=FC_TLV_DESC_SZ_FROM_LENGTH (tlv); tlv =fc_tlv_next_desc (tlv); }Signature · 1 line
2.27.0
Signature · 1 line
Himanshu Madhani Oracle Linux Engineering
Quoted 12 lines · Tom Rix
clang with W=1 reports
drivers/scsi/scsi_transport_fc.c:908:6: error: variable
'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]u32 desc_cnt = 0, bytes_remain; ^This variable is not used so remove it.
Signed-off-by Tom Rix <[email protected]>--- drivers/scsi/scsi_transport_fc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Looks good to me.
Signature · 4 lines
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vors. Aufs.-R.: Gregor Pillen / Geschäftsführung: David Faller Sitz der Ges.: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
Martin K. Petersen
AppliedTom,
Quoted 6 lines
clang with W=1 reports
drivers/scsi/scsi_transport_fc.c:908:6: error: variable
'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]u32 desc_cnt = 0, bytes_remain; ^This variable is not used so remove it.
Applied to 6.4/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 8 lines · Tom Rix
clang with W=1 reports
drivers/scsi/scsi_transport_fc.c:908:6: error: variable
'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]u32 desc_cnt = 0, bytes_remain; ^This variable is not used so remove it.
[...]
Applied to 6.4/scsi-queue, thanks!
[1/1] scsi: scsi_transport_fc: remove unused desc_cnt variable
https://git.kernel.org/mkp/scsi/c/e324dd00fd17
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering