bus: ti-sysc: Remove open coded "ranges" parsing
PATCH 1/1 bus: ti-sysc: Remove open coded "ranges" parsing
"ranges" is a standard property and we have common helper functions for parsing it, so let's use them.
Signed-off-by Rob Herring <[email protected]>
---
Compile tested only!
--- drivers/bus/ti-sysc.c | 41 +++++++++-------------------------------- 1 file changed, 9 insertions(+), 32 deletions(-)
drivers/bus/ti-sysc.c +9 -32
@@ -648,43 +648,20 @@ static int sysc_init_resets(struct sysc *ddata)static int sysc_parse_and_check_child_range (struct sysc *ddata) {struct device_node *np = ddata->dev->of_node; -const __be32 *ranges; -u32 nr_addr, nr_size; -int len, error; - - ranges =of_get_property (np,"ranges" , &len); -if (!ranges) { -dev_err (ddata->dev,"missing ranges for %pOF\n" , np); - -return -ENOENT ; - } - - len /=sizeof (*ranges); - -if (len <3 ) { -dev_err (ddata->dev,"incomplete ranges for %pOF\n" , np); - -return -EINVAL ; - } - - error =of_property_read_u32 (np,"#address-cells" , &nr_addr); -if (error) -return -ENOENT ; +struct of_range_parser parser; +struct of_range range; +int error; - error =of_property_read_u32 (np,"#size-cells" , &nr_size); + error =of_range_parser_init (&parser, np);if (error) -return -ENOENT ; - -if (nr_addr !=1 || nr_size !=1 ) { -dev_err (ddata->dev,"invalid ranges for %pOF\n" , np); +return error; -return -EINVAL ; +for_each_of_range (&parser, &range) { + ddata->module_pa = range.cpu_addr; + ddata->module_size = range.size; +break ; } - ranges++; - ddata->module_pa =of_translate_address (np, ranges++); - ddata->module_size =be32_to_cpup (ranges); -return 0 ; }
Signature · 1 line
2.39.0
Tony Lindgren
maintainerQuoted 2 lines · Rob Herring
"ranges" is a standard property and we have common helper functions for parsing it, so let's use them.
Nice, applying into omap-for-v6.4/ti-sysc.
Thanks,
Tony