i2c: correct I2C deblock logic
PATCH v3 1/1 i2c: correct I2C deblock logic
From: Haibo Chen <[email protected]>
Current code use dm_gpio_get_value() to get SDA and SCL value, and the value depends on whether DTS file config the GPIO_ACTIVE_LOW. In ususal case for i2c GPIO, DTS need to set GPIO_ACTIVE_LOW for SCL/SDA pins. So here the logic is not correct.
And we must not use GPIOD_ACTIVE_LOW in client code include the dm_gpio_set_dir_flags(), it is DTS's responsibility for this flag. So remove GPIOD_ACTIVE_LOW here.
--- drivers/i2c/i2c-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/i2c-uclass.c +2 -2
@@ -508,13 +508,13 @@ static void i2c_gpio_set_pin(struct gpio_desc *pin, int bit)dm_gpio_set_dir_flags (pin,GPIOD_IS_IN ); else dm_gpio_set_dir_flags(pin, GPIOD_IS_OUT | - GPIOD_ACTIVE_LOW |GPIOD_IS_OUT_ACTIVE ); }static int i2c_gpio_get_pin (struct gpio_desc *pin) { -return dm_gpio_get_value (pin); +/* DTS need config GPIO_ACTIVE_LOW */ +return !dm_gpio_get_value (pin); } int i2c_deblock_gpio_loop(struct gpio_desc *sda_pin,
Signature · 1 line
2.34.1
Hello Haibo Chen.
The patch looks fine!
Quoted 42 lines
27 марта 2023 г., в 14:21, [email protected] написал(а):
From: Haibo Chen <[email protected]>
Current code use
dm_gpio_get_value()to get SDA and SCL value, and the value depends on whether DTS file config theGPIO_ACTIVE_LOW. In ususal case for i2c GPIO, DTS need to setGPIO_ACTIVE_LOWfor SCL/SDA pins. So here the logic is not correct.And we must not use
GPIOD_ACTIVE_LOWin client code include thedm_gpio_set_dir_flags(), it is DTS's responsibility for this flag. So removeGPIOD_ACTIVE_LOWhere.Fixes aa54192d4a87 ("dm: i2c: implement gpio-based I2C deblock")Signed-off-by Haibo Chen <[email protected]>---
drivers/i2c/i2c-uclass.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/i2c/i2c-uclass.c +2
-2@@ -508,13 +508,13 @@ static void i2c_gpio_set_pin(struct gpio_desc *pin, int bit)dm_gpio_set_dir_flags (pin,GPIOD_IS_IN ); else dm_gpio_set_dir_flags(pin, GPIOD_IS_OUT | - GPIOD_ACTIVE_LOW |GPIOD_IS_OUT_ACTIVE ); }static int i2c_gpio_get_pin (struct gpio_desc *pin) { -return dm_gpio_get_value (pin); +/* DTS need config GPIO_ACTIVE_LOW */ +return !dm_gpio_get_value (pin); } int i2c_deblock_gpio_loop(struct gpio_desc *sda_pin,Signature · 1 line
2.34.1
Hello haibo,
Quoted 11 lines · On 27.03.23 13:21, [email protected] wrote:
From: Haibo Chen <[email protected]>
Current code use
dm_gpio_get_value()to get SDA and SCL value, and the value depends on whether DTS file config theGPIO_ACTIVE_LOW. In ususal case for i2c GPIO, DTS need to setGPIO_ACTIVE_LOWfor SCL/SDA pins. So here the logic is not correct.And we must not use
GPIOD_ACTIVE_LOWin client code include thedm_gpio_set_dir_flags(), it is DTS's responsibility for this flag. So removeGPIOD_ACTIVE_LOWhere.
Quoted 5 lines
Fixes aa54192d4a87 ("dm: i2c: implement gpio-based I2C deblock")Signed-off-by Haibo Chen <[email protected]>--- drivers/i2c/i2c-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to u-boot-i2c.git master
Thanks!
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]