Skip to contentSkip to conversation

ASoC: dt-bindings: alc5632: Convert to dtschema

PATCH In review Saalim Quadri 3 participants 6 messages Mar 27, 2023 – Mar 30, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 ASoC: dt-bindings: alc5632: Convert to dtschema

Convert the ALC5632 audio codec bindings to DT schema.

---
Changes:
V1 -> V2: Use correct node name
V2 -> V3: Add correct maintainer name
V3 -> V4: Drop alc5632 label name

 .../devicetree/bindings/sound/alc5632.txt     | 43 -------------
 .../bindings/sound/realtek,alc5632.yaml       | 63 +++++++++++++++++++
 2 files changed, 63 insertions(+), 43 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/alc5632.txt
 create mode 100644 Documentation/devicetree/bindings/sound/realtek,alc5632.yaml
Documentation/devicetree/bindings/sound/alc5632.txt deleted +0 -43
deleted file mode 100644
index ffd886d110bd..000000000000
@@ -1,43 +0,0 @@
-ALC5632 audio CODEC
-
-This device supports I2C only.
-
-Required properties:
-
-  - compatible : "realtek,alc5632"
-
-  - reg : the I2C address of the device.
-
-  - gpio-controller : Indicates this device is a GPIO controller.
-
-  - #gpio-cells : Should be two. The first cell is the pin number and the
-    second cell is used to specify optional parameters (currently unused).
-
-Pins on the device (for linking into audio routes):
-
-  * SPK_OUTP
-  * SPK_OUTN
-  * HP_OUT_L
-  * HP_OUT_R
-  * AUX_OUT_P
-  * AUX_OUT_N
-  * LINE_IN_L
-  * LINE_IN_R
-  * PHONE_P
-  * PHONE_N
-  * MIC1_P
-  * MIC1_N
-  * MIC2_P
-  * MIC2_N
-  * MICBIAS1
-  * DMICDAT
-
-Example:
-
-alc5632: alc5632@1e {
-	compatible = "realtek,alc5632";
-	reg = <0x1a>;
-
-	gpio-controller;
-	#gpio-cells = <2>;
-};
Documentation/devicetree/bindings/sound/realtek,alc5632.yaml new file +63 -0

63 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 4 lines · Saalim Quadri

Convert the ALC5632 audio codec bindings to DT schema.

---

I wanted to review it but for some reason you keep ignoring my comment. So one more time:

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Is there something not clear about my request above?

Best regards,
Krzysztof

#2 lore raw
Quoted 4 lines

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Apologies but, this is the output of get_maintainers.pl, is there something that I missed?

I am currently working no 6.3-rc3 as my base kernel.

Quoted 8 lines
saalim@pavilion:~/workspace/linux$ scripts/get_maintainer.pl Documentation/devicetree/bindings/sound/alc5632.txt
Liam Girdwood <[email protected]> (supporter:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...)
Mark Brown <[email protected]> (supporter:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...)
Rob Herring <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[email protected] (moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...)
[email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[email protected] (open list)

Thank you,

Saalim

#3 lore raw
Quoted 10 lines · Saalim Quadri
Quoted 4 lines

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Apologies but, this is the output of get_maintainers.pl, is there something that I missed?

I am currently working no 6.3-rc3 as my base kernel.

Quoted 1 line
saalim@pavilion:~/workspace/linux$ scripts/get_maintainer.pl Documentation/devicetree/bindings/sound/alc5632.txt

It's not the correct way to run it. It should not even work at all - there is no alc5632.txt file, so I really doubt you run it exactly like this. Anyway:

git format-patch -1 -5
scripts/get_maintainer.pl v5-*

and you will get a bit different results.

Best regards,
Krzysztof

#4 lore raw
Quoted 3 lines

git format-patch -1 -5
scripts/get_maintainer.pl v5-*
and you will get a bit different results.

There was a new entry this time, while the rest of the output was same. Leon Romanovsky <[email protected]> (in file)

I added him as a CC here

Thank you,

Saalim

maintainer
#5 lore raw
In reply to Saalim Quadri
Quoted 3 lines · Saalim Quadri

Convert the ALC5632 audio codec bindings to DT schema.

Applied to

broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: alc5632: Convert to dtschema

      commit: 0b57a2d87b4de2a1f01edaf3b00b3d1939792948

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark