PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()
Subsystems (2)
PATCH v2 1/1 PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()
Remove pci_p2pmem_dma() reference,
because pci_p2pmem_dma() method is already removed.
---v1->v2:
1.remove pci_p2pmem_dma() reference directly instead of
using pci_p2pdma_map_segment().
v1 link:
https://lore.kernel.org/lkml/[email protected]/
drivers/pci/p2pdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/pci/p2pdma.c +1 -2
@@ -746,8 +746,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);/** * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with -* the specified list of clients and shortest distance (as determined -* by pci_p2pmem_dma()) +* the specified list of clients and shortest distance * @clients: array of devices to check (NULL-terminated) * @num_clients: number of client devices in the list *
Signature · 1 line
2.34.1
Quoted 4 lines · Cai Huoqing
Remove
pci_p2pmem_dma()reference,
becausepci_p2pmem_dma()method is already removed.Signed-off-by Cai Huoqing <[email protected]>
Looks good to me, thanks.
Quoted 25 lines
---
v1->v2:
1.removepci_p2pmem_dma()reference directly instead of
usingpci_p2pdma_map_segment().v1 link:
https://lore.kernel.org/lkml/[email protected]/drivers/pci/p2pdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/pci/p2pdma.c +1
-2@@ -746,8 +746,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);/** * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with -* the specified list of clients and shortest distance (as determined -* by pci_p2pmem_dma()) +* the specified list of clients and shortest distance * @clients: array of devices to check (NULL-terminated) * @num_clients: number of client devices in the list *
Quoted 2 lines · Cai Huoqing
Remove
pci_p2pmem_dma()reference,
becausepci_p2pmem_dma()method is already removed.
AFAICT, pci_p2pmem_dma() *never* existed. I suppose it was a typo, and pci_p2pdma_distance_many() was intended?
I'm happy to either merge this patch (with an updated commit log) to remove the comment text or merge a patch correct the comment text.
I just don't want to merge this with a commit log that says we removed the pci_p2pmem_dma() method when it never actually existed.
Quoted 29 lines
Signed-off-by Cai Huoqing <[email protected]>---
v1->v2:
1.removepci_p2pmem_dma()reference directly instead of
usingpci_p2pdma_map_segment().v1 link:
https://lore.kernel.org/lkml/[email protected]/drivers/pci/p2pdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/pci/p2pdma.c +1
-2@@ -746,8 +746,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);/** * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with -* the specified list of clients and shortest distance (as determined -* by pci_p2pmem_dma()) +* the specified list of clients and shortest distance * @clients: array of devices to check (NULL-terminated) * @num_clients: number of client devices in the list * Signature · 1 line
2.34.1
Logan Gunthorpe
maintainerQuoted 4 lines · Bjorn Helgaas
Quoted 2 lines · Cai Huoqing
Remove
pci_p2pmem_dma()reference,
becausepci_p2pmem_dma()method is already removed.
Quoted 8 lines
AFAICT,
pci_p2pmem_dma()*never* existed. I suppose it was a typo, andpci_p2pdma_distance_many()was intended?I'm happy to either merge this patch (with an updated commit log) to remove the comment text or merge a patch correct the comment text.
I just don't want to merge this with a commit log that says we removed the
pci_p2pmem_dma()method when it never actually existed.
Ah, yes that's fair. I thought pci_p2pmem_dma() was an odd function name. Good to confirm it never existed.
Thanks,
Logan