Skip to contentSkip to conversation

fs: vboxsf: remove unused out_len variable

PATCH In review Tom Rix 2 participants 2 messages Mar 29, 2023 – Mar 30, 2023

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 fs: vboxsf: remove unused out_len variable

clang with W=1 reports
fs/vboxsf/utils.c:442:9: error: variable
'out_len' set but not used [-Werror,-Wunused-but-set-variable]

        size_t out_len;
               ^

This variable is not used so remove it.

---
 fs/vboxsf/utils.c | 3 ---
 1 file changed, 3 deletions(-)
fs/vboxsf/utils.c +0 -3
index dd0ae1188e87..ab0c9b01a0c2 100644
@@ -439,7 +439,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
 {
 	const char *in;
 	char *out;
-	size_t out_len;
 	size_t out_bound_len;
 	size_t in_bound_len;
 
@@ -447,7 +446,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
 	in_bound_len = utf8_len;
 
 	out = name;
-	out_len = 0;
 	/* Reserve space for terminating 0 */
 	out_bound_len = name_bound_len - 1;
 
@@ -468,7 +466,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
 
 		out += nb;
 		out_bound_len -= nb;
-		out_len += nb;
 	}
 
 	*out = 0;
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 8 lines · Tom Rix

clang with W=1 reports
fs/vboxsf/utils.c:442:9: error: variable
'out_len' set but not used [-Werror,-Wunused-but-set-variable]

        size_t out_len;
               ^

This variable is not used so remove it.

Thanks, patch looks good to me:

Regards,

Hans

Quoted 32 lines
---
 fs/vboxsf/utils.c | 3 ---
 1 file changed, 3 deletions(-)
fs/vboxsf/utils.c +0 -3
index dd0ae1188e87..ab0c9b01a0c2 100644
@@ -439,7 +439,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
 {
 	const char *in;
 	char *out;
-	size_t out_len;
 	size_t out_bound_len;
 	size_t in_bound_len;
 
@@ -447,7 +446,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
 	in_bound_len = utf8_len;
 
 	out = name;
-	out_len = 0;
 	/* Reserve space for terminating 0 */
 	out_bound_len = name_bound_len - 1;
 
@@ -468,7 +466,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
 
 		out += nb;
 		out_bound_len -= nb;
-		out_len += nb;
 	}
 
 	*out = 0;