Skip to contentSkip to conversation

EDAC/amd64: clean up some inconsistent indentings

PATCH Superseded Yang Li 2 participants 2 messages Mar 30, 2023 – Apr 3, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 EDAC/amd64: clean up some inconsistent indentings

drivers/edac/amd64_edac.c:1279 umc_determine_edac_cap() warn: inconsistent indenting

---
 drivers/edac/amd64_edac.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
drivers/edac/amd64_edac.c +10 -10
index 6dad0f1064c0..5c4292e65b96 100644
@@ -1276,19 +1276,19 @@ static unsigned long umc_determine_edac_cap(struct amd64_pvt *pvt)
 	u8 i, umc_en_mask = 0, dimm_ecc_en_mask = 0;
 	unsigned long edac_cap = EDAC_FLAG_NONE;
 
-		for_each_umc(i) {
-			if (!(pvt->umc[i].sdp_ctrl & UMC_SDP_INIT))
-				continue;
+	for_each_umc(i) {
+		if (!(pvt->umc[i].sdp_ctrl & UMC_SDP_INIT))
+			continue;
 
-			umc_en_mask |= BIT(i);
+		umc_en_mask |= BIT(i);
 
-			/* UMC Configuration bit 12 (DimmEccEn) */
-			if (pvt->umc[i].umc_cfg & BIT(12))
-				dimm_ecc_en_mask |= BIT(i);
-		}
+		/* UMC Configuration bit 12 (DimmEccEn) */
+		if (pvt->umc[i].umc_cfg & BIT(12))
+			dimm_ecc_en_mask |= BIT(i);
+	}
 
-		if (umc_en_mask == dimm_ecc_en_mask)
-			edac_cap = EDAC_FLAG_SECDED;
+	if (umc_en_mask == dimm_ecc_en_mask)
+		edac_cap = EDAC_FLAG_SECDED;
 
 	return edac_cap;
 }
Signature · 1 line
2.20.1.7.g153144c
maintainer
#1 lore raw
Quoted 6 lines · Yang Li

drivers/edac/amd64_edac.c:1279 umc_determine_edac_cap() warn: inconsistent indenting

---

Hi Yang,

Thanks for the patch.

It looks like this issue was introduced with the following commit.

f6a4b4a1aa16 ("EDAC/amd64: Split determine_edac_cap() into dct/umc functions")

Can you please include a Fixes tag and describe your changes in the commit message?

Thanks,
Yazen