Improve igt_doc.py
v2 cover Improve igt_doc.py
From: Mauro Carvalho Chehab <[email protected]>
This series do some improvements at the igt_doc.py tool:
- It does some tweaks at the Xe documentation hierarchy;
- It adds support to generate test lists from documentation;
- It splits the script on two parts: one with the TestList class definition and another one with the toll itself;
- While here, add missing documentation for two new tests;
- Check if the documentation matches the actual tests at build time, in order to prevent it to become outdated.
---
v2:
- add a patch at the end to avoid a gitlab pipeline breakage.
Mauro Carvalho Chehab (12):
xe_test_config.json: do some adjustments at the output hierarchy scripts/igt_doc.py: move show_subtests logic to the class scripts/igt_doc.py: add support to generate testlists scripts/igt_doc.py: prepare to place TestList class on a separate file scripts/test_list.py: prepare to place class on a separate file scripts/igt_doc.py: re-introduce it by calling test_list.py scripts/test_list.py: better handle documentation validation issues scripts/test_list.py: add support for igt_simple_main testplan/meson.build: Validate documentation at build time xe/xe_vm: add documentation for igt@xe_vm@userptr-invalid xe/xe_noexec_ping_pong: document subtest runner/meson.build: fix minimal build
docs/testplan/meson.build | 8 +- meson.build | 1 + runner/meson.build | 6 +- scripts/igt_doc.py | 1038 +----------------------------- scripts/test_list.py | 1084 ++++++++++++++++++++++++++++++++ tests/xe/xe_noexec_ping_pong.c | 26 +- tests/xe/xe_test_config.json | 30 +- tests/xe/xe_vm.c | 10 +- 8 files changed, 1144 insertions(+), 1059 deletions(-) create mode 100755 scripts/test_list.py
Signature · 1 line
2.39.2
PATCH v2 1/12 xe_test_config.json: do some adjustments at the output hierarchy
From: Mauro Carvalho Chehab <[email protected]>
Place "Mega feature" inside the same hierarchical level, placing it on a higher level than sub-category, as this provides a higher level of group for functionalities.
While here, better document the fields.
--- tests/xe/xe_test_config.json | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-)
tests/xe/xe_test_config.json +15 -15
@@ -4,27 +4,27 @@ "fields": { "Category": { "_properties_": { - "description": "Contains the major group for the tested functionality" + "description": "Contains the major group for the tested functionality, being hardware, software or firmware" }, - "Sub-category": { + "Mega feature": { "_properties_": { - "description": "Contains the minor group of the functionality" - }, - "Functionality": { - "_properties_": { - "description": "Groups page table tests per functionality" - } + "description": "Contains the mega feature for end to end use case, e. g. the 'sellable' feature." }, - "Run type": { + "Sub-category": { "_properties_": { - "description": "Defines what category of testlist it belongs" + "description": "Contains the the technical feature/functionality" + }, + "Functionality": { + "_properties_": { + "description": "Groups page table tests on buckets containg more detailed functionality" + } + }, + "Run type": { + "_properties_": { + "description": "Defines what category of testlist it belongs" + } } } - }, - "Mega feature": { - "_properties_": { - "description": "Contains the mega feature for E2E use case" - } } }, "Test category": {
Signature · 1 line
2.39.2
PATCH v2 2/12 scripts/igt_doc.py: move show_subtests logic to the class
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
Simplify the main code and avoid warnings about global vars with pylint by moving its code to a separate function.
--- scripts/igt_doc.py | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-)
scripts/igt_doc.py +20 -14
@@ -1018,6 +1018,25 @@ class TestList: sys.exit(f"{fname}:{file_ln + 1}: Error: unrecognized line. Need to add field at %s?\n\t==> %s" % (self.config_fname, file_line)) + def show_subtests(self, sort_field, filter_field): + + """Show subtests, allowing sort and filter a field """ + + if sort_field: + test_subtests = tests.get_subtests(sort_field, filter_field) + for val_key in sorted(test_subtests.keys()): + if not test_subtests[val_key]: + continue + if val_key == "": + print("not defined:") + else: + print(f"{val_key}:") + for sub in test_subtests[val_key]: + print (f" {sub}") + else: + for sub in tests.get_subtests(sort_field, filter_field)[""]: + print (sub) + # # Main #
@@ -1056,20 +1075,7 @@ tests = TestList(parse_args.config, parse_args.include_plan, parse_args.files) RUN = 0 if parse_args.show_subtests: RUN = 1 - if parse_args.sort_field: - test_subtests = tests.get_subtests(parse_args.sort_field, parse_args.filter_field) - for val_key in sorted(test_subtests.keys()): - if not test_subtests[val_key]: - continue - if val_key == "": - print("not defined:") - else: - print(f"{val_key}:") - for sub in test_subtests[val_key]: - print (f" {sub}") - else: - for sub in tests.get_subtests(parse_args.sort_field, parse_args.filter_field)[""]: - print (sub) + tests.show_subtests(parse_args.sort_field, parse_args.filter_field) if parse_args.check_testlist: RUN = 1
Signature · 1 line
2.39.2
PATCH v2 3/12 scripts/igt_doc.py: add support to generate testlists
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
As the testlists are part of the documentation, add support to generate them from the documentation on an specified directory.
--- scripts/igt_doc.py | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
scripts/igt_doc.py +37 -0
@@ -1037,6 +1037,35 @@ class TestList: for sub in tests.get_subtests(sort_field, filter_field)[""]: print (sub) + def gen_testlist(self, directory, sort_field, filter_field): + + """Generate testlists from the test documentation""" + + test_prefix = os.path.commonprefix(self.get_subtests()[""]) + test_prefix = re.sub(r'^igt@', '', test_prefix) + + test_subtests = self.get_subtests(sort_field, filter_field) + + for test in test_subtests.keys(): # pylint: disable=C0201,C0206 + if not test_subtests[test]: + continue + + testlist = test.lower() + if testlist == "": + fname = "other" + elif testlist == "bat": + fname = "fast-feedback" + else: + fname = testlist + + fname = directory + "/" + test_prefix + fname + ".testlist" + fname = re.sub(r"[\s_]+", "-", fname) + + with open(fname, 'w', encoding='utf8') as handler: + for sub in test_subtests[test]: + handler.write (f"{sub}\n") + print(f"{fname} created.") + # # Main #
@@ -1065,6 +1094,8 @@ parser.add_argument("--include-plan", action="store_true", parser.add_argument("--igt-build-path", help="Path where the IGT runner is sitting. Used by --check-testlist.", default=IGT_BUILD_PATH) +parser.add_argument("--gen-testlist", + help="Generate documentation at the GEN_TESTLIST directory, using SORT_FIELD to split the tests. Requires --sort-field.") parser.add_argument('--files', nargs='+', help="File name(s) to be processed")
@@ -1081,6 +1112,12 @@ if parse_args.check_testlist: RUN = 1 tests.check_tests() +if parse_args.gen_testlist: + RUN = 1 + if not parse_args.sort_field: + sys.exit("Need a field to split the testlists") + tests.gen_testlist(parse_args.gen_testlist, parse_args.sort_field, parse_args.filter_field) + if parse_args.to_json: RUN = 1 tests.print_json(parse_args.to_json)
Signature · 1 line
2.39.2
PATCH v2 4/12 scripts/igt_doc.py: prepare to place TestList class on a separate file
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
Do some changes at the code to avoid depending on global vars and to declare plural ancillary function as static.
--- scripts/igt_doc.py | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-)
scripts/igt_doc.py +15 -8
@@ -51,7 +51,7 @@ def _sort_using_array(item, array): # As suggested at https://stackoverflow.com/questions/18902608/generating-the-plural-form-of-a-noun/19018986 # -def plural(field): +def _plural(field): """ Poor man's conversion to plural.
@@ -232,7 +232,8 @@ class TestList: Description: test ioctls """ - def __init__(self, config_fname, include_plan, file_list): + def __init__(self, config_fname, include_plan = False, file_list = False, + igt_build_path = None, igt_runner = None): self.doc = {} self.test_number = 0 self.config = None
@@ -240,6 +241,8 @@ class TestList: self.plan_filenames = [] self.props = {} self.config_fname = config_fname + self.igt_build_path = igt_build_path + self.igt_runner = igt_runner self.level_count = 0 self.field_list = {} self.title = None
@@ -264,7 +267,7 @@ class TestList: field_lc = field.lower() self.field_list[field_lc] = field - field_plural = plural(field_lc) + field_plural = _plural(field_lc) if field_lc != field_plural: self.field_list[field_plural] = field
@@ -757,6 +760,9 @@ class TestList: """Compare documented subtests with the IGT test list""" + if not self.igt_build_path or not self.igt_runner: + sys.exit("Need the IGT build path and igt_runner executable file name") + doc_subtests = sorted(self.get_subtests()[""]) for i in range(0, len(doc_subtests)): # pylint: disable=C0200
@@ -766,9 +772,9 @@ class TestList: # Get a list of tests from try: - result = subprocess.run([ f"{IGT_BUILD_PATH}/{IGT_RUNNER}", + result = subprocess.run([ f"{self.igt_build_path}/{self.igt_runner}", "-L", "-t", test_prefix, - f"{IGT_BUILD_PATH}/tests"], check = True, + f"{self.igt_build_path}/tests"], check = True, stdout=subprocess.PIPE, universal_newlines=True) except subprocess.CalledProcessError as sub_err: print(sub_err.stderr)
@@ -1023,7 +1029,7 @@ class TestList: """Show subtests, allowing sort and filter a field """ if sort_field: - test_subtests = tests.get_subtests(sort_field, filter_field) + test_subtests = self.get_subtests(sort_field, filter_field) for val_key in sorted(test_subtests.keys()): if not test_subtests[val_key]: continue
@@ -1034,7 +1040,7 @@ class TestList: for sub in test_subtests[val_key]: print (f" {sub}") else: - for sub in tests.get_subtests(sort_field, filter_field)[""]: + for sub in self.get_subtests(sort_field, filter_field)[""]: print (sub) def gen_testlist(self, directory, sort_field, filter_field):
@@ -1101,7 +1107,8 @@ parser.add_argument('--files', nargs='+', parse_args = parser.parse_args() -tests = TestList(parse_args.config, parse_args.include_plan, parse_args.files) +tests = TestList(parse_args.config, parse_args.include_plan, parse_args.files, + IGT_BUILD_PATH, IGT_RUNNER) RUN = 0 if parse_args.show_subtests:
Signature · 1 line
2.39.2
PATCH v2 5/12 scripts/test_list.py: prepare to place class on a separate file
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
Rename scripts/igt_doc.py to scripts/test_list.py, preparing to split the main function from the class definition.
That allows re-using the class by other programs as well. It also makes the module better organized, and ensures that all variables inside the class are not global.
While this could be folded with the next patch, by splitting it on two, it makes a lot easier to review the code changes, as most of the contents of the igt_doc.py are actually the TestList class.
The next patch will re-introduce scripts/igt_doc.py, dropping the global vars and the main code from test_list.py.
---
scripts/{igt_doc.py => test_list.py} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename scripts/{igt_doc.py => test_list.py} (100%)scripts/test_list.py renamed from scripts/igt_doc.py +0 -0
Signature · 1 line
2.39.2
PATCH v2 6/12 scripts/igt_doc.py: re-introduce it by calling test_list.py
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
Now that the class on a separate file, move the argument parser to igt_doc.py.
--- scripts/igt_doc.py | 80 ++++++++++++++++++++++++++++++++++++++++++++ scripts/test_list.py | 67 ------------------------------------- 2 files changed, 80 insertions(+), 67 deletions(-) create mode 100755 scripts/igt_doc.py
scripts/igt_doc.py new file +80 -0
@@ -0,0 +1,80 @@ +#!/usr/bin/env python3 +# pylint: disable=C0301 +# SPDX-License-Identifier: (GPL-2.0 OR MIT) + +## Copyright (C) 2023 Intel Corporation ## +## Author: Mauro Carvalho Chehab <[email protected]> ## +## ## +## Allow keeping inlined test documentation and validate ## +## if the documentation is kept updated. ## + +"""Maintain test plan and test implementation documentation on IGT.""" + +import argparse + +from test_list import TestList + +IGT_BUILD_PATH = 'build' +IGT_RUNNER = 'runner/igt_runner' + +parser = argparse.ArgumentParser(description = "Print formatted kernel documentation to stdout.", + formatter_class = argparse.ArgumentDefaultsHelpFormatter, + epilog = 'If no action specified, assume --rest.') +parser.add_argument("--config", required = True, + help="JSON file describing the test plan template") +parser.add_argument("--rest", + help="Output documentation from the source files in REST file.") +parser.add_argument("--per-test", action="store_true", + help="Modifies ReST output to print subtests per test.") +parser.add_argument("--to-json", + help="Output test documentation in JSON format as TO_JSON file") +parser.add_argument("--show-subtests", action="store_true", + help="Shows the name of the documented subtests in alphabetical order.") +parser.add_argument("--sort-field", + help="modify --show-subtests to sort output based on SORT_FIELD value") +parser.add_argument("--filter-field", + help="modify --show-subtests to filter output based a regex given by FILTER_FIELD=~'regex'") +parser.add_argument("--check-testlist", action="store_true", + help="Compare documentation against IGT runner testlist.") +parser.add_argument("--include-plan", action="store_true", + help="Include test plans, if any.") +parser.add_argument("--igt-build-path", + help="Path where the IGT runner is sitting. Used by --check-testlist.", + default=IGT_BUILD_PATH) +parser.add_argument("--gen-testlist", + help="Generate documentation at the GEN_TESTLIST directory, using SORT_FIELD to split the tests. Requires --sort-field.") +parser.add_argument("--igt-runner", + help="Path where the IGT runner is sitting. Used by --check-testlist.", + default=IGT_RUNNER) +parser.add_argument('--files', nargs='+', + help="File name(s) to be processed") + +parse_args = parser.parse_args() + +tests = TestList(parse_args.config, parse_args.include_plan, parse_args.files, + parse_args.igt_build_path, parse_args.igt_runner) + +RUN = 0 +if parse_args.show_subtests: + RUN = 1 + tests.show_subtests(parse_args.sort_field, parse_args.filter_field) + +if parse_args.check_testlist: + RUN = 1 + tests.check_tests() + +if parse_args.gen_testlist: + RUN = 1 + if not parse_args.sort_field: + sys.exit("Need a field to split the testlists") + tests.gen_testlist(parse_args.gen_testlist, parse_args.sort_field, parse_args.filter_field) + +if parse_args.to_json: + RUN = 1 + tests.print_json(parse_args.to_json) + +if not RUN or parse_args.rest: + if parse_args.per_test: + tests.print_rest_flat(parse_args.rest) + else: + tests.print_nested_rest(parse_args.rest)
scripts/test_list.py +0 -67
82 lines not on this page · raw message
Signature · 1 line
2.39.2
PATCH v2 7/12 scripts/test_list.py: better handle documentation validation issues
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
Produce warnings and exit with an error when test plan is out of sync.
--- scripts/test_list.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
scripts/test_list.py +4 -6
@@ -803,16 +803,14 @@ class TestList: run_missing.append(run_test) if doc_uneeded: - print("Unused documentation") for test_name in doc_uneeded: - print(test_name) + print(f"Warning: Documented {test_name} doesn't exist on source files") if run_missing: - if doc_uneeded: - print() - print("Missing documentation") for test_name in run_missing: - print(test_name) + print(f'Warning: Missing documentation for {test_name}') + if doc_uneeded or run_missing: + sys.exit(1) # # File handling methods
Signature · 1 line
2.39.2
PATCH v2 8/12 scripts/test_list.py: add support for igt_simple_main
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
when igt_simple_main is used, there will be a single unamed subtest. Add support for it.
On such case, the documentation will be like:
/**
* TEST: Test foo
* Category: Software building block
* Sub-category: foo
* Test category: functionality test
* Run type: BAT
*
* SUBTEST:
* Description: foo description
*/
--- scripts/test_list.py | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)
scripts/test_list.py +19 -2
@@ -176,6 +176,22 @@ class TestList: The SUBTEST contains the fields that are specific to each subtest. + Note: when igt_simple_main is used, there will be a single nameless + subtest. On such case, "SUBTEST:" is still needed, but without a + test name on it, e. g., it would be documented as: + + /** + * TEST: some test that uses igt_simple_main + * Category: Software build block + * Sub-category: documentation + * Functionality: test documentation + * Issue: none + * Description: Complete description of this test + * + * SUBTEST: + * Description: do foo things + */ + Some IGT tests may have strings or integer wildcards, like: test-%s-%ld-size
@@ -376,8 +392,9 @@ class TestList: subtest_array = [] for subtest in self.doc[test]["subtest"].keys(): - summary = test_name + '@' + self.doc[test]["subtest"][subtest]["Summary"] - + summary = test_name + if self.doc[test]["subtest"][subtest]["Summary"] != '': + summary += '@' + self.doc[test]["subtest"][subtest]["Summary"] if not summary: continue
Signature · 1 line
2.39.2
PATCH v2 9/12 testplan/meson.build: Validate documentation at build time
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
If the tests are build too, check if the documentation match the name of the tests.
--- docs/testplan/meson.build | 8 ++++++-- meson.build | 1 + 2 files changed, 7 insertions(+), 2 deletions(-)
docs/testplan/meson.build +6 -2
@@ -8,12 +8,16 @@ stylesheet = join_paths(meson.current_source_dir(), 'testplan.css') xe_test_config = join_paths(source_root, 'tests', 'xe', 'xe_test_config.json') -if not build_tests +check_testlist = '' +if build_tests + # Check if documentation matches the actual tests + check_testlist = [ '--check-testlist', '--igt-build-path', build_root ] +else test_executables = [] endif test_dict = { 'xe_tests': - { 'input': xe_test_config, 'extra_args': [] } + { 'input': xe_test_config, 'extra_args': check_testlist } } foreach testplan, fields: test_dict
meson.build +1 -0
@@ -15,6 +15,7 @@ endif # meson.source_root is marked as a future-deprecated feature source_root = meson.current_source_dir() +build_root = meson.current_build_dir() cc = meson.get_compiler('c')
Signature · 1 line
2.39.2
PATCH v2 10/12 xe/xe_vm: add documentation for igt@xe_vm@userptr-invalid
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
Solves this build-time warning:
Warning: Missing documentation for igt@xe_vm@userptr-invalid
--- tests/xe/xe_vm.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
tests/xe/xe_vm.c +7 -3
@@ -294,9 +294,13 @@ static void unbind_all(int fd, int n_vmas)#define MAP_ADDRESS 0x00007fadeadbe000 -/* -* This tests verifies that mapping an invalid userptr returns -EFAULT, -* and that it is correctly handled. +/** +* SUBTEST: userptr-invalid +* Description: +* Verifies that mapping an invalid userptr returns -EFAULT, +* and that it is correctly handled. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category */ static void userptr_invalid (int fd) {
Signature · 1 line
2.39.2
PATCH v2 11/12 xe/xe_noexec_ping_pong: document subtest
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
Use the SUBTEST tag to add the subtest's description to the IGT test plan documentation.
--- tests/xe/xe_noexec_ping_pong.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-)
tests/xe/xe_noexec_ping_pong.c +14 -12
@@ -20,20 +20,22 @@* Category: Software building block * Sub-category: compute * Test category: functionality test -*/ - -/* -* This test creates compute vms, binds a couple of bos and an engine each, -* thus redying it for execution. However, VRAM memory is over- -* committed and while there is still nothing to execute, an eviction -* will trigger the VM's rebind worker to rebind the evicted bo, which -* will in turn trigger another eviction and so on. * -* Since we don't have eviction stats yet we need to watch "top" for -* the rebind kworkers using a lot of CPU while the test idles. +* SUBTEST: +* Description: +* This test creates compute vms, binds a couple of bos and an engine each, +* thus redying it for execution. However, VRAM memory is over- +* committed and while there is still nothing to execute, an eviction +* will trigger the VM's rebind worker to rebind the evicted bo, which +* will in turn trigger another eviction and so on. +* +* Since we don't have eviction stats yet we need to watch "top" for +* the rebind kworkers using a lot of CPU while the test idles. * -* The correct driver behaviour should be not to rebind anything unless -* there is worked queued on one of the VM's compute engines. +* The correct driver behaviour should be not to rebind anything unless +* there is worked queued on one of the VM's compute engines. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category */ static void test_ping_pong (int fd,struct drm_xe_engine_class_instance *eci) {
Signature · 1 line
2.39.2
PATCH v2 12/12 runner/meson.build: fix minimal build
In reply to Mauro Carvalho ChehabFrom: Mauro Carvalho Chehab <[email protected]>
Minimal pipeline s now failing:
https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/38824636
This doesn't seem to be related to the patches at the series from where the issue was reported, but addressing it is simple enough:
just remove the error and change the logic to properly validate the possible options.
--- runner/meson.build | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
runner/meson.build +1 -5
@@ -24,11 +24,7 @@ if liboping.found() runner_c_args += '-DHAVE_OPING=1' endif -if not build_tests and jsonc.found() - error('Building test runner requires building tests') -endif - -if jsonc.found() +if jsonc.found() and build_tests subdir('testdata') runnerlib = static_library('igt_runner', runnerlib_sources,
Signature · 1 line
2.39.2
Re: [igt-dev] [PATCH i-g-t v2 12/12] runner/meson.build: fix minimal build
Hi Mauro,
Quoted 3 lines · Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <[email protected]>
Minimal pipeline s now failing:
------------------ ^
s/s/is/
Quoted 17 lines
https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/38824636This doesn't seem to be related to the patches at the series from where the issue was reported, but addressing it is simple enough:
just remove the error and change the logic to properly validate the possible options.Signed-off-by Mauro Carvalho Chehab <[email protected]>--- runner/meson.build | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)runner/meson.build +0
-0
runner/meson.build if liboping.found() · line 29
Quoted 6 lines
runner/meson.build +0
-3@@ -24,11 +24,7 @@ if liboping.found() runner_c_args += '-DHAVE_OPING=1' endif -if not build_tests and jsonc.found() - error('Building test runner requires building tests') -endif
imho:
if jsonc.found() and not build_tests
is more clear what we need here.
Btw this is error from that build link:
docs/testplan/meson.build:24:1: ERROR: Invalid use of addition: can only concatenate list (not "str") to list
I do not see how runner/meson.build is related to docs/testplan/meson.build ?
+cc Petri
Regards,
Kamil
Quoted 9 lines
runner/meson.build +1
-2- -if jsonc.found() +if jsonc.found() and build_tests subdir('testdata') runnerlib = static_library('igt_runner', runnerlib_sources,Signature · 1 line
2.39.2
Re: [igt-dev] [PATCH i-g-t v2 12/12] runner/meson.build: fix minimal build
Quoted 29 lines · On Fri, 31 Mar 2023 11:13:19 +0200 Kamil Konieczny…
Hi Mauro,
Quoted 3 lines · Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <[email protected]>
Minimal pipeline s now failing:
------------------ ^
s/s/is/Quoted 20 lines
https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/38824636This doesn't seem to be related to the patches at the series from where the issue was reported, but addressing it is simple enough:
just remove the error and change the logic to properly validate the possible options.Signed-off-by Mauro Carvalho Chehab <[email protected]>--- runner/meson.build | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)runner/meson.build +0
-0@@ -24,11 +24,7 @@ if liboping.found() runner_c_args += '-DHAVE_OPING=1' endif
Quoted 8 lines
runner/meson.build if liboping.found() · line 29
Quoted 3 lines
runner/meson.build +0
-3-if not build_tests and jsonc.found() - error('Building test runner requires building tests') -endifimho:
ifjsonc.found()and notbuild_testsis more clear what we need here.
IMO, this is less clear ;-) I mean, refusing to run because jsonc is installed and -Dtests=false sounds a very bad idea.
What we want instead is to have the runner built only if build_tests is selected (and the required jsonc library is installed).
This is what this patch does.
Quoted 3 lines
Btw this is error from that build link:
docs/testplan/meson.build:24:1: ERROR: Invalid use of addition: can only concatenate list (not "str") to list
This was due to CI Gitlab pipeline usage of meson 0.49.2. With meson 1.0.0 (shipped with Fedora), this doesn't occur.
Anyway, the fix for it was fold at the patch that introduced the issue in docs/testplan/meson.build (patch 09/12).
Quoted 1 line
I do not see how runner/meson.build is related to docs/testplan/meson.build ?
It is not related at all. Yet, without this patch, the error may break CI pipelines if:
- jsonc is installed
- meson is called with:
meson -Dtests=disabled build
Regards,
Mauro
Re: [igt-dev] [PATCH i-g-t v2 12/12] runner/meson.build: fix minimal build
Quoted 39 lines · On Fri, 31 Mar 2023 12:39:19 +0200 Mauro Carvalho Chehab…
Quoted 36 lines · On Fri, 31 Mar 2023 11:13:19 +0200 Kamil Konieczny…
Hi Mauro,
Quoted 3 lines · Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <[email protected]>
Minimal pipeline s now failing:
------------------ ^
s/s/is/Quoted 17 lines
https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/38824636This doesn't seem to be related to the patches at the series from where the issue was reported, but addressing it is simple enough:
just remove the error and change the logic to properly validate the possible options.Signed-off-by Mauro Carvalho Chehab <[email protected]>--- runner/meson.build | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)runner/meson.build +0
-0runner/meson.build if liboping.found() · line 29
Quoted 6 lines
runner/meson.build +0
-3@@ -24,11 +24,7 @@ if liboping.found() runner_c_args += '-DHAVE_OPING=1' endif -if not build_tests and jsonc.found() - error('Building test runner requires building tests') -endifimho:
ifjsonc.found()and notbuild_tests
Quoted 7 lines
Quoted 1 line
is more clear what we need here.
IMO, this is less clear ;-) I mean, refusing to run because jsonc is installed and -Dtests=false sounds a very bad idea.
What we want instead is to have the runner built only if
build_testsis selected (and the required jsonc library is installed).
Btw, this error can be seen vanilla upstream if you have json-c installed on some machine and run:
$ meson -Dtests=disabled build-err The Meson build system Version: 0.53.2
...
Run-time dependency json-c found: YES 0.13.1
...
runner/meson.build:28:1: ERROR: Problem encountered: Building test runner requires building tests
A full log can be found at /home/mchehab/freedesktop-igt/build-err/meson-logs/meson-log.txt
Regards,
Mauro
Kamil Konieczny
Acked-byRe: [igt-dev] [PATCH i-g-t v2 12/12] runner/meson.build: fix minimal build
In reply to Mauro Carvalho ChehabHi Mauro,
Quoted 41 lines · Mauro Carvalho Chehab
Quoted 29 lines · On Fri, 31 Mar 2023 11:13:19 +0200 Kamil Konieczny…
Hi Mauro,
Quoted 3 lines · Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <[email protected]>
Minimal pipeline s now failing:
------------------ ^
s/s/is/Quoted 20 lines
https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/38824636This doesn't seem to be related to the patches at the series from where the issue was reported, but addressing it is simple enough:
just remove the error and change the logic to properly validate the possible options.Signed-off-by Mauro Carvalho Chehab <[email protected]>--- runner/meson.build | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)runner/meson.build +0
-0@@ -24,11 +24,7 @@ if liboping.found() runner_c_args += '-DHAVE_OPING=1' endifQuoted 8 lines
runner/meson.build if liboping.found() · line 29
Quoted 3 lines
runner/meson.build +0
-3-if not build_tests and jsonc.found() - error('Building test runner requires building tests') -endifimho:
ifjsonc.found()and notbuild_testsis more clear what we need here.
Quoted 7 lines
IMO, this is less clear ;-) I mean, refusing to run because jsonc is installed and -Dtests=false sounds a very bad idea.
What we want instead is to have the runner built only if
build_testsis selected (and the required jsonc library is installed).This is what this patch does.
Thank you for explanations,
--
Kamil
Quoted 20 lines
Quoted 4 lines
Btw this is error from that build link:
docs/testplan/meson.build:24:1: ERROR: Invalid use of addition: can only concatenate list (not "str") to list
This was due to CI Gitlab pipeline usage of meson 0.49.2. With meson 1.0.0 (shipped with Fedora), this doesn't occur.
Anyway, the fix for it was fold at the patch that introduced the issue in docs/testplan/meson.build (patch 09/12).
Quoted 1 line
I do not see how runner/meson.build is related to docs/testplan/meson.build ?
It is not related at all. Yet, without this patch, the error may break CI pipelines if:
- jsonc is installed
- meson is called with:
meson -Dtests=disabled buildRegards,
Mauro
Patchwork
CI[igt-dev] ✗ GitLab.Pipeline: warning for Improve igt_doc.py (rev2)
In reply to Mauro Carvalho Chehab== Series Details ==
== Series Details ==
Series: Improve igt_doc.py (rev2)
URL : https://patchwork.freedesktop.org/series/115667/
State : warning
== Summary ==
Pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/843145 for the overview.
build:tests-debian-minimal has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/39018529):
Program rst2man-3 found: NO
Program rst2man found: NO
Program rst2man.sh found: YES (/builds/gfx-ci/igt-ci-tags/man/rst2man.sh)
Program igt_doc.py found: YES (/builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py)
Program gen_rst_index found: YES (/builds/gfx-ci/igt-ci-tags/scripts/gen_rst_index) Dependency gtk-doc found: NO (tried pkgconfig and cmake)
Program sphinx-build found: NO
Program rst2html-3 found: NO
Program rst2html found: NO
Program rst2pdf found: NO
docs/testplan/meson.build:24:1: ERROR: Invalid use of addition: can only concatenate list (not "str") to list
A full log can be found at /builds/gfx-ci/igt-ci-tags/build/meson-logs/meson-log.txt section_end:1680156901:step_script section_start:1680156901:cleanup_file_variables
Cleaning up project directory and file based variables section_end:1680156902:cleanup_file_variables
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/843145
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for Improve igt_doc.py (rev2)
In reply to Mauro Carvalho Chehab== Series Details ==
== Series Details ==
Series: Improve igt_doc.py (rev2)
URL : https://patchwork.freedesktop.org/series/115667/
State : success
== Summary ==
CI Bug Log - changes from IGT_7227 -> IGTPW_8719
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/index.html
Participating hosts (36 -> 36)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8719 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/fi-kbl-soraka/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][3] ([i915#7156] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/fi-kbl-soraka/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][4] ([i915#1886])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271]) +16 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/fi-kbl-soraka/igt@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rplp-1: NOTRUN -> [SKIP][6] ([i915#7828])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/bat-rplp-1/igt@[email protected]
- bat-dg2-11: NOTRUN -> [SKIP][7] ([i915#7828])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/bat-dg2-11/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- bat-dg2-11: [INCOMPLETE][8] ([i915#7913]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/bat-dg2-11/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/bat-dg2-11/igt@i915_selftest@[email protected]
- bat-rplp-1: [ABORT][10] ([i915#7913]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/bat-rplp-1/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/bat-rplp-1/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][12] ([i915#7699]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/bat-dg2-11/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/bat-dg2-11/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-FAIL][14] ([i915#6367] / [i915#7996]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/bat-rpls-1/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
- bat-dg2-8: [FAIL][16] ([i915#7932]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7227 -> IGTPW_8719
CI-20190529: 20190529
CI_DRM_12937: 6848d3613c0a63382d00ff550c41394902bda903 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8719: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/index.html
IGT_7227: 5dfa3675c36bab82cdda056db7ef622363c324ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for Improve igt_doc.py (rev2)
In reply to Mauro Carvalho Chehab== Series Details ==
== Series Details ==
Series: Improve igt_doc.py (rev2)
URL : https://patchwork.freedesktop.org/series/115667/
State : success
== Summary ==
CI Bug Log - changes from IGT_7227_full -> IGTPW_8719_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in IGTPW_8719_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rps@engine-order:
- shard-apl: [PASS][1] -> [FAIL][2] ([i915#6537])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-apl1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-apl2/igt@[email protected]
* igt@i915_pm_rps@reset:
- shard-snb: [PASS][3] -> [DMESG-FAIL][4] ([i915#8319])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-snb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-snb7/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#3886]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-glk7/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#3886]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-apl3/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium_hpd@hdmi-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][7] ([fdo#109271]) +29 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-apl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271]) +73 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-snb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271]) +13 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-glk9/igt@[email protected]
* igt@kms_vblank@pipe-b-query-forked-busy-hang:
- shard-apl: [PASS][10] -> [SKIP][11] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-apl4/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-apl2/igt@[email protected]
- shard-glk: [PASS][12] -> [SKIP][13] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-glk1/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-glk1/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][14] ([i915#6268]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-tglu-6/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-tglu-3/igt@[email protected]
* igt@gem_eio@in-flight-contexts-1us:
- shard-apl: [TIMEOUT][16] ([i915#3063]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-apl6/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-apl4/igt@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][18] ([i915#2842]) -> [PASS][19] +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-apl4/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-apl1/igt@gem_exec_fair@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- {shard-dg1}: [SKIP][20] ([i915#1397]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-dg1-14/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-dg1-18/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][22] ([i915#2346]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-glk3/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-glk1/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][24] ([i915#2346]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@fbc-suspend:
- {shard-tglu}: [FAIL][26] ([i915#4767]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-tglu-10/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-tglu-8/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1:
- shard-glk: [FAIL][28] ([i915#79]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-glk7/igt@kms_flip@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [ABORT][30] ([i915#180]) -> [PASS][31] +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-apl3/igt@kms_flip@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-apl7/igt@kms_flip@[email protected]
#### Warnings ####
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-snb: [ABORT][32] -> [SKIP][33] ([fdo#109271])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7227/shard-snb7/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/shard-snb4/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5251]: https://gitlab.freedesktop.org/drm/intel/issues/5251
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
[i915#8319]: https://gitlab.freedesktop.org/drm/intel/issues/8319
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7227 -> IGTPW_8719
CI-20190529: 20190529
CI_DRM_12937: 6848d3613c0a63382d00ff550c41394902bda903 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8719: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/index.html
IGT_7227: 5dfa3675c36bab82cdda056db7ef622363c324ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8719/index.html