RDMA/cma: Remove NULL check before dev_{put, hold}
PATCH 1/1 RDMA/cma: Remove NULL check before dev_{put, hold}
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warnings:
./drivers/infiniband/core/cma.c:713:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. ./drivers/infiniband/core/cma.c:2433:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
--- drivers/infiniband/core/cma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/infiniband/core/cma.c +2 -4
@@ -709,8 +709,7 @@ cma_validate_port(struct ib_device *device, u32 port, } sgid_attr =rdma_find_gid_by_port (device, gid, gid_type, port, ndev); -if (ndev) -dev_put (ndev); +dev_put (ndev);return sgid_attr; }
@@ -2429,8 +2428,7 @@ static int cma_ib_req_handler(struct ib_cm_id *cm_id,mutex_unlock (&listen_id->handler_mutex); net_dev_put: -if (net_dev) -dev_put (net_dev); +dev_put (net_dev);return ret; }
Signature · 1 line
2.20.1.7.g153144c
Leon Romanovsky
AppliedQuoted 8 lines · Yang Li
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warnings:
./drivers/infiniband/core/cma.c:713:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. ./drivers/infiniband/core/cma.c:2433:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
[...]
Applied, thanks!
[1/1] RDMA/cma: Remove NULL check before dev_{put, hold}
https://git.kernel.org/rdma/rdma/c/08ebf57f6e1d73
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>